Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1179435 > unrolled thread
| Started by | Nicolas Schier <nicolas@fjasle.eu> |
|---|---|
| First post | 2023-12-20 08:40 +0100 |
| Last post | 2023-12-23 07:50 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Bug#1012720: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic Nicolas Schier <nicolas@fjasle.eu> - 2023-12-20 08:40 +0100
Bug#1012720: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic Nilesh Patra <nilesh@debian.org> - 2023-12-21 18:50 +0100
Bug#1012720: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic Nicolas Schier <nicolas@fjasle.eu> - 2023-12-22 13:00 +0100
Bug#1053000: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic Nilesh Patra <nilesh@debian.org> - 2023-12-23 07:50 +0100
| From | Nicolas Schier <nicolas@fjasle.eu> |
|---|---|
| Date | 2023-12-20 08:40 +0100 |
| Subject | Bug#1012720: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic |
| Message-ID | <HMZlo-eOjc-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi, I've packaged golang-github-google-gnostic-models, and I need a sponsor to get it uploaded. The package is a requirement for golang-k8s-apimachinery (cp. #1012720). Salsa: https://salsa.debian.org/go-team/packages/golang-github-google-gnostic-models.git Changelog: golang-github-google-gnostic-models (0.6.8-1) unstable; urgency=medium . * Initial release (Closes: #1053000) Mentors: https://mentors.debian.net/package/golang-github-google-gnostic-models/ dget -x https://mentors.debian.net/debian/pool/main/g/golang-github-google-gnostic-models/golang-github-google-gnostic-models_0.6.8-1.dsc The package builds with sbuild and passes lintian. Kind regards, Nicolas
[toc] | [next] | [standalone]
| From | Nilesh Patra <nilesh@debian.org> |
|---|---|
| Date | 2023-12-21 18:50 +0100 |
| Message-ID | <HNvlf-f8j3-3@gated-at.bofh.it> |
| In reply to | #1179435 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Dec 20, 2023 at 08:35:38AM +0100, Nicolas Schier wrote: > Hi, > > I've packaged golang-github-google-gnostic-models, and I need a sponsor > to get it uploaded. The package is a requirement for golang-k8s-apimachinery > (cp. #1012720). Few comments: * You do not need a separate hand-crafted .install files to install extra things you need. Please use DH_GOLANG_INSTALL_EXTRA in d/rules for that. * The d/copyright should probably mention "Google LLC" instead of "Google Inc." since that's what is mentioned in all the source code files. * Standards version can be updated to 4.6.2 * README.md as docs can be dropped. In principle no-one would install a lib package and read the README. The lib packages in golang are mainly needed for target consumable binary packages. LMK once you address them! Best, Nilesh
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Schier <nicolas@fjasle.eu> |
|---|---|
| Date | 2023-12-22 13:00 +0100 |
| Message-ID | <HNMm6-fiQq-5@gated-at.bofh.it> |
| In reply to | #1179669 |
[Multipart message — attachments visible in raw view] — view raw
Hi Nilesh,
On Thu, Dec 21, 2023 at 11:10:27PM +0530, Nilesh Patra wrote:
> On Wed, Dec 20, 2023 at 08:35:38AM +0100, Nicolas Schier wrote:
> > Hi,
> >
> > I've packaged golang-github-google-gnostic-models, and I need a sponsor
> > to get it uploaded. The package is a requirement for golang-k8s-apimachinery
> > (cp. #1012720).
>
> Few comments:
>
> * You do not need a separate hand-crafted .install files to install extra things you need.
> Please use DH_GOLANG_INSTALL_EXTRA in d/rules for that.
> * The d/copyright should probably mention "Google LLC" instead of "Google Inc." since that's
> what is mentioned in all the source code files.
> * Standards version can be updated to 4.6.2
> * README.md as docs can be dropped. In principle no-one would install a lib package and read the
> README. The lib packages in golang are mainly needed for target consumable binary packages.
>
> LMK once you address them!
thanks a lot for your review! I fixed all four points (and updated the
debian/watch version) so lintian is now completely satisfied.
The corresponding fixup commit is pushed to
https://salsa.debian.org/go-team/packages/golang-github-google-gnostic-models.git
and the prepared source package is uploaded to mentors:
dget -x https://mentors.debian.net/debian/pool/main/g/golang-github-google-gnostic-models/golang-github-google-gnostic-models_0.6.8-1.dsc
Kind regards,
Nicolas
(TIL: I should always push 'UNRELEASED' to the git repos as long as the
package is not completely reviewed and accepted.)
[toc] | [prev] | [next] | [standalone]
| From | Nilesh Patra <nilesh@debian.org> |
|---|---|
| Date | 2023-12-23 07:50 +0100 |
| Subject | Bug#1053000: RFS: golang-github-google-gnostic-models/0.6.8-1 [ITP] -- Protocol buffer models for gnostic |
| Message-ID | <HO3ZE-fxbK-3@gated-at.bofh.it> |
| In reply to | #1179763 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Dec 22, 2023 at 12:49:34PM +0100, Nicolas Schier wrote: > thanks a lot for your review! I fixed all four points (and updated the > debian/watch version) so lintian is now completely satisfied. > > The corresponding fixup commit is pushed to > > https://salsa.debian.org/go-team/packages/golang-github-google-gnostic-models.git Uploaded to NEW. Thanks for contributing! > (TIL: I should always push 'UNRELEASED' to the git repos as long as the > package is not completely reviewed and accepted.) Yep! Best, Nilesh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web