Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1178071 > unrolled thread

Bug#1057971: ITP: golang-github-lyft-protoc-gen-star -- protoc plugin library for efficient proto-based code generation

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1057971: ITP: golang-github-lyft-protoc-gen-star -- protoc plugin library for efficient proto-based code generation Maytham Alsudany <maytha8thedev@gmail.com> - 2023-12-11 05:30 +0100
    Bug#1057971: RFS: golang-github-lyft-protoc-gen-star Maytham Alsudany <maytha8thedev@gmail.com> - 2023-12-12 12:30 +0100
      Bug#1057970: RFS: protoc-gen-validate Maytham Alsudany <maytha8thedev@gmail.com> - 2023-12-17 08:10 +0100
        Bug#1057970: RFS: protoc-gen-validate Nilesh Patra <nilesh@debian.org> - 2023-12-21 18:20 +0100

#1178071 — Bug#1057971: ITP: golang-github-lyft-protoc-gen-star -- protoc plugin library for efficient proto-based code generation

[Multipart message — attachments visible in raw view] — view raw

Package: wnpp
Severity: wishlist
Owner: Maytham Alsudany <maytha8thedev@gmail.com>
X-Debbugs-CC: debian-devel@lists.debian.org, debian-go@lists.debian.org
Control: block 1057970 by -1

* Package name    : golang-github-lyft-protoc-gen-star
  Version         : 2.0.3-1
  Upstream Author : Lyft
* URL             : https://github.com/lyft/protoc-gen-star
* License         : Apache-2.0
  Programming Lang: Go
  Description     : protoc plugin library for efficient proto-based code       
generation

 PG* is a protoc plugin library for efficient proto-based code generation.
 .
 Documentation can be found at https://godoc.org/github.com/lyft/protoc-gen-star

This package is a dependency of golang-github-envoyproxy-protoc-gen-validate[1].

Will be maintained within Debian Go Packaging Team, and I'll need a sponsor.

[1]: https://bugs.debian.org/1057970

Kind regards,
Maytham

[toc] | [next] | [standalone]

#1178375 — Bug#1057971: RFS: golang-github-lyft-protoc-gen-star

[Multipart message — attachments visible in raw view] — view raw

Hi Go Team,

I've packaged golang-github-lyft-protoc-gen-star and need a sponsor to upload.

Salsa:
https://salsa.debian.org/go-team/packages/golang-github-lyft-protoc-gen-star

Builds successfully and passes autopkgtest, piuparts, and lintian (2 warnings
with lintian), both with and without the nocheck profile.

Kind regards,
Maytham

[toc] | [prev] | [next] | [standalone]

#1179023 — Bug#1057970: RFS: protoc-gen-validate

[Multipart message — attachments visible in raw view] — view raw

Hi Go team,

I'm looking for a sponsor to upload protoc-gen-validate.

Adding to the protoc-gen-star thread since these packages are related.

Salsa: https://salsa.debian.org/go-team/packages/protoc-gen-validate

Dependency tree:
golang-github-envoyproxy-protoc-gen-validate
└── golang-github-lyft-protoc-gen-star

Autopkgtest: fail (due to missing protoc-gen-star from Debian archive)
Lintian: warn (no-manual-page, spelling-error-in-binary)
Piuparts: pass

Changelog:

protoc-gen-validate (1.0.2-1) UNRELEASED; urgency=medium

  * Initial release (Closes: #1057970)
  * Disable broken tests that rely on Bazel

Disabled tests:

I've disabled the tests (harness target in Makefile) by adding an empty
override_dh_auto_test to d/r due to them being broken. Explanation below:

(After a few patches,) the Go protobuf files wouldn't build
as they result in the following error:

  panic: proto: file "embed.proto" is already registered
  	previously from: "github.com/envoyproxy/protoc-gen-validate/tests/harness/cases/other_package/go"
  	currently from:  "github.com/envoyproxy/protoc-gen-validate/tests/harness/cases/yet_another_package/go"
  See https://protobuf.dev/reference/go/faq#namespace-conflict

And the cc protobuf files won't build due to needing Bazel to do so. I've tried
to circumvent the need for Bazel and I got close, but I hit a roadblock where
ld can't find types from google::protobuf. I've tried adding libprotobuf-dev to
the B-D field but the problem kept occurring.

My attempts to fix these problems can be found in the fix-tests branch of my
fork of the Salsa repo[1] (didn't want to pollute the go-team repo with badly
written, rushed commits).

--

Feel free to ping me on IRC (as long as my username is there, I'm not online
all the time).

[1]: https://salsa.debian.org/Maytha8/protoc-gen-validate/-/tree/fix-tests

Thanks,
Maytham

[toc] | [prev] | [next] | [standalone]

#1179663 — Bug#1057970: RFS: protoc-gen-validate

[Multipart message — attachments visible in raw view] — view raw

On Sun, Dec 17, 2023 at 03:05:39PM +0800, Maytham Alsudany wrote:
> Hi Go team,
> 
> I'm looking for a sponsor to upload protoc-gen-validate.
> 
> Adding to the protoc-gen-star thread since these packages are related.
> 
> Salsa: https://salsa.debian.org/go-team/packages/protoc-gen-validate
> 
> Dependency tree:
> golang-github-envoyproxy-protoc-gen-validate
> └── golang-github-lyft-protoc-gen-star

I vaguely remember you/someone else mentioning on IRC that this is not needed.
Am I mistaken? LMK if so an I'll upload.

Also, are these needed for a target package?

Best,
Nilesh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web