Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1132627 > unrolled thread
| Started by | Vivek K J <vivekkj@disroot.org> |
|---|---|
| First post | 2023-01-10 14:30 +0100 |
| Last post | 2023-02-04 18:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.debian.bugs.dist
Bug#1028396: bullseye-pu: package ruby-aws-sdk-core/3.104.3 Vivek K J <vivekkj@disroot.org> - 2023-01-10 14:30 +0100
Bug#1028396: bullseye-pu: package ruby-aws-sdk-core/3.104.3 "Adam D. Barratt" <adam@adam-barratt.org.uk> - 2023-01-22 15:20 +0100
Bug#1028396: bullseye-pu: package ruby-aws-sdk-core/3.104.3 "Adam D. Barratt" <adam@adam-barratt.org.uk> - 2023-01-27 11:00 +0100
Bug#1028396: ruby-aws-sdk-core 3.104.3-3+deb11u1 flagged for acceptance Adam D Barratt <adam@adam-barratt.org.uk> - 2023-02-04 18:20 +0100
| From | Vivek K J <vivekkj@disroot.org> |
|---|---|
| Date | 2023-01-10 14:30 +0100 |
| Subject | Bug#1028396: bullseye-pu: package ruby-aws-sdk-core/3.104.3 |
| Message-ID | <FMmRr-gXbA-19@gated-at.bofh.it> |
Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: ruby-aws-sdk-core@packages.debian.org, vivekkj@disroot.org
Control: affects -1 + src:ruby-aws-sdk-core
[ Reason ]
Stable version of ruby-aws-sdk-core doesn't have version file. (See #1028285)
The solution was to drop fix-versions.patch which is not necessary with gem-install
layout.
[ Impact ]
This means that any integration trying to check the version of the core gem using a
debian installation cannot actually determine the version, or worse, will get whatever
version is in the ENV['VERSION'] which is likely completely unrelated to AWS.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
--- ruby-aws-sdk-core-3.104.3/debian/changelog 2023-01-09 19:47:37.000000000 +0530
+++ ruby-aws-sdk-core-3.104.3/debian/changelog 2020-08-20 17:53:33.000000000 +0530
@@ -1,10 +1,3 @@
-ruby-aws-sdk-core (3.104.3-4) bullseye; urgency=medium
-
- * Team upload.
- * drop fix-version.patch (Closes: #1028285)
-
- -- Vivek K J <vivekkj@disroot.org> Mon, 09 Jan 2023 19:47:37 +0530
-
ruby-aws-sdk-core (3.104.3-3) unstable; urgency=medium
* Team upload.
diff -Nru ruby-aws-sdk-core-3.104.3/debian/patches/fix-version.patch ruby-aws-sdk-core-3.104.3/debian/patches/fix-version.patch
--- ruby-aws-sdk-core-3.104.3/debian/patches/fix-version.patch 1970-01-01 05:30:00.000000000 +0530
+++ ruby-aws-sdk-core-3.104.3/debian/patches/fix-version.patch 2020-08-20 17:53:33.000000000 +0530
@@ -0,0 +1,15 @@
+Description: This patch fixes the VERSION for ruby-paperclip.
+Author: Utkarsh Gupta <guptautkarsh2102@gmail.com>
+Last-Update: 2019-09-10
+
+--- a/lib/aws-sdk-core.rb
++++ b/lib/aws-sdk-core.rb
+@@ -85,7 +85,7 @@
+
+ module Aws
+
+- CORE_GEM_VERSION = File.read(File.expand_path('../../VERSION', __FILE__)).strip
++ CORE_GEM_VERSION = ENV['VERSION']
+
+ @config = {}
+
diff -Nru ruby-aws-sdk-core-3.104.3/debian/patches/series ruby-aws-sdk-core-3.104.3/debian/patches/series
--- ruby-aws-sdk-core-3.104.3/debian/patches/series 2023-01-09 19:47:26.000000000 +0530
+++ ruby-aws-sdk-core-3.104.3/debian/patches/series 2020-08-20 17:53:33.000000000 +0530
@@ -0,0 +1 @@
+fix-version.patch
[toc] | [next] | [standalone]
| From | "Adam D. Barratt" <adam@adam-barratt.org.uk> |
|---|---|
| Date | 2023-01-22 15:20 +0100 |
| Message-ID | <FQJmp-mfa-5@gated-at.bofh.it> |
| In reply to | #1132627 |
Control: tags -1 + moreinfo On Tue, 2023-01-10 at 18:50 +0530, Vivek K J wrote: > Stable version of ruby-aws-sdk-core doesn't have version file. (See > #1028285) > The solution was to drop fix-versions.patch which is not necessary > with gem-install > layout. > It looks like the upload included binary packages as well as the source packages. While we'd prefer source-only uploads, they're not required. However, our tooling did spot a change in the binary package: Control files: lines which differ (wdiff format) ------------------------------------------------ [-Ruby-Versions: all-] Is that expected? Regards, Adam
[toc] | [prev] | [next] | [standalone]
| From | "Adam D. Barratt" <adam@adam-barratt.org.uk> |
|---|---|
| Date | 2023-01-27 11:00 +0100 |
| Message-ID | <FStGx-1tSv-5@gated-at.bofh.it> |
| In reply to | #1132627 |
On Fri, 2023-01-27 at 14:55 +0530, Vivek K J wrote: > It is not an expected change. The change came because, I built the > current stable version (i.e. 3.104.3-3) using an unstable chroot > (Mistakenly). On taking debdiff between this version and the current > stable version (which is built using a bullseye chroot), this diff > won't be there. (Attaching base binary package built using bullseye > chroot ) > > OK, I see. I've flagged the current upload for rejection. Once you get confirmation of that rejection, please perform a new - source-only - upload, so we can build the binary package on the buildds. Regards, Adam
[toc] | [prev] | [next] | [standalone]
| From | Adam D Barratt <adam@adam-barratt.org.uk> |
|---|---|
| Date | 2023-02-04 18:20 +0100 |
| Subject | Bug#1028396: ruby-aws-sdk-core 3.104.3-3+deb11u1 flagged for acceptance |
| Message-ID | <FVumJ-3qpG-13@gated-at.bofh.it> |
| In reply to | #1132627 |
package release.debian.org tags 1028396 = bullseye pending thanks Hi, The upload referenced by this bug report has been flagged for acceptance into the proposed-updates queue for Debian bullseye. Thanks for your contribution! Upload details ============== Package: ruby-aws-sdk-core Version: 3.104.3-3+deb11u1 Explanation: fix generation of version file
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web