Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1130618 > unrolled thread
| Started by | Scott Kitterman <debian@kitterman.com> |
|---|---|
| First post | 2022-12-29 06:50 +0100 |
| Last post | 2022-12-31 14:10 +0100 |
| Articles | 10 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available Scott Kitterman <debian@kitterman.com> - 2022-12-29 06:50 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available Sebastian Andrzej Siewior <sebastian@breakpoint.cc> - 2022-12-30 22:20 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available Scott Kitterman <debian@kitterman.com> - 2022-12-30 22:30 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available Scott Kitterman <debian@kitterman.com> - 2022-12-31 00:30 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available Sebastian Andrzej Siewior <sebastian@breakpoint.cc> - 2022-12-31 00:50 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available Scott Kitterman <debian@kitterman.com> - 2022-12-31 01:20 +0100
Bug#1006179: ClamAV 1.0.0 release candidate now available Scott Kitterman <debian@kitterman.com> - 2022-12-31 07:20 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: ClamAV 1.0.0 release candidate now available Sebastian Andrzej Siewior <sebastian@breakpoint.cc> - 2022-12-31 11:10 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: ClamAV 1.0.0 release candidate now available Scott Kitterman <debian@kitterman.com> - 2022-12-31 13:40 +0100
Bug#1006179: [Pkg-clamav-devel] Bug#1006179: ClamAV 1.0.0 release candidate now available Sebastian Andrzej Siewior <sebastian@breakpoint.cc> - 2022-12-31 14:10 +0100
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2022-12-29 06:50 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FHTXH-e262-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Friday, December 23, 2022 5:15:35 AM EST Sebastian Andrzej Siewior wrote: > On 2022-12-22 18:31:37 [-0500], Scott Kitterman wrote: > > I think we should focus on getting clamav up to 1.0.0 before the freeze > > and > > deal with the unrar bits later (should be easy enough to get a freeze > > exception for if we need it). > > > > If you think tha'ts reasonable, I'll manually make the tarball and update > > git (including the pristine-tar branch so we can work with the same > > tarball)? > Sure go ahead then. I will try to rearange the tfm bits in the meantime > and trigger a transition. Then we need to decide what we do about the > rust bits. I'm currently unsure if we can use the in-source bits or must > use packages. I've pushed additional d/copyright changes to the experimental branch. With those changes, uscan should produce a DFSG free tarball. Because I ripped out all the Windows specific stuff, the Rust crates don't compile. I don't know enough about building Rust crates yet to know why it's trying to build the optional windows dependencies. I brute forced my way out of it with the attached patch. With that patch and the d/rules and d/control changes I sent you earlier, that compiles. It FTBFS in install because that rules was missing a bunch of stuff, but I think this is enough to move forward with. I'll work on d/copyright changes to document the vendored crates. Let me know how else I can help. Scott K
[toc] | [next] | [standalone]
| From | Sebastian Andrzej Siewior <sebastian@breakpoint.cc> |
|---|---|
| Date | 2022-12-30 22:20 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIuXf-epxQ-15@gated-at.bofh.it> |
| In reply to | #1130618 |
On 2022-12-29 00:37:20 [-0500], Scott Kitterman wrote: > I've pushed additional d/copyright changes to the experimental branch. With > those changes, uscan should produce a DFSG free tarball. Because I ripped out > all the Windows specific stuff, the Rust crates don't compile. I don't know > enough about building Rust crates yet to know why it's trying to build the > optional windows dependencies. I brute forced my way out of it with the > attached patch. I need to check this in a buildd-env but on my sid-vm it works. So there are probably some deps missing. > With that patch and the d/rules and d/control changes I sent you earlier, that > compiles. It FTBFS in install because that rules was missing a bunch of stuff, > but I think this is enough to move forward with. > > I'll work on d/copyright changes to document the vendored crates. Let me know > how else I can help. I pushed some updates to the exp branch. I checkout your clamav-1.*tar.xz. Added a patch to use system's libtfm. This builds now when cmake is invoked manually and the testsuite passes. Tomorrow I will start fixing d/rules properly. Thank you for the d/copyright work. We will need to go through the new queue due to libclamav11. I will try to get something build-able tomorrow before the new year but I can't make a promisse. > Scott K Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2022-12-30 22:30 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIv6V-epBc-1@gated-at.bofh.it> |
| In reply to | #1130855 |
[Multipart message — attachments visible in raw view] — view raw
On Friday, December 30, 2022 4:09:38 PM EST Sebastian Andrzej Siewior wrote: > On 2022-12-29 00:37:20 [-0500], Scott Kitterman wrote: > > I've pushed additional d/copyright changes to the experimental branch. > > With those changes, uscan should produce a DFSG free tarball. Because I > > ripped out all the Windows specific stuff, the Rust crates don't compile. > > I don't know enough about building Rust crates yet to know why it's > > trying to build the optional windows dependencies. I brute forced my way > > out of it with the attached patch. > > I need to check this in a buildd-env but on my sid-vm it works. So there > are probably some deps missing. > > > With that patch and the d/rules and d/control changes I sent you earlier, > > that compiles. It FTBFS in install because that rules was missing a > > bunch of stuff, but I think this is enough to move forward with. > > > > I'll work on d/copyright changes to document the vendored crates. Let me > > know how else I can help. > > I pushed some updates to the exp branch. I checkout your > clamav-1.*tar.xz. Added a patch to use system's libtfm. This builds now > when cmake is invoked manually and the testsuite passes. Tomorrow I will > start fixing d/rules properly. > > Thank you for the d/copyright work. > We will need to go through the new queue due to libclamav11. I will try > to get something build-able tomorrow before the new year but I can't > make a promisse. Great. I finished the changes for the embedded crates (it's not perfect machine readable copyright format, but it's close and I think it will do for the moment) and pushed the change. It should be a fast forward for you when you pull it. I think the short d/rules file that I sent you earlier has the ~correct build options for us, so don't redo that if you don't have to. I'll be around this weekend, so if you upload it, I should be able to check it through New. I'll send an email to the release team warning them about our need for an upcoming transition slot. Anything else I can help with? Scott K
[toc] | [prev] | [next] | [standalone]
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2022-12-31 00:30 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIwZ3-eqS3-3@gated-at.bofh.it> |
| In reply to | #1130857 |
[Multipart message — attachments visible in raw view] — view raw
On Friday, December 30, 2022 4:22:21 PM EST Scott Kitterman wrote: ... > I'll be around this weekend, so if you upload it, I should be able to check > it through New. I'll send an email to the release team warning them about > our need for an upcoming transition slot. I did do this, but messed up cc'ing the pkg-clamav list: https://lists.debian.org/debian-release/2022/12/msg00631.html Scott K
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Andrzej Siewior <sebastian@breakpoint.cc> |
|---|---|
| Date | 2022-12-31 00:50 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIxip-eqYT-1@gated-at.bofh.it> |
| In reply to | #1130857 |
On 2022-12-30 16:22:21 [-0500], Scott Kitterman wrote: > Great. I finished the changes for the embedded crates (it's not perfect > machine readable copyright format, but it's close and I think it will do for > the moment) and pushed the change. It should be a fast forward for you when > you pull it. did it. > I think the short d/rules file that I sent you earlier has the ~correct build > options for us, so don't redo that if you don't have to. just updated it with your input. > I'll be around this weekend, so if you upload it, I should be able to check it > through New. I'll send an email to the release team warning them about our > need for an upcoming transition slot. > > Anything else I can help with? I got a few steps further instead going to bed. It complains now about missing testfiles because they are no longer shipped. So either we need to tweak it or we just drop that package. Other than that we would need to test or just throw it to exp asap and sort the pieces later. So I think we need to figure out if we keep `clamav-testfiles' and manually move the files or drop it (and maybe introduce it later again if people complain). > Scott K Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2022-12-31 01:20 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIxLr-eroB-1@gated-at.bofh.it> |
| In reply to | #1130876 |
On December 30, 2022 11:44:39 PM UTC, Sebastian Andrzej Siewior <sebastian@breakpoint.cc> wrote: >On 2022-12-30 16:22:21 [-0500], Scott Kitterman wrote: >> Great. I finished the changes for the embedded crates (it's not perfect >> machine readable copyright format, but it's close and I think it will do for >> the moment) and pushed the change. It should be a fast forward for you when >> you pull it. > >did it. > >> I think the short d/rules file that I sent you earlier has the ~correct build >> options for us, so don't redo that if you don't have to. > >just updated it with your input. > >> I'll be around this weekend, so if you upload it, I should be able to check it >> through New. I'll send an email to the release team warning them about our >> need for an upcoming transition slot. >> >> Anything else I can help with? > >I got a few steps further instead going to bed. It complains now about >missing testfiles because they are no longer shipped. So either we need >to tweak it or we just drop that package. >Other than that we would need to test or just throw it to exp asap and >sort the pieces later. So I think we need to figure out if we keep >`clamav-testfiles' and manually move the files or drop it (and maybe >introduce it later again if people complain). > >> Scott K > >Sebastian I think if there's a reasonable way to keep it, we should. In general though, I think uploading to experimental sooner rather than later is the right way to go, but if you drop the testfiles package now, it'll end up in New again when we put it back (people do use it, so I'm confident we'll get complaints if we drop it). Scott K Scott K
[toc] | [prev] | [next] | [standalone]
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2022-12-31 07:20 +0100 |
| Subject | Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIDnP-ewRc-1@gated-at.bofh.it> |
| In reply to | #1130877 |
[Multipart message — attachments visible in raw view] — view raw
On Friday, December 30, 2022 7:11:45 PM EST Scott Kitterman wrote: > On December 30, 2022 11:44:39 PM UTC, Sebastian Andrzej Siewior <sebastian@breakpoint.cc> wrote: > >On 2022-12-30 16:22:21 [-0500], Scott Kitterman wrote: > >> Great. I finished the changes for the embedded crates (it's not perfect > >> machine readable copyright format, but it's close and I think it will do > >> for the moment) and pushed the change. It should be a fast forward for > >> you when you pull it. > > > >did it. > > > >> I think the short d/rules file that I sent you earlier has the ~correct > >> build options for us, so don't redo that if you don't have to. > > > >just updated it with your input. > > > >> I'll be around this weekend, so if you upload it, I should be able to > >> check it through New. I'll send an email to the release team warning > >> them about our need for an upcoming transition slot. > >> > >> Anything else I can help with? > > > >I got a few steps further instead going to bed. It complains now about > >missing testfiles because they are no longer shipped. So either we need > >to tweak it or we just drop that package. > >Other than that we would need to test or just throw it to exp asap and > >sort the pieces later. So I think we need to figure out if we keep > >`clamav-testfiles' and manually move the files or drop it (and maybe > >introduce it later again if people complain). > > > >> Scott K > > > >Sebastian > > I think if there's a reasonable way to keep it, we should. In general > though, I think uploading to experimental sooner rather than later is the > right way to go, but if you drop the testfiles package now, it'll end up in > New again when we put it back (people do use it, so I'm confident we'll get > complaints if we drop it). I looked at it some and the testfiles appear to be gone. Let's drop the binary and move on. I discovered that the experimental (and upstream-experimental) branches still have the crates that are now excluded when the tarball is created. I made a new branch called upstream-experimental-fixup and pushed it. You ought to be able to merge that to upstream-experimental and then merge that to experimental and get an unpacked directory that dpkg-buildpackage things goes with the tarball. We (I volunteer) will also need to fixup the pristine-tar branch, but that can be later. I pushed some changes to the experimental branch to help it build using dpkg- buildpackage: - added build-depends - added my rust compilation requirements patch that I had emailed you (it's not applied, just in d/patches and listed in d/patches/series) - added the target directory for the unit files in configure in d/rules With those changes, it gets through to install, where it failes for multiple reasons: 1. There's a typo in the libclamav11.install file (fixed in git). 2. Missing testfiles (I say nuke the binary and move on, but I didn't do it). 3. Missing html docs. This just needs the proper doxygen invocation (but it's late and I'm tired here, so I didn't make and changes for this). I did manually build the docs and once those were present it got all the way to symbols files. Back over to you. I'm going to bed. Good luck. Scott K
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Andrzej Siewior <sebastian@breakpoint.cc> |
|---|---|
| Date | 2022-12-31 11:10 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIGYp-ezn9-1@gated-at.bofh.it> |
| In reply to | #1130898 |
On 2022-12-31 01:09:46 [-0500], Scott Kitterman wrote: > I discovered that the experimental (and upstream-experimental) branches still > have the crates that are now excluded when the tarball is created. I made a > new branch called upstream-experimental-fixup and pushed it. You ought to be > able to merge that to upstream-experimental and then merge that to > experimental and get an unpacked directory that dpkg-buildpackage things goes > with the tarball. We (I volunteer) will also need to fixup the pristine-tar > branch, but that can be later. I recreated these things while recreating the tar file. I parse the remaining parts of the email while moving forward. This just a diff between the new upstream-exp branch and your's: | $ git diff salsa/upstream-experimental-fixup -w --stat | .gitattributes | 16 +++++++++ | .github/ISSUE_TEMPLATE/bug_report.md | 41 ++++++++++++++++++++++ | .github/ISSUE_TEMPLATE/config.yml | 5 +++ | .github/workflows/clang-format.yml | 65 ++++++++++++++++++++++++++++++++++ | .github/workflows/cmake.yml | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ | .github/workflows/codeql.yml | 86 +++++++++++++++++++++++++++++++++++++++++++++ | .github/workflows/docker-db-update.yml | 17 +++++++++ | .gitignore | 236 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ | libclamav_rust/.cargo/vendor/libloading/tests/nagisa32.dll | Bin 3072 -> 0 bytes | libclamav_rust/.cargo/vendor/libloading/tests/nagisa64.dll | Bin 2560 -> 0 bytes | 10 files changed, 651 insertions(+) The additional .git* files should be okay and the copyright file dropped two dlls. Good. I don't know *why* but the cargo files have a larger CR/LF vs LF so that is why the `-w' option is there. Other than that, I need to teach mk-origtargz to compress xz with -T (multiple blocks) now that xz-utils supports threaded decompression. dpkg-deb (during installation) can handle it already and the dpkg-source bits are on its way ;) Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Scott Kitterman <debian@kitterman.com> |
|---|---|
| Date | 2022-12-31 13:40 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIJjz-eAIV-1@gated-at.bofh.it> |
| In reply to | #1130914 |
On December 31, 2022 10:00:13 AM UTC, Sebastian Andrzej Siewior <sebastian@breakpoint.cc> wrote: >On 2022-12-31 01:09:46 [-0500], Scott Kitterman wrote: >> I discovered that the experimental (and upstream-experimental) branches still >> have the crates that are now excluded when the tarball is created. I made a >> new branch called upstream-experimental-fixup and pushed it. You ought to be >> able to merge that to upstream-experimental and then merge that to >> experimental and get an unpacked directory that dpkg-buildpackage things goes >> with the tarball. We (I volunteer) will also need to fixup the pristine-tar >> branch, but that can be later. > >I recreated these things while recreating the tar file. I parse the >remaining parts of the email while moving forward. This just a diff >between the new upstream-exp branch and your's: > >| $ git diff salsa/upstream-experimental-fixup -w --stat >| .gitattributes | 16 +++++++++ >| .github/ISSUE_TEMPLATE/bug_report.md | 41 ++++++++++++++++++++++ >| .github/ISSUE_TEMPLATE/config.yml | 5 +++ >| .github/workflows/clang-format.yml | 65 ++++++++++++++++++++++++++++++++++ >| .github/workflows/cmake.yml | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >| .github/workflows/codeql.yml | 86 +++++++++++++++++++++++++++++++++++++++++++++ >| .github/workflows/docker-db-update.yml | 17 +++++++++ >| .gitignore | 236 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >| libclamav_rust/.cargo/vendor/libloading/tests/nagisa32.dll | Bin 3072 -> 0 bytes >| libclamav_rust/.cargo/vendor/libloading/tests/nagisa64.dll | Bin 2560 -> 0 bytes >| 10 files changed, 651 insertions(+) > >The additional .git* files should be okay and the copyright file dropped >two dlls. Good. I don't know *why* but the cargo files have a larger >CR/LF vs LF so that is why the `-w' option is there. > >Other than that, I need to teach mk-origtargz to compress xz with -T >(multiple blocks) now that xz-utils supports threaded decompression. >dpkg-deb (during installation) can handle it already and the dpkg-source >bits are on its way ;) > >Sebastian Great. I'm looking at this on my phone, so the diff is hard to parse. I may have made a mistake somewhere. libclamav_rust/.cargo/vendor/libloading/tests/nagisa* have prebuilt Windows artifacts in them and need to not be in the tarball. Scott K
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Andrzej Siewior <sebastian@breakpoint.cc> |
|---|---|
| Date | 2022-12-31 14:10 +0100 |
| Subject | Bug#1006179: [Pkg-clamav-devel] Bug#1006179: ClamAV 1.0.0 release candidate now available |
| Message-ID | <FIJMB-eB8R-9@gated-at.bofh.it> |
| In reply to | #1130898 |
On 2022-12-31 01:09:46 [-0500], Scott Kitterman wrote: > I looked at it some and the testfiles appear to be gone. Let's drop the binary > and move on. I references them from the build-directory. So we have some of them. I don't know if new files are there (in the build directory) but the .rar files are gone for now. > I pushed some changes to the experimental branch to help it build using dpkg- > buildpackage: > > - added build-depends > - added my rust compilation requirements patch that I had emailed you (it's > not applied, just in d/patches and listed in d/patches/series) > - added the target directory for the unit files in configure in d/rules > > With those changes, it gets through to install, where it failes for multiple > reasons: > > 1. There's a typo in the libclamav11.install file (fixed in git). > 2. Missing testfiles (I say nuke the binary and move on, but I didn't do it). > 3. Missing html docs. This just needs the proper doxygen invocation (but > it's late and I'm tired here, so I didn't make and changes for this). I did > manually build the docs and once those were present it got all the way to > symbols files. The symbol files are a huge mess now due to the c++/rust symbols that we got now. I guess that those should be not exported as part of the lib. The docs are missing. The manual invocation brings something but it is not the "documentation" but the clamav.h annotation. Which is not helpfull I guess… > Back over to you. I'm going to bed. Good luck. I uploaded it to experimental. Need to shower, vacuum clean, have ppl over later… > Scott K Sebastian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web