Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1111324 > unrolled thread

Bug#1011284: popularity-contest: d/postinst: remove bash dependency, fix shellcheck

Started byBill Allombert <ballombe@debian.org>
First post2022-07-29 15:30 +0200
Last post2022-08-01 13:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.debian.bugs.dist

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Bug#1011284: popularity-contest: d/postinst: remove bash dependency, fix shellcheck Bill Allombert <ballombe@debian.org> - 2022-07-29 15:30 +0200
    Bug#1011284: popularity-contest: d/postinst: remove bash dependency, fix shellcheck наб <nabijaczleweli@nabijaczleweli.xyz> - 2022-07-29 20:10 +0200
      Bug#1011284: popularity-contest: d/postinst: remove bash dependency, fix shellcheck наб <nabijaczleweli@nabijaczleweli.xyz> - 2022-08-01 13:50 +0200

#1111324 — Bug#1011284: popularity-contest: d/postinst: remove bash dependency, fix shellcheck

FromBill Allombert <ballombe@debian.org>
Date2022-07-29 15:30 +0200
SubjectBug#1011284: popularity-contest: d/postinst: remove bash dependency, fix shellcheck
Message-ID<EOydX-eCms-7@gated-at.bofh.it>
On Thu, May 19, 2022 at 05:05:43PM +0200, наб wrote:
> Source: popularity-contest
> Version: 1.74
> Severity: wishlist
> Tags: patch
> 
> Dear Maintainer,
> 
> d/postinst hard-depends on bash to generate random days/hours/minutes;
> however,
>   od -d -An -N2 /dev/urandom
> is equivalent to
>   bash -c 'echo $RANDOM'
> ‒ patch 1 replaces the latter with the former;
> od is part of coreutils, and -d is a legacy switch so it's available on
> all implementations (and we already use it as a fallback for hostid
> generation).

Hello нaб,

There should be a provision to work on systems when /dev/urandom is not 
available, as there is for MY_HOSTID.

Cheers,
-- 
Bill. <ballombe@debian.org>

Imagine a large red swirl here. 

[toc] | [next] | [standalone]


#1111385

Fromнаб <nabijaczleweli@nabijaczleweli.xyz>
Date2022-07-29 20:10 +0200
Message-ID<EOCAV-eF1P-9@gated-at.bofh.it>
In reply to#1111324

[Multipart message — attachments visible in raw view] — view raw

Hi!

On Fri, Jul 29, 2022 at 03:25:12PM +0200, Bill Allombert wrote:
> There should be a provision to work on systems when /dev/urandom is not 
> available, as there is for MY_HOSTID.
It seemed like /dev/urandom was the universal fallback,
so I didn't write a fallback originally.

Attaching updated patchset, which tries:
  * /dev/urandom
  * uuidgen                      (as a hexadecimal number)
  * /proc/sys/kernel/random/uuid (likewise)
  * a constant

basenc is part of coreutils since 8.31 (bullseye),
so this should work on every system.

Best,
наб

[toc] | [prev] | [next] | [standalone]


#1111657

Fromнаб <nabijaczleweli@nabijaczleweli.xyz>
Date2022-08-01 13:50 +0200
Message-ID<EPC5P-fft5-3@gated-at.bofh.it>
In reply to#1111385

[Multipart message — attachments visible in raw view] — view raw

Hi!

Sorry, I had a brain-fart last time. Instead of trying to do something
weird, we can just use The Program That Generates Random Numbers:
shuf appeared in coreutils 6.1 (2006-08-19) and is available under busybox.

Attached is a much simpler patchset that does the same thing but just
uses shuf -n1 -r0-$top_of_mod_range.

Best,
наб

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web