Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1090413 > unrolled thread

Bug#1004178: creates and pushes tag for unreleased package

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1004178: creates and pushes tag for unreleased package Marc Haber <mh+debian-packages@zugschlus.de> - 2022-01-22 10:50 +0100
    Bug#1004178: creates and pushes tag for unreleased package Guido Günther <agx@sigxcpu.org> - 2022-01-22 14:10 +0100
      Bug#1004178: creates and pushes tag for unreleased package Marc Haber <mh+debian-bugs@zugschlus.de> - 2022-01-22 14:20 +0100
        Bug#1004178: creates and pushes tag for unreleased package Guido Günther <agx@sigxcpu.org> - 2022-01-22 14:40 +0100
          Bug#1004178: creates and pushes tag for unreleased package Marc Haber <mh+debian-bugs@zugschlus.de> - 2022-01-22 15:20 +0100

#1090413 — Bug#1004178: creates and pushes tag for unreleased package

Package: git-buildpackage
Version: 0.9.25
Severity: normal

Hi,

I am currently adapting myself to using gbp push to push things. The
docs say:

       • Determine the debian tag from debian/changelog and add it the  list
         of  things to push if the changelog does not indicate an unreleased
         package.

My changelog says:

aide (0.17.4-2~0) UNRELEASED; urgency=medium

  * NOT YET RELEASED

 -- Marc Haber <mh+debian-packages@zugschlus.de>  Thu, 20 Jan 2022 18:16:46 +>

How much more unreleased can a package be?

However, gbp push still creates and pushes a debian/0.17.4-2_0 tag:

2 [3/4995]mh@salida:~/packages/aide/aide (master u+1) $ gbp push --verbose
gbp:debug: ['git', 'rev-parse', '--show-cdup']
gbp:debug: ['git', 'rev-parse', '--is-bare-repository']
gbp:debug: ['git', 'rev-parse', '--git-dir']
gbp:debug: ['git', 'symbolic-ref', 'HEAD']
gbp:debug: ['git', 'show-ref', 'refs/heads/master']
gbp:debug: ['git', 'config', 'branch.master.remote']
gbp:debug: ['git', 'config', 'branch.master.merge']
gbp:debug: ['git', 'tag', '-l', 'debian/0.17.4-2_0']
gbp:debug: ['git', 'tag', '-l', 'upstream/0.17.4']
gbp:debug: ['git', 'rev-parse', '--quiet', '--verify', 'upstream/0.17.4^{commit}']
gbp:debug: ['git', 'rev-parse', '--quiet', '--verify', 'refs/heads/upstream']
gbp:info: Pushing debian/0.17.4-2_0 to origin
gbp:debug: ['git', 'push', 'origin', 'tag', 'debian/0.17.4-2_0']
gbp:info: Pushing upstream/0.17.4 to origin
gbp:debug: ['git', 'push', 'origin', 'tag', 'upstream/0.17.4']
gbp:info: Pushing refs/heads/upstream to origin:refs/heads/upstream
gbp:debug: ['git', 'push', 'origin', 'refs/heads/upstream:refs/heads/upstream']
[4/4996]mh@salida:~/packages/aide/aide (master u+1) $

Greetings
Marc


-- System Information:
Debian Release: bookworm/sid
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.16.1-zgsrv20080 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages git-buildpackage depends on:
ii  devscripts             2.21.7
ii  git                    1:2.34.1-1
ii  man-db                 2.9.4-4
ii  python3                3.9.8-1
ii  python3-dateutil       2.8.1-6
ii  python3-pkg-resources  59.6.0-1.2
ii  sensible-utils         0.0.17

Versions of packages git-buildpackage recommends:
pn  cowbuilder | pbuilder | sbuild  <none>
ii  pristine-tar                    1.49
ii  python3-requests                2.25.1+dfsg-2

Versions of packages git-buildpackage suggests:
pn  python3-notify2  <none>
ii  sudo             1.9.8p2-1
ii  unzip            6.0-26

-- no debconf information

[toc] | [next] | [standalone]

#1090434

Hi,

you say

> Subject: Re: Bug#1004178: creates and pushes tag for unreleased
> package

gbp-push does not _create_ any tags by itself so the tag must have
been there already (see log below).

On Sat, Jan 22, 2022 at 10:42:54AM +0100, Marc Haber wrote:
> Package: git-buildpackage
> Version: 0.9.25
> Severity: normal
> 
> Hi,
> 
> I am currently adapting myself to using gbp push to push things. The
> docs say:
> 
>        • Determine the debian tag from debian/changelog and add it the  list
>          of  things to push if the changelog does not indicate an unreleased
>          package.
>


> My changelog says:
> 
> aide (0.17.4-2~0) UNRELEASED; urgency=medium

gbp-push checks for `UNRELEASED` in the changelog. You want to check why
this doesn't happen for your package (see the `is_released()` call in
`gbp/scripts/push.py`.


> 
>   * NOT YET RELEASED
> 
>  -- Marc Haber <mh+debian-packages@zugschlus.de>  Thu, 20 Jan 2022 18:16:46 +>
> 
> How much more unreleased can a package be?
> 
> However, gbp push still creates and pushes a debian/0.17.4-2_0 tag:
> 
> 2 [3/4995]mh@salida:~/packages/aide/aide (master u+1) $ gbp push --verbose
> gbp:debug: ['git', 'rev-parse', '--show-cdup']
> gbp:debug: ['git', 'rev-parse', '--is-bare-repository']
> gbp:debug: ['git', 'rev-parse', '--git-dir']
> gbp:debug: ['git', 'symbolic-ref', 'HEAD']
> gbp:debug: ['git', 'show-ref', 'refs/heads/master']
> gbp:debug: ['git', 'config', 'branch.master.remote']
> gbp:debug: ['git', 'config', 'branch.master.merge']
> gbp:debug: ['git', 'tag', '-l', 'debian/0.17.4-2_0']

Here it checkes for the tag and finds it…

> gbp:debug: ['git', 'tag', '-l', 'upstream/0.17.4']
> gbp:debug: ['git', 'rev-parse', '--quiet', '--verify', 'upstream/0.17.4^{commit}']
> gbp:debug: ['git', 'rev-parse', '--quiet', '--verify', 'refs/heads/upstream']
> gbp:info: Pushing debian/0.17.4-2_0 to origin

…here it pushes it out since it does think the package is released.

Cheers,
 -- Guido

> gbp:debug: ['git', 'push', 'origin', 'tag', 'debian/0.17.4-2_0']
> gbp:info: Pushing upstream/0.17.4 to origin
> gbp:debug: ['git', 'push', 'origin', 'tag', 'upstream/0.17.4']
> gbp:info: Pushing refs/heads/upstream to origin:refs/heads/upstream
> gbp:debug: ['git', 'push', 'origin', 'refs/heads/upstream:refs/heads/upstream']
> [4/4996]mh@salida:~/packages/aide/aide (master u+1) $
> 
> Greetings
> Marc
> 
> 
> -- System Information:
> Debian Release: bookworm/sid
>   APT prefers stable-security
>   APT policy: (500, 'stable-security'), (500, 'unstable'), (500, 'testing'), (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 5.16.1-zgsrv20080 (SMP w/4 CPU threads; PREEMPT)
> Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=en
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages git-buildpackage depends on:
> ii  devscripts             2.21.7
> ii  git                    1:2.34.1-1
> ii  man-db                 2.9.4-4
> ii  python3                3.9.8-1
> ii  python3-dateutil       2.8.1-6
> ii  python3-pkg-resources  59.6.0-1.2
> ii  sensible-utils         0.0.17
> 
> Versions of packages git-buildpackage recommends:
> pn  cowbuilder | pbuilder | sbuild  <none>
> ii  pristine-tar                    1.49
> ii  python3-requests                2.25.1+dfsg-2
> 
> Versions of packages git-buildpackage suggests:
> pn  python3-notify2  <none>
> ii  sudo             1.9.8p2-1
> ii  unzip            6.0-26
> 
> -- no debconf information

[toc] | [prev] | [next] | [standalone]

#1090436

Hi Guido,

you're lightning fast answering as usual. I appreciate that.

On Sat, Jan 22, 2022 at 02:04:46PM +0100, Guido Günther wrote:
> you say
> 
> > Subject: Re: Bug#1004178: creates and pushes tag for unreleased
> > package
> 
> gbp-push does not _create_ any tags by itself so the tag must have
> been there already (see log below).

The log was created after the tag was already there. But my shell
history proves that I didnt create the tag myself.

> > aide (0.17.4-2~0) UNRELEASED; urgency=medium
> 
> gbp-push checks for `UNRELEASED` in the changelog. You want to check why
> this doesn't happen for your package (see the `is_released()` call in
> `gbp/scripts/push.py`.

I have grepped through all files delivered by git-buildpackage 0.9.25.
The string is_released is in none of them. Are you talking about
is_releaseable? The code that fills changelog.distribution seems to be
in gbp/deb/changelog.py, which seems to use dpkg-parsechangelog -l's
output. dpkg-parsechangelog -l returns "Distribution: UNRELEASED" so it
looks like the external tool is working.

Sorry, this is beyond my little python skills for the time being. How
would I debug this best without actually pushing tags to salsa?

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421

[toc] | [prev] | [next] | [standalone]

#1090440

Hi,
On Sat, Jan 22, 2022 at 02:15:12PM +0100, Marc Haber wrote:
> Hi Guido,
> 
> you're lightning fast answering as usual. I appreciate that.
> 
> On Sat, Jan 22, 2022 at 02:04:46PM +0100, Guido Günther wrote:
> > you say
> > 
> > > Subject: Re: Bug#1004178: creates and pushes tag for unreleased
> > > package
> > 
> > gbp-push does not _create_ any tags by itself so the tag must have
> > been there already (see log below).
> 
> The log was created after the tag was already there. But my shell
> history proves that I didnt create the tag myself.

…but it wasn't created by gbp-push so this part of the report seems odd.

> 
> > > aide (0.17.4-2~0) UNRELEASED; urgency=medium
> > 
> > gbp-push checks for `UNRELEASED` in the changelog. You want to check why
> > this doesn't happen for your package (see the `is_released()` call in
> > `gbp/scripts/push.py`.
> 
> I have grepped through all files delivered by git-buildpackage 0.9.25.
> The string is_released is in none of them. Are you talking about
> is_releaseable? The code that fills changelog.distribution seems to be
> in gbp/deb/changelog.py, which seems to use dpkg-parsechangelog -l's
> output. dpkg-parsechangelog -l returns "Distribution: UNRELEASED" so it
> looks like the external tool is working.
> 
> Sorry, this is beyond my little python skills for the time being. How
> would I debug this best without actually pushing tags to salsa?

see `--dry-run` in `man gbp-push`. Alternative: Use another remote
(which can even be local).

Cheers,
 -- Guido

> 
> Greetings
> Marc
> 
> -- 
> -----------------------------------------------------------------------------
> Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
> Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
> Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421
> 

[toc] | [prev] | [next] | [standalone]

#1090443

On Sat, Jan 22, 2022 at 02:35:35PM +0100, Guido Günther wrote:
> On Sat, Jan 22, 2022 at 02:15:12PM +0100, Marc Haber wrote:
> > you're lightning fast answering as usual. I appreciate that.
> > 
> > On Sat, Jan 22, 2022 at 02:04:46PM +0100, Guido Günther wrote:
> > > you say
> > > 
> > > > Subject: Re: Bug#1004178: creates and pushes tag for unreleased
> > > > package
> > > 
> > > gbp-push does not _create_ any tags by itself so the tag must have
> > > been there already (see log below).
> > 
> > The log was created after the tag was already there. But my shell
> > history proves that I didnt create the tag myself.
> 
> …but it wasn't created by gbp-push so this part of the report seems odd.

I think we can agree on it not having been created by the call to gbp
push that generated the log.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web