Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1029738 > unrolled thread

Bug#972787: picard: Aborts if directory scan finds a directory which cannot be read

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#972787: picard: Aborts if directory scan finds a directory which cannot be read Ian Campbell <ijc@debian.org> - 2020-10-23 17:30 +0200
    Bug#972787: picard: Aborts if directory scan finds a directory which cannot be read Sebastian Ramacher <sramacher@debian.org> - 2020-10-23 17:50 +0200
    Bug#972787: picard: Aborts if directory scan finds a directory which cannot be read Ian Campbell <ijc@debian.org> - 2020-10-23 18:30 +0200

#1029738 — Bug#972787: picard: Aborts if directory scan finds a directory which cannot be read

Package: picard
Version: 2.4.4-1
Severity: important

Dear Maintainer,

Picard is aborting when it comes across the lost+found directory in my music
mountpoint:

    $ picard /storage/music/
    I: 15:52:59,827 /usr/lib/picard/picard/config._backup_settings:274: Backing up config file to /home/ijc/.config/MusicBrainz/Picard-2.4.1.ini
    Traceback (most recent call last):
      File "/usr/lib/picard/picard/tagger.py", line 391, in _run_init
        self.add_directory(decode_filename(file))
      File "/usr/lib/picard/picard/tagger.py", line 574, in add_directory
        files = self._scan_dir([path],
      File "/usr/lib/picard/picard/tagger.py", line 542, in _scan_dir
        for entry in os.scandir(current_folder):
    PermissionError: [Errno 13] Permission denied: '/storage/music/lost+found'
    Aborted
    $ ls -ld /storage/music/lost+found/
    drwx------ 2 root root 16384 Jun 25  2011 /storage/music/lost+found//

Thanks,
Ian.

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf, armel, arm64

Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages picard depends on:
ii  libc6                 2.31-3
ii  libchromaprint-tools  1.5.0-1
ii  python3               3.8.2-3
ii  python3-dateutil      2.8.1-4
ii  python3-libdiscid     1.1-1+b2
ii  python3-mutagen       1.45.0-2
ii  python3-pyqt5         5.15.1+dfsg-2+b1

Versions of packages picard recommends:
ii  libqt5multimedia5-plugins   5.14.2-2
ii  python3-pyqt5.qtmultimedia  5.15.1+dfsg-2+b1

Versions of packages picard suggests:
ii  hicolor-icon-theme  0.17-2

-- no debconf information

[toc] | [next] | [standalone]

#1029741

[Multipart message — attachments visible in raw view] — view raw

Control: forwarded -1 https://tickets.metabrainz.org/browse/PICARD-1988
Control: tags -1 upstream

On 2020-10-23 15:58:22 +0100, Ian Campbell wrote:
> Package: picard
> Version: 2.4.4-1
> Severity: important
> 
> Dear Maintainer,
> 
> Picard is aborting when it comes across the lost+found directory in my music
> mountpoint:
> 
>     $ picard /storage/music/
>     I: 15:52:59,827 /usr/lib/picard/picard/config._backup_settings:274: Backing up config file to /home/ijc/.config/MusicBrainz/Picard-2.4.1.ini
>     Traceback (most recent call last):
>       File "/usr/lib/picard/picard/tagger.py", line 391, in _run_init
>         self.add_directory(decode_filename(file))
>       File "/usr/lib/picard/picard/tagger.py", line 574, in add_directory
>         files = self._scan_dir([path],
>       File "/usr/lib/picard/picard/tagger.py", line 542, in _scan_dir
>         for entry in os.scandir(current_folder):
>     PermissionError: [Errno 13] Permission denied: '/storage/music/lost+found'
>     Aborted
>     $ ls -ld /storage/music/lost+found/
>     drwx------ 2 root root 16384 Jun 25  2011 /storage/music/lost+found//

Thanks, forwarded upstream

Cheers
-- 
Sebastian Ramacher

[toc] | [prev] | [next] | [standalone]

#1029746

Control: found -1 2.4.1-1

Hi (again),

I was able to fix the issue by monkey patching in an "except
PermissionError: pass" around line 549
of /usr/lib/picard/picard/tagger.py, in the existing try block around
the os.scandir.

FWIW this issue was already present in 2.4.1-1 but I upgraded to latest
and reconfirmed the issue still existing before reporting.

Thanks,
Ian.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web