Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1026727 > unrolled thread

Bug#960831: about RFS: yiyantang

Back to article view | Back to linux.debian.bugs.dist

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#960831: about RFS: yiyantang Paul Wise <pabs@debian.org> - 2020-09-28 03:40 +0200
    Bug#960831: about RFS: yiyantang Tobias Frost <tobi@debian.org> - 2020-09-29 16:50 +0200
      Bug#960831: about RFS: yiyantang Tobias Frost <tobi@debian.org> - 2020-09-30 16:40 +0200
        Bug#960831: about RFS: yiyantang xiao sheng wen (肖盛文) <atzlinux@sina.com> - 2020-10-22 11:50 +0200

#1026727 — Bug#960831: about RFS: yiyantang

On Sun, Sep 27, 2020 at 3:18 PM Tobias Frost wrote:

> If upstream is gone and won't come back you can delete the watch file.

I suggest instead to keep the watch file, but add a comment mentioning
the upstream situation.

> Did you look if there are any forks that could be new upstream?

It can also be a good idea to create a new upstream project or take
over the existing one if it is still there but not active.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

[toc] | [next] | [standalone]

#1026937

On Tue, Sep 29, 2020 at 10:04:16AM +0800, xiao sheng wen (肖盛文) wrote:
> Hi, Paul,Tobias,
> 
>     Thanks for your review.
> 
> I had uploaded the new package, please help to review again.
> 
> About the upstream:
> 
> I can't find any forks that could be new upstream on Internet.

So, congrats for becoming de-facto* upstream then… ;-)

(* due to maintaining a dead-upstream package)

> About the "not using autoreconf":
> 
> If use autoreconf, the build will failed:
> 
> automake: warning: autoconf input should be named 'configure.ac', not
> 'configure.in'
> autoreconf: automake failed with exit status: 1
> dh_autoreconf: error: autoreconf -f -i returned exit code 1

Yes, I see*. But I fear that needs to be debugged and eventually
be fixed or it will fly right into your face, at some point of time**…

At the very least, config.guess and config.sub needs updating
frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz)

> The source code is old, it use configure.in.
 
(* The reason for the failure seems to be in configure.in:59; but I did not try
anything except commenting out that line; autoreconf suceeds then but configure
fails later.)

(**I'm not saying you need to fix that right away; maybe you are lucky and it
never explodes…)

fix-typo-patch -> Please s/type/typo also in the dep3 headers. [nitpick]

d/copyright:
- You need to have the complete GPL boiler plate in the License text.
Note, if you license debian/* GPL-2*+* you need to have an extra
section for the different license. (GPL-2 != GPL-2+)
- Please also mention the previous maintainers in the debian/* section.

d/rules [nitpick]
- Please wrap the long lines.

Please fix d/copyright and possibly also the nitpicks and I will take
a look again.

-- 
tobi

[toc] | [prev] | [next] | [standalone]

#1027093

Control: moreinfo -1

On Wed, Sep 30, 2020 at 08:29:29PM +0800, xiao sheng wen wrote:
>  Hi, Tobias,
> 
>   Thanks for your review.
> 
>   I had uploaded the new package, please help to review again.
> 
> 在 2020/9/29 下午10:44, Tobias Frost 写道:
> > So, congrats for becoming de-facto* upstream then… ;-)
> >
> > (* due to maintaining a dead-upstream package)
> 
> I'm planning to find the appropriate person to become the new upstream
> in the Chinese open source community.
> 
> But this finding need time, perhaps we have lucky.
> 
> > Yes, I see*. But I fear that needs to be debugged and eventually
> > be fixed or it will fly right into your face, at some point of time**…
> >
> > At the very least, config.guess and config.sub needs updating
> > frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz)
> Read it.
> > (* The reason for the failure seems to be in configure.in:59; but I did not try
> > anything except commenting out that line; autoreconf suceeds then but configure
> > fails later.)
> 
> It's not a easy thing for me that change the code to use autoreconf and
> let the rebuild package success .
> 
> I'm not a programmer. :-(

Ehm, well
*some* programming skill ought to be useful when maintaining packages.
Well, ok, you'll learn the skills, I'm sure.

> > d/copyright:
> > - You need to have the complete GPL boiler plate in the License text.

This is still missing.
Also, this is not a license text for GPL-2
 This package was debianized by Yu Guanghui <ygh@debian.org> on
 Tue,  1 May 2001 22:23:01 +0800.

> > Note, if you license debian/* GPL-2*+* you need to have an extra
> > section for the different license. (GPL-2 != GPL-2+)
> used GPL-2 in this upload.

Well, d/copyright is inconsistent with the source code. Please recheck
and update it. For example:
- Upstream code is GPL-2+, at least setty.c
- Other files have same license, but different copyright holders.
- Please ensure to quote the complete license boiler plate,
  (all 3 paragraphs; if necessary, change the FSF address. "*" can
   be stripped.)

> > - Please also mention the previous maintainers in the debian/* section.
> I find the previous maintainers info from git log and added to the
> d/copyright file.

--
tobi

[toc] | [prev] | [next] | [standalone]

#1029569

hi,Tobias,

     I had uploaded  the new yiyantang package again today.

Would you have time to review?


https://mentors.debian.net/package/yiyantang/


Regards,

xiao sheng wen

>>> Well, d/copyright is inconsistent with the source code. Please recheck
>>> and update it. For example:
>>> - Upstream code is GPL-2+, at least setty.c
>>> - Other files have same license, but different copyright holders.
>>> - Please ensure to quote the complete license boiler plate,
>>>    (all 3 paragraphs; if necessary, change the FSF address. "*" can
>>>     be stripped.)
> used GPL-2+, from yiyantang/README and I also checked the files under src directory.
>
> I had uploaded the new package, please help to review again.
>
> Cheers,
> xiao sheng wen
>
>
-- 
肖盛文 xiao sheng wen Faris Xiao
微信(wechat)：atzlinux
《铜豌豆 Linux》
基于 Debian 的 Linux 中文桌面操作系统：https://www.atzlinux.com
Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com
GnuPG Public Key: 0x339240CB

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web