Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1020450 > unrolled thread

Bug#950334: aptitude: Help -> User's Manual contains special characters

Back to article view | Back to linux.debian.bugs.dist

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#950334: aptitude: Help -> User's Manual contains special characters Diego Escalante <diegoe@gnome.org> - 2020-08-04 01:00 +0200
    Bug#950334: [Aptitude-devel] Bug#950334: aptitude: Help -> User's Manual contains special characters Axel Beckert <abe@debian.org> - 2020-08-04 11:40 +0200

#1020450 — Bug#950334: aptitude: Help -> User's Manual contains special characters

[Multipart message — attachments visible in raw view] — view raw

Package: aptitude
Version: 0.8.13-1+b1
Followup-For: Bug #950334
X-Debbugs-Cc: diegoe@gnome.org

This is actually a broader bug and not related to specific locales.
The issue is that `src/ui.cc` defaults to transcoding the README files
to ISO-8859-1, and since all the README files are already UTF-8, you get
glitchy glyphs.

I'm attaching a patch for this specific issue, but note that I have an
open MR which includes this and a few more encoding related fixes:
  https://salsa.debian.org/apt-team/aptitude/-/merge_requests/10/commits

Note also that I wasn't able to properly test this because of the
current FTBFS in:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966875

But that said, this is merely a string replacement, shouldn't be
problematic.

-- Package-specific info:
Terminal: xterm-256color
$DISPLAY is set.
which aptitude: /usr/bin/aptitude

aptitude version information:
aptitude 0.8.13
Compiler: g++ 9.3.0
Compiled against:
  apt version 6.0.0
  NCurses version 6.2
  libsigc++ version: 2.10.2
  Gtk+ support disabled.
  Qt support disabled.

Current library versions:
  NCurses version: ncurses 6.2.20200212
  cwidget version: 0.5.18
  Apt version: 6.0.0

aptitude linkage:
	linux-vdso.so.1 (0x00007ffcc57a8000)
	libapt-pkg.so.6.0 => /lib/x86_64-linux-gnu/libapt-pkg.so.6.0 (0x00007fbc70029000)
	libncursesw.so.6 => /lib/x86_64-linux-gnu/libncursesw.so.6 (0x00007fbc6ffee000)
	libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007fbc6ffbf000)
	libsigc-2.0.so.0 => /lib/x86_64-linux-gnu/libsigc-2.0.so.0 (0x00007fbc6ffb6000)
	libcwidget.so.4 => /lib/x86_64-linux-gnu/libcwidget.so.4 (0x00007fbc6feb0000)
	libsqlite3.so.0 => /lib/x86_64-linux-gnu/libsqlite3.so.0 (0x00007fbc6fd84000)
	libboost_iostreams.so.1.71.0 => /lib/x86_64-linux-gnu/libboost_iostreams.so.1.71.0 (0x00007fbc6fd5b000)
	libxapian.so.30 => /lib/x86_64-linux-gnu/libxapian.so.30 (0x00007fbc6fb41000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fbc6fb1f000)
	libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fbc6f952000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fbc6f80e000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fbc6f7f4000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fbc6f62d000)
	libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fbc6f613000)
	libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fbc6f5f6000)
	libbz2.so.1.0 => /lib/x86_64-linux-gnu/libbz2.so.1.0 (0x00007fbc6f5e3000)
	liblzma.so.5 => /lib/x86_64-linux-gnu/liblzma.so.5 (0x00007fbc6f5ba000)
	liblz4.so.1 => /lib/x86_64-linux-gnu/liblz4.so.1 (0x00007fbc6f598000)
	libzstd.so.1 => /lib/x86_64-linux-gnu/libzstd.so.1 (0x00007fbc6f4ec000)
	libudev.so.1 => /lib/x86_64-linux-gnu/libudev.so.1 (0x00007fbc6f4c6000)
	libsystemd.so.0 => /lib/x86_64-linux-gnu/libsystemd.so.0 (0x00007fbc6f41b000)
	libgcrypt.so.20 => /lib/x86_64-linux-gnu/libgcrypt.so.20 (0x00007fbc6f2fe000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fbc70684000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fbc6f2f8000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fbc6f2eb000)
	libuuid.so.1 => /lib/x86_64-linux-gnu/libuuid.so.1 (0x00007fbc6f2e2000)
	libgpg-error.so.0 => /lib/x86_64-linux-gnu/libgpg-error.so.0 (0x00007fbc6f2bf000)

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-2-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages aptitude depends on:
ii  aptitude-common           0.8.13-1
ii  libapt-pkg6.0             2.1.7
ii  libboost-iostreams1.71.0  1.71.0-6+b2
ii  libc6                     2.31-2
ii  libcwidget4               0.5.18-5
ii  libgcc-s1                 10.2.0-3
ii  libncursesw6              6.2-1
ii  libsigc++-2.0-0v5         2.10.2-1
ii  libsqlite3-0              3.32.3-1
ii  libstdc++6                10.2.0-3
ii  libtinfo6                 6.2-1
ii  libxapian30               1.4.15-1

Versions of packages aptitude recommends:
ii  libdpkg-perl    1.20.5
ii  sensible-utils  0.0.12+nmu1

Versions of packages aptitude suggests:
pn  apt-xapian-index                <none>
pn  aptitude-doc-en | aptitude-doc  <none>
pn  debtags                         <none>
ii  tasksel                         3.59

-- no debconf information

[toc] | [next] | [standalone]

#1020489 — Bug#950334: [Aptitude-devel] Bug#950334: aptitude: Help -> User's Manual contains special characters

Hi Diego,

Diego Escalante wrote:
> This is actually a broader bug and not related to specific locales.

Suspected that, yes. But then again, not in the way you noticed. (I
suspected ISO-Latin encoded chacracters in source code files, e.g.
French or German contributor names, not hardcoded encoding names…)

> The issue is that `src/ui.cc` defaults to transcoding the README files
> to ISO-8859-1, and since all the README files are already UTF-8, you get
> glitchy glyphs.

I guess I wasn't aware of that when coverting them after Lintian
warnings or so. At least I did that for many of my packages. Not sure
if I was the one who did it with aptitude, but chances are not that
low. ;-)

> I'm attaching a patch for this specific issue, but note that I have an
> open MR which includes this and a few more encoding related fixes:
>   https://salsa.debian.org/apt-team/aptitude/-/merge_requests/10/commits

Thanks a lot!

Funnily
https://salsa.debian.org/apt-team/aptitude/-/merge_requests/10/diffs
doesn't really show the changes as it at least partially seems to
convert the encoding line by line. So both, old and especially new
look good. :-)

> Note also that I wasn't able to properly test this because of the
> current FTBFS in:
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966875

Ack. Yeah, I'm aware of it. Building with gcc 9 instead of 10 should
work, in case you're curious to see if it flies. :-)

> But that said, this is merely a string replacement, shouldn't be
> problematic.

Ack, I think so, too.

I though think we should not merge it before that FTBFS is fixed.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web