Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1015874 > unrolled thread

Bug#964013: lintian: embedded-javascript-library should flag sphinx files too

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#964013: lintian: embedded-javascript-library should flag sphinx files too Holger Levsen <holger@debian.org> - 2020-06-30 13:50 +0200
    Bug#964013: lintian: embedded-javascript-library should flag sphinx files too Holger Levsen <holger@layer-acht.org> - 2020-07-13 12:50 +0200
    Bug#964013: lintian: embedded-javascript-library should flag sphinx files too Maxime Werlen <maxime@werlen.fr> - 2020-07-19 17:00 +0200
    Bug#964013: lintian: embedded-javascript-library should flag sphinx files too Andreas Beckmann <anbe@debian.org> - 2020-07-28 19:00 +0200

#1015874 — Bug#964013: lintian: embedded-javascript-library should flag sphinx files too

[Multipart message — attachments visible in raw view] — view raw

Package: lintian
Version: 2.82.0
Severity: wishlist

Dear Maintainer,

running lintian on developers-reference 11.0.12 from bullseye results in two
warnings:

W: developers-reference-ru: embedded-javascript-library usr/share/developers-reference/ru/_static/jquery.js please use libjs-jquery
W: developers-reference-ru: embedded-javascript-library usr/share/developers-reference/ru/_static/underscore.js please use libjs-underscore

I fixed those two in 11.0.13 in sid, but there are still embedded javascript
libraries included, which lintian does not detect:

$ dpkg -L developers-reference|grep js
/usr/share/developers-reference/_static/doctools.js
/usr/share/developers-reference/_static/documentation_options.js
/usr/share/developers-reference/_static/language_data.js
/usr/share/developers-reference/_static/searchtools.js
/usr/share/developers-reference/_static/switchers.js
/usr/share/developers-reference/searchindex.js
/usr/share/developers-reference/_static/jquery.js
/usr/share/developers-reference/_static/underscore.js

Out of these, three of them come from Sphinx:
- doctools.js
- language_data.js
- searchtools.js

Please make lintian complain about embedding those. It seems the problem could
be quite widespread:

$ for i in doctools.js language_data.js searchtools.js ; do apt-file search "_static/$i" | wc -l ; done
1046
977
1046


-- 
cheers,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

[toc] | [next] | [standalone]

#1017815

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Mon, Jul 13, 2020 at 12:24:53PM +0200, Alexis Murzeau wrote:
> I'm getting this new lintian warning for language_data.js,
> but I can't find which binary package I should depend on.
> 
> "sphinx" (as suggested by lintian) is a virtual package provided by python3-sphinx
> which doesn't contain "language_data.js" [0] and libjs-sphinxdoc (which seems more
> appropriate) does not contain "language_data.js" either [1].
[...]
> This will help maintainers find the correct package to use.
 
https://salsa.debian.org/debian/developers-reference/-/commit/29014c3d02b1a44aa983557b4887f4302c2136c5
shows how to use dh_sphinxdoc (instead of dh_linktree which also does
and did the right thing here), which then in turn adds the right
depends/recommends to the binary packages.

(The dh_linktree solution used a hack/workaround in d/rules to turn
the depends into recommends, but I recommend the dh_spinxdoc solution
anyway.)


-- 
cheers,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

[toc] | [prev] | [next] | [standalone]

#1018528

[Multipart message — attachments visible in raw view] — view raw

Hi,

It seems that language_data.js comes from a template from sphinx-common,
see https://packages.debian.org/sid/all/sphinx-common/filelist

We cannot symlink to this file as it contains templating markups. I've
found no package usable to symlink this file.

Regards,

Maxime

[toc] | [prev] | [next] | [standalone]

#1019621

Followup-For: Bug #964013
Control: reopen -1

Hi,

I stumbled upon this while trying to fix

W: pocl-doc: embedded-javascript-library usr/share/doc/pocl-doc/html/_static/language_data.js please use sphinx 

language_data.js seems to be a false positive as long as
sphinx^Wthe-correct-sphinx-js-package (libjs-sphinxdoc?) does not provide
a linkable "master" copy. (And then it should be handled by dh_sphinxdoc.)


Andreas

PS: doctools.js and searchtools.js are correctly identified :-)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web