Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1016532 > unrolled thread

Bug#964281: lintian: tag national-encoding emitted for patches fixing this tag

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#964281: lintian: tag national-encoding emitted for patches fixing this tag Axel Beckert <abe@debian.org> - 2020-07-05 01:40 +0200
    Bug#964281: marked as pending in lintian Axel Beckert <abe@debian.org> - 2020-07-05 15:50 +0200
      Bug#964281: marked as pending in lintian Felix Lechner <felix.lechner@lease-up.com> - 2020-07-05 16:20 +0200
    Bug#964281: closed by Debian FTP Masters <ftpmaster@ftp-master.debian.org> (reply to Chris Lamb <lamby@debian.org>) (Bug#964281: fixed in lintian 2.83.0) Axel Beckert <abe@debian.org> - 2020-07-08 14:20 +0200
    Bug#964281: marked as pending in lintian Axel Beckert <abe@debian.org> - 2020-07-09 02:50 +0200
      Bug#964281: marked as pending in lintian Felix Lechner <felix.lechner@lease-up.com> - 2020-07-09 03:00 +0200
        Bug#964281: marked as pending in lintian Axel Beckert <abe@debian.org> - 2020-07-09 03:10 +0200

#1016532 — Bug#964281: lintian: tag national-encoding emitted for patches fixing this tag

Package: lintian
Version: 2.82.0
Severity: normal

Because lintian emitted the national-encoding tag for a bunch of
upstream files, I added a patch which fixes this.

Now lintian complains about that patch:

W: wml source: national-encoding debian/patches/change-national-encoding-to-utf-8.patch

IMHO files under debian/patches should be either completely excluded
from this tag or (less trivial) only the DEP3 headers in these files
should be checked for containing national encoding.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), (111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), (105, 'experimental-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 5.6.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                      2.34-8
ii  bzip2                         1.0.8-3
ii  diffstat                      1.63-1
ii  dpkg                          1.20.3
ii  dpkg-dev                      1.20.3
ii  file                          1:5.38-5
ii  gettext                       0.19.8.1-10
ii  gpg                           2.2.20-1
ii  intltool-debian               0.35.0+20060710.5
ii  libapt-pkg-perl               0.1.36+b3
ii  libarchive-zip-perl           1.68-1
ii  libcapture-tiny-perl          0.48-1
ii  libclass-xsaccessor-perl      1.19-3+b5
ii  libclone-perl                 0.45-1
ii  libconfig-tiny-perl           2.24-1
ii  libcpanel-json-xs-perl        4.19-1
ii  libdata-validate-domain-perl  0.10-1
ii  libdevel-size-perl            0.83-1+b1
ii  libdigest-sha-perl            6.02-1+b2
ii  libdpkg-perl                  1.20.3
ii  libemail-address-xs-perl      1.04-1+b2
ii  libfile-basedir-perl          0.08-1
ii  libfile-find-rule-perl        0.34-1
ii  libfont-ttf-perl              1.06-1
ii  libhtml-parser-perl           3.72-5
ii  libio-async-loop-epoll-perl   0.21-1
ii  libio-async-perl              0.77-3
ii  libjson-maybexs-perl          1.004002-1
ii  liblist-compare-perl          0.53-1
ii  liblist-moreutils-perl        0.416-1+b5
ii  liblist-utilsby-perl          0.11-1
ii  libmoo-perl                   2.004000-1
ii  libmoox-aliases-perl          0.001006-1
ii  libnamespace-clean-perl       0.27-1
ii  libpath-tiny-perl             0.114-1
ii  libsereal-decoder-perl        4.014+ds-1
ii  libsereal-encoder-perl        4.014+ds-1
ii  libtext-levenshtein-perl      0.13-1
ii  libtimedate-perl              2.3300-1
ii  libtry-tiny-perl              0.30-1
ii  libtype-tiny-perl             1.010002-1
ii  libunicode-utf8-perl          0.62-1+b1
ii  liburi-perl                   1.76-2
ii  libxml-libxml-perl            2.0134+dfsg-2
ii  libxml-writer-perl            0.625-1
ii  libyaml-libyaml-perl          0.82+repack-1
ii  man-db                        2.9.3-1
ii  patchutils                    0.3.4-3
ii  perl [libdigest-sha-perl]     5.30.3-4
ii  t1utils                       1.41-4
ii  xz-utils                      5.2.4-1+b1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b6

Versions of packages lintian suggests:
ii  binutils-multiarch     2.34-8
ii  libtext-template-perl  1.58-1

-- no debconf information

[toc] | [next] | [standalone]

#1016603 — Bug#964281: marked as pending in lintian

Hi Felix,

Felix Lechner wrote:
> In Debian patches, only check the DEP-3 header for legacy encoding.
> (Closes: #964281)

Yay, thanks!

> Splits Debian patches into parts and only checks patch headers for
> legacy encodings. Thank you to Axel Becker for that excellent idea.

Thanks for the praise. Unfortunately with a missing character in my
family name. :-/ (But yeah, it's a common typo and I'm used to it.)

> Thanks to Axel Beckert for his patience and the generosity of his time
> in reporting the oversight.

Oh, I considered it just a normal bug report with ideas how to maybe
fix it. :-)

> It ended up being a fun and easy fix.

Cool!

> As a side note, the bug reporter's statement about upstream files was
> not fully accurate.  The check never looked at upstream files.

Ah, sorry. I was aware of this, because the file name which was
reported and the file which needed to be patched had different file
suffixes (*.src vs *.wml). I just mentioned "upstream" to explain the
reason for the need to patch instead of just editing the files.

> This commit has a potential to disturb the release process.

Huh?

> Since building is broken in unstable, the package was built and
> examined with Lintian in a testing chroot.

Ah, this probably also explains why
https://lintian.debian.org/tags.html misses some of the new tags. I
searched for "breakout-link" in it for a reference to upstream several
times the past few days.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[toc] | [prev] | [next] | [standalone]

#1016608 — Bug#964281: marked as pending in lintian

Hi Axel,

On Sun, Jul 5, 2020 at 6:45 AM Axel Beckert <abe@debian.org> wrote:
>
> > This commit has a potential to disturb the release process.

The two tests

    t/recipes/checks/files/encoding/utf8-header-fix-encoding-patch/
    t/recipes/checks/files/encoding/national-header-fix-encoding-patch/

contain legacy encoding and would have triggered 'national-encoding'
when Lintian is released. The Lintian maintainers, however, strive to
keep Lintian itself Lintian-clean.

The occurrence is traditionally prevented by either (1) creating the
offending files on the fly or (2) by adding a programmatic exemption
for the 'lintian' package. Here I did not do either. The latter leads
to ridicule on IRC and was remedied in a general way with this commit,
but is currently untested:

    https://salsa.debian.org/lintian/lintian/-/commit/4f4654ddfd2841f5440a83bc3f30b6091b10986c

So before burdening fellow maintainers with unexpected release
problems, I tested a full package build, and then ran Lintian on
itself, in a testing chroot.

I would have liked to use unstable but Lintian does not currently
build there as a result of a bug in Dpkg.

> Ah, this probably also explains why
> https://lintian.debian.org/tags.html misses some of the new tags. I
> searched for "breakout-link" in it for a reference to upstream several
> times the past few days.

Unfortunately, it does not. Over the past few months, the website has
been updated only sporadically from my own hardware and database
systems, which have more resources than the service provided by DSA.
Some details are in Bug #779228.

I am not sure sure what is causing the problems (and I am sure DSA
would provide additional resources if I asked) but for many users the
service is deficient in other ways. Most notably, it is difficult from
a scheduling perspective to provide just-in-time analysis for new
uploads. In any event, people only see those results after they
upload. Ideally, they would see them before.

To tackle that use case from a different angle, I worked with the
Salsa CI team to modify the standard runner so Lintian tags are issued
in Salsa CI. (That already happens on a regular basis, but the results
are stored as JUnit xml and generally ignored.) We added a new
standalone HTML output mode, which is described here [1]. A nice web
page that resembles lintian.d.o will be shown to a majority of Salsa
users a short time after they commit to their master branches.

[1] https://lists.debian.org/debian-lint-maint/2020/07/msg00022.html

The Lintian website will probably provide links to the relevant Gitlab
pages in Salsa. We will also advise tracker.d.o of these new resources
and URLs.

To reimagine lintian.d.o., we may also collect those individual
Lintian results for research and archival purposes. The Lintian
website will probably become a research tool for the QA team with
higher order functions that Lintian does not currently provide, such
as full dependency graph analysis, which would be appreciated by the
bootstrapping team. Some of ideas are mentioned here:

    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896012#31

Thank you for your valuable contributions to Lintian, and sorry about
any inconvenience as we try to make the software better for everyone.

Kind regards
Felix Lechner

[toc] | [prev] | [next] | [standalone]

#1017060 — Bug#964281: closed by Debian FTP Masters <ftpmaster@ftp-master.debian.org> (reply to Chris Lamb <lamby@debian.org>) (Bug#964281: fixed in lintian 2.83.0)

Control: reopen -1
Control: found -1 2.83.0

Hi Felix,

Debian Bug Tracking System wrote:
>    * Only check the DEP-3 header for legacy encodings in debian/patches.
>      (Closes: #964281)

Seems not to work as expected yet.

You can try it with src:wml as currently in Debian Unstable or as in
git on https://salsa.debian.org/debian/wml.

$ lintian -iIE --pedantic wml_2.28.0~ds1-2_amd64.changes
W: wml source: national-encoding DEP-3 header debian/patches/change-national-encoding-to-utf-8.patch

But the patch has not a single (visible) 8-bit character in there.

I also attached the full patch in question. Hopefully it survives the
mail as it contains a mixture of different encodings. I compressed it
with gzip in the hope it avoids these kind of issues. :-)

Here's the DEP3 header of that patch (copy and paste from a "cat"
inside an xterm) though:

Description: Change national encoding to UTF-8. Prompted by Lintian.
Author: Axel Beckert <abe@debian.org>
Forwarded: no

--- a/COPYRIGHT.OTHER
+++ b/COPYRIGHT.OTHER
[...]

I hope these details help to find the culprit.

Thanks again for caring and for the initial try to fix this!

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[toc] | [prev] | [next] | [standalone]

#1017133 — Bug#964281: marked as pending in lintian

Hi Felix,

Felix Lechner wrote:
> The patch change-national-encoding-to-utf-8.patch in the wml package
> did not have the nice notice added by quilt:
> 
>     This patch header follows DEP-3: http://dep.debian.net/deps/dep3/

Huh? I've never seen such a line. And I'm using quilt a lot on the
commandline. It's either very new or not generated by any of the quilt
commands usually in my workflow (quilt subcommands add, edit, new and
refresh). But then again that patch was generated by quilt on Debian
Unstable just a few days ago using "quilt new", "quilt add" (maybe
"quilt edit" instead) and "quilt refresh" IIRC.

> Now the check splits on '^--- ', which is presumably what the patch
> program does before applying a diff.

This is what I'd have expected. Potentially it should split on
'^Index: ', too, as that belongs to some patch formats, IIRC those
emitted by some git commands. ("quilt refresh" usually removes those
lines, though.)

> The wml package no longer emits the tag:
> 
> % ./frontend/lintian /mirror/debian/pool/main/w/wml/wml_2.28.0\~ds1-1.dsc
> I: wml source: unused-override national-encoding debian/patches/change-national-encoding-to-utf-8.patch

Yay!

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[toc] | [prev] | [next] | [standalone]

#1017134 — Bug#964281: marked as pending in lintian

Hi Axel,

On Wed, Jul 8, 2020 at 5:45 PM Axel Beckert <abe@debian.org> wrote:
>
> Huh? I've never seen such a line.

Do you use 'quilt header -e --dep3' ?

Kind regards
Felix Lechner

[toc] | [prev] | [next] | [standalone]

#1017135 — Bug#964281: marked as pending in lintian

Hi Felix,

Felix Lechner wrote:
> > Huh? I've never seen such a line.
> 
> Do you use 'quilt header -e --dep3' ?

Never seen that command, neither the "header" subcommand nor these
options.

I think I'm using quilt for like 12 or 13 years — which seems a few
years longer than DEP3 exists. And I probably never checked if some
kind of DEP3 support was added to it. I always write my DEP3 headers
by hand according to the DEP3 specification.

And this

> > > This patch header follows DEP-3: http://dep.debian.net/deps/dep3/

doesn't look like being RFC822-conforming due to the blanks in the key
part. So I'm kinda suprised that this is even in there.

I also can't find it in the DEP3 specification at
https://dep-team.pages.debian.net/deps/dep3/ so from my point of view,
this is _NO_ common nor a specified part of a DEP3 header.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web