Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1016534 > unrolled thread
| Started by | Axel Beckert <abe@debian.org> |
|---|---|
| First post | 2020-07-05 03:10 +0200 |
| Last post | 2020-07-05 17:10 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
Bug#964282: lintian: tried to issue unknown tags: manpage-in-wrong-directory at /usr/share/perl5/Lintian/Group.pm line 451. Axel Beckert <abe@debian.org> - 2020-07-05 03:10 +0200
Bug#964282: lintian: tried to issue unknown tags: manpage-in-wrong-directory at /usr/share/perl5/Lintian/Group.pm line 451. Axel Beckert <abe@debian.org> - 2020-07-05 03:30 +0200
Bug#964282: marked as pending in lintian Axel Beckert <abe@debian.org> - 2020-07-05 16:00 +0200
Bug#964282: marked as pending in lintian Felix Lechner <felix.lechner@lease-up.com> - 2020-07-05 16:30 +0200
Bug#964282: marked as pending in lintian Axel Beckert <abe@debian.org> - 2020-07-05 17:10 +0200
| From | Axel Beckert <abe@debian.org> |
|---|---|
| Date | 2020-07-05 03:10 +0200 |
| Subject | Bug#964282: lintian: tried to issue unknown tags: manpage-in-wrong-directory at /usr/share/perl5/Lintian/Group.pm line 451. |
| Message-ID | <Ap1kl-rQ-5@gated-at.bofh.it> |
Package: lintian
Version: 2.82.0
Severity: important
Hi,
after trying to rename man page sections in lintian by just renaming the
files and putting them in the right directory, and then running lintian
over the resulting package, lintian seems to have crashed as follows:
Now running lintian -iIE --pedantic wml_2.28.0~ds1-1_amd64.changes ...
Warning in group wml/2.28.0~ds1-1: Check documentation/manual has no tag manpage-in-wrong-directory. at /usr/share/perl5/Lintian/Check.pm line 147.
tried to issue unknown tags: manpage-in-wrong-directory at /usr/share/perl5/Lintian/Group.pm line 451.
Lintian::Group::process(Lintian::Group=HASH(0x5588ced83078), HASH(0x5588cdf6fed8), HASH(0x5588cde600d8), Lintian::Output::Standard=HASH(0x5588cdf32178)) called at /usr/share/perl5/Lintian/Pool.pm line 179
Lintian::Pool::process(Lintian::Pool=HASH(0x5588cdf53710), Lintian::Profile=HASH(0x5588cefb8af0), SCALAR(0x5588cef5cd68), HASH(0x5588cde600d8), GLOB(0x5588ccecc810), Lintian::Output::Standard=HASH(0x5588cdf32178)) called at /usr/share/lintian/commands/lintian.pm line 778
main::main() called at /usr/bin/lintian line 47
eval {...} called at /usr/bin/lintian line 47
main::__ANON__("/usr/share/lintian/commands/lintian.pm") called at /usr/bin/lintian line 120
dplint::run_tool("/usr/bin/lintian", "lintian") called at /usr/bin/lintian line 299
dplint::main() called at /usr/bin/lintian line 383
Finished running lintian.
This tag seems to have been renamed to odd-place-for-manual-page.
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), (111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), (105, 'experimental-debug')
Architecture: amd64 (x86_64)
Kernel: Linux 5.6.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages lintian depends on:
ii binutils 2.34-8
ii bzip2 1.0.8-3
ii diffstat 1.63-1
ii dpkg 1.20.3
ii dpkg-dev 1.20.3
ii file 1:5.38-5
ii gettext 0.19.8.1-10
ii gpg 2.2.20-1
ii intltool-debian 0.35.0+20060710.5
ii libapt-pkg-perl 0.1.36+b3
ii libarchive-zip-perl 1.68-1
ii libcapture-tiny-perl 0.48-1
ii libclass-xsaccessor-perl 1.19-3+b5
ii libclone-perl 0.45-1
ii libconfig-tiny-perl 2.24-1
ii libcpanel-json-xs-perl 4.19-1
ii libdata-validate-domain-perl 0.10-1
ii libdevel-size-perl 0.83-1+b1
ii libdigest-sha-perl 6.02-1+b2
ii libdpkg-perl 1.20.3
ii libemail-address-xs-perl 1.04-1+b2
ii libfile-basedir-perl 0.08-1
ii libfile-find-rule-perl 0.34-1
ii libfont-ttf-perl 1.06-1
ii libhtml-parser-perl 3.72-5
ii libio-async-loop-epoll-perl 0.21-1
ii libio-async-perl 0.77-3
ii libjson-maybexs-perl 1.004002-1
ii liblist-compare-perl 0.53-1
ii liblist-moreutils-perl 0.416-1+b5
ii liblist-utilsby-perl 0.11-1
ii libmoo-perl 2.004000-1
ii libmoox-aliases-perl 0.001006-1
ii libnamespace-clean-perl 0.27-1
ii libpath-tiny-perl 0.114-1
ii libsereal-decoder-perl 4.014+ds-1
ii libsereal-encoder-perl 4.014+ds-1
ii libtext-levenshtein-perl 0.13-1
ii libtimedate-perl 2.3300-1
ii libtry-tiny-perl 0.30-1
ii libtype-tiny-perl 1.010002-1
ii libunicode-utf8-perl 0.62-1+b1
ii liburi-perl 1.76-2
ii libxml-libxml-perl 2.0134+dfsg-2
ii libxml-writer-perl 0.625-1
ii libyaml-libyaml-perl 0.82+repack-1
ii man-db 2.9.3-1
ii patchutils 0.3.4-3
ii perl [libdigest-sha-perl] 5.30.3-4
ii t1utils 1.41-4
ii xz-utils 5.2.4-1+b1
Versions of packages lintian recommends:
ii libperlio-gzip-perl 0.19-1+b6
Versions of packages lintian suggests:
ii binutils-multiarch 2.34-8
ii libtext-template-perl 1.58-1
-- no debconf information
[toc] | [next] | [standalone]
| From | Axel Beckert <abe@debian.org> |
|---|---|
| Date | 2020-07-05 03:30 +0200 |
| Message-ID | <Ap1DI-ya-1@gated-at.bofh.it> |
| In reply to | #1016534 |
Hi,
Axel Beckert wrote:
> tried to issue unknown tags: manpage-in-wrong-directory at /usr/share/perl5/Lintian/Group.pm line 451.
[...]
> This tag seems to have been renamed to odd-place-for-manual-page.
The patch for this seems trivial:
diff --git a/checks/documentation/manual.pm b/checks/documentation/manual.pm
index cf4f433ac..b30bf6081 100644
--- a/checks/documentation/manual.pm
+++ b/checks/documentation/manual.pm
@@ -144,7 +144,7 @@ sub files {
# number of directory and manpage extension equal?
if ($section_num != $section) {
- $self->tag('manpage-in-wrong-directory', $file);
+ $self->tag('odd-place-for-manual-page', $file);
}
} else {
$self->tag('wrong-name-for-manual-page', $file);
But I wonder why the test suite didn't catch this issue. So I'm not
sure if the patch above is sufficient.
Additionally I seem to no more have the required resources on my
laptop to build lintian — it wanted to install nearly 1 TB of
additional build-dependencies.
And just calling
$ debian/rules runtests onlyrun=tag:odd-place-for-manual-page
still seems to try to build all 1189 test case source packages instead
of just those few needed for the checks related to this tag.
Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
[toc] | [prev] | [next] | [standalone]
| From | Axel Beckert <abe@debian.org> |
|---|---|
| Date | 2020-07-05 16:00 +0200 |
| Subject | Bug#964282: marked as pending in lintian |
| Message-ID | <Apdlw-7EA-13@gated-at.bofh.it> |
| In reply to | #1016534 |
Hi Felix, Felix Lechner wrote: > Rename second mention of tag manpage-in-wrong-directory. (Closes: #964282) > > The tag was likely issued in two locations. Sometimes a second > location is forgotten when an editor is closed too quickly. Sure, that happens. What I mostly wondered: Why didn't the test suite catch that second case? As far as I remember, Lintian has quite high test coverage. Then again, regarding your comment in my other bug report about the broken lintian build, I suspect that there might be a test for this, but the tests are currently not running properly, so they couldn't alert. > My apologies to Axel Beckert for the inconvenience. Hey, no problem! Bugs happen. You can't make an omelette without breaking eggs. (Wo gehobelt wird, da fallen Späne. :-) I actually stashed that fix in wml for now as the crash at least showed me that it was obviously an incomplete fix. Thanks again for a very prompt fix! Regards, Axel -- ,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
[toc] | [prev] | [next] | [standalone]
| From | Felix Lechner <felix.lechner@lease-up.com> |
|---|---|
| Date | 2020-07-05 16:30 +0200 |
| Subject | Bug#964282: marked as pending in lintian |
| Message-ID | <ApdOx-83w-9@gated-at.bofh.it> |
| In reply to | #1016606 |
Hi Axel,
On Sun, Jul 5, 2020 at 6:57 AM Axel Beckert <abe@debian.org> wrote:
>
> Why didn't the test suite catch that second case?
The tests do not exercise all execution paths. :(
In our new coding practices, we try to separate diagnostics and
issuance like this (please see the use of the array @empty), but there
is legacy code:
my @all = keys %{$self->processable->field};
my @empty = grep { $self->processable->field($_) =~ /^\s*$/ } @all;
$self->tag('empty-field', $_) for @empty;
> I actually stashed that fix in wml for now as the crash at least
> showed me that it was obviously an incomplete fix.
What is 'wml', please? Maybe I should use it too. :)
Kind regards
Felix Lechner
[toc] | [prev] | [next] | [standalone]
| From | Axel Beckert <abe@debian.org> |
|---|---|
| Date | 2020-07-05 17:10 +0200 |
| Subject | Bug#964282: marked as pending in lintian |
| Message-ID | <Aperg-8w0-5@gated-at.bofh.it> |
| In reply to | #1016609 |
Hi Felix,
Felix Lechner wrote:
> > Why didn't the test suite catch that second case?
>
> The tests do not exercise all execution paths. :(
I see. :-(
> In our new coding practices, we try to separate diagnostics and
> issuance like this (please see the use of the array @empty), but there
> is legacy code:
>
> my @all = keys %{$self->processable->field};
> my @empty = grep { $self->processable->field($_) =~ /^\s*$/ } @all;
>
> $self->tag('empty-field', $_) for @empty;
>
> > I actually stashed that fix in wml for now as the crash at least
> > showed me that it was obviously an incomplete fix.
>
> What is 'wml', please?
It's the Website Meta Language which is e.g. used to built the static
web pages on www.debian.org for at least a decade, maybe two decades.
> Maybe I should use it too. :)
Probably not.
While the current upstream developer piece by piece modernizes it
behind the scenes, it still has its roots in the nineties and is
difficult to debug despite it kinda adheres to the KISS principle by
consisting of 9 smaller tools which all do their job. But debugging
them together and figuring out which of the 9 tools doesn't behave
properly, is rather hard — the Debian web team can surely tell quite a
few such stories, especially wrt. to non-european languages vs
encodings, see https://bugs.debian.org/959761. :-)
And even upstream recommends to not use it for new projects.
But I'm kinda oldschool, use it since the nineties and still like it,
also because it has an embedded Perl interpreter. I built WAP Wireless
Markup Languages (WML, long forgotten and obsolete) sites with the
Website Meta Language (also WML) back in the late nineties, early
2000s at work. :-)
Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web