Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1026001 > unrolled thread

Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime)

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-22 11:10 +0200
    Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-22 13:00 +0200
      Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Tobias Frost <tobi@debian.org> - 2020-09-22 13:50 +0200
      Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-22 13:50 +0200
    Bug#970712: tags 970712 - moreinfo Alec Leamas <leamas.alec@gmail.com> - 2020-09-22 13:00 +0200
    Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-22 21:10 +0200
      Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Gianfranco Costamagna <locutusofborg@debian.org> - 2020-09-23 11:10 +0200
        Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-23 11:40 +0200
          Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-23 11:40 +0200
    Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Tobias Frost <tobi@debian.org> - 2020-09-24 10:40 +0200
      Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime) Alec Leamas <leamas.alec@gmail.com> - 2020-09-24 13:30 +0200

#1026001 — Bug#970712: RFS: libcxx-serial/1.2.1-2 [RC] -- Cross-platform, Serial Port library written in C++ (runtime)

Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "libcxx-serial":

 * Package name    : libcxx-serial
   Version         : 1.2.1-2
   Upstream Author : William Woodall wjwwood@gmail.com
 * URL             : https://github.com/wjwwood/serial
 * License         : Expat, BSD-3-clause
 * Vcs             : https://gitlab.com/leamas/cxx-serial
   Section         : libs

It builds two binary packages:

  libcxx-serial1 - Cross-platform, Serial Port library written in C++
(runtime)
  libcxx-serial-dev - Cross-platform, Serial Port library written in C++
(devel)

More info: https://mentors.debian.net/package/libcxx-serial/

Or, using dget:

  dget -x
https://mentors.debian.net/debian/pool/main/libc/libcxx-serial/libcxx-serial_1.2.1-2.dsc

Changes since the last upload:

libcxx-serial (1.2.1-2) unstable; urgency=medium
 .
   * Drop v8stdint.h header (not used in Debian). Closes: #921697
   * Update python-catkin-pkg BR to python3.
   * Standards-version -> 4.5.0, no changes.
   * Update dephelper-compat -> 12
   * Set Rules-Requires-Root
   * Add d/upstream/metadata
   * Handle DEB_BUILD_OPTIONS when overriding test target.
   * Clean up test target in d/rules,
   * Simplify d/rules using --buildsystem=cmake.
   * Reorganize repo branches according to dep-14.
   * Fix lingering templates in d/watch.
   * New local patches:
      - Drop v8stdint.h header (above)
      - Make build verbose.
   * Cherry-picked upstream bugfix patches:
      - Fix SerialImpl constructor resource leak.
      - Handle 500kpbs serial ports.
      - Plug memory leak in exceptions.
      - Use MONOTONIC clock.

See also separate question on local build paths in the debug info:
https://lists.debian.org/debian-mentors/2020/09/msg00243.html

Regards,

--Alec Leamas

[toc] | [next] | [standalone]

#1026011

Hi,



On 22/09/2020 11:47, Tobias Frost wrote:
> Control: tags -1 moreinfo

Cleared


> On Tue, Sep 22, 2020 at 10:58:26AM +0200, Alec Leamas wrote:
> 
> Hi Alec,
> 
> To avoid confustion, I'm comparing the version in the archive (1.2.1-1.1) with
> yours, in case you missed the NMU.


Which is exactly what I did...

> - d/changelog you need to include the changelog of the NMU in your
>   changelog.


Done

> - d/copyright: Can you add the upstream contact?


Done

>   You probably also want to update the years on the debian section.


Done

> - d/control: you re-adding python-catkin-pkg as B-D. Is it needed?
>   (asking, as #943082 says no)


Indeed. Dropped.

> - d/rules: in the dh_override_auto_configure: you don't need to repeat
>   the buildsystem parameter.


Done.

> - (not required for upload)
>   not sure if you really need the 0007 patch; verbose builds should be
>   enabled automatically. (If not, you probably want to pass
>   -DCMAKE_VERBOSE_MAKEFILE=On the dh_override_auto_configure
>   (patches patching CMakeLists.txt will break on every upstream release,
>    in my experience. Or TL;DL: It's PITA).


Silly one, this. Of course it should be done using a parameter to cmake
rather than a patch. Fixed.

I need to upstream the CMake changes, there is actually a lot. But it's
a bit complicated, need to refactor the first patch into separate,
manageable ones.

OTOH, upstream doesn't seem to release that often.

> For later (as this requires a trip though NEW), maybe you want to put
> the doxygen documentation on a arch:all -doc package?


Hm... I know I actually considered this. On Fedora, the separate -doc
package is a nobrainer. However, I have understood that on Debian "too"
small packages are not really welcome.

Here, the docs are about 450K in 40 files. Is this enough for a package
to not be too small? What is really "small" in this context?


> Only minor changes required ;-) Good job!


hmpf. Missing the NMU wasn't minor, for sure. "depressed"


Cannot upload to mentors:

$ dput -f mentors ../libcxx-serial_1.2.1-2_source.changes
Checking signature on .changes
gpg: ../libcxx-serial_1.2.1-2_source.changes: Valid signature from
0A1DA7134E068B4C
Checking signature on .dsc
gpg: ../libcxx-serial_1.2.1-2.dsc: Valid signature from 0A1DA7134E068B4C
Uploading to mentors (via ftp to mentors.debian.net):
  Uploading libcxx-serial_1.2.1-2.dsc: 553 Could not create file.
Leaving existing libcxx-serial_1.2.1-2.dsc on the server and continuing


And now, what? "confused"


Many thanks for reviewing!

Cheers!
--alec


PS: As long as it is possible in any way, I'm avoiding the NEW queue.
Have been waiting there more than a year... DS

[toc] | [prev] | [next] | [standalone]

#1026019

[Multipart message — attachments visible in raw view] — view raw

On Tue, Sep 22, 2020 at 12:51:42PM +0200, Alec Leamas wrote:

> > For later (as this requires a trip though NEW), maybe you want to put
> > the doxygen documentation on a arch:all -doc package?
> 
> 
> Hm... I know I actually considered this. On Fedora, the separate -doc
> package is a nobrainer. However, I have understood that on Debian "too"
> small packages are not really welcome.
> 
> Here, the docs are about 450K in 40 files. Is this enough for a package
> to not be too small? What is really "small" in this context?

Yeah, this is not precisly definded. However for ~1/2MB, I would say it is
worth the trouble. As it can become arch:all, the deduplication is siginifanct.
(See below the "PS" as well.)
> 
> > Only minor changes required ;-) Good job!
> 
> 
> hmpf. Missing the NMU wasn't minor, for sure. "depressed"

/me starts wondering who is the pedantic one here…
OK, you wanted it: *beside that* good job!
(:-D)

> 
> Cannot upload to mentors:
> (...)
> 
> And now, what? "confused"

Probably someone has broken mentors…
Put your changes on your repo, I can pull from there. (in this case
there is no new orig.tar.gz, so the dangers of /me uploading something
wrong is limited)

Or send me a patch against the version I've reviewed… (choices, I know)

> 
> And now, what? "confused"

> 
> Many thanks for reviewing!
> 
> Cheers!
> --alec
> 
> 
> PS: As long as it is possible in any way, I'm avoiding the NEW queue.
> Have been waiting there more than a year... DS

I understand your worries… Some remarks for relief your worries:
- NEW is usually fast for existing source packages only adding/dropping
  packages. (yes, NEW-as-in-ITP sometimes (often) takes i$%§$§%$§ long*…)
- we would utilize the strategy to upload this package to experimental,
  where it would wait to clear NEW. This won't affect unstable and you'd
  be able to upload to unstable without the new binary package without
  problems. Once it has cleared NEW you'd (merge and) upload it to
  unstable


(* Debian is all about "When it's ready.", IOW patience required. Yes, its
  sometimes quite challening, but one mostly has to accept it or look
  how to drive things. With FTP/NEW such a strategy would be becoming
  DD, getting even more involved, joining the FTP masters team…)

[toc] | [prev] | [next] | [standalone]

#1026020

Hi again,

On 22/09/2020 12:51, Alec Leamas wrote:

> Cannot upload to mentors:
> 
> $ dput -f mentors ../libcxx-serial_1.2.1-2_source.changes
> Checking signature on .changes
> gpg: ../libcxx-serial_1.2.1-2_source.changes: Valid signature from
> 0A1DA7134E068B4C
> Checking signature on .dsc
> gpg: ../libcxx-serial_1.2.1-2.dsc: Valid signature from 0A1DA7134E068B4C
> Uploading to mentors (via ftp to mentors.debian.net):
>   Uploading libcxx-serial_1.2.1-2.dsc: 553 Could not create file.
> Leaving existing libcxx-serial_1.2.1-2.dsc on the server and continuing


Some kind of transient error. A new upload is available, timestamp on
mentors: 2020-09-22 11:08  (#4)


Cheers!

--alec

[toc] | [prev] | [next] | [standalone]

#1026012 — Bug#970712: tags 970712 - moreinfo

tags 970712 - moreinfo

[toc] | [prev] | [next] | [standalone]

#1026054

On 22/09/2020 13:52, Tobias Frost wrote:

> Uploading right after this mail with this cosmetic change:
> 
> l-1.2.1_orig/debian/changelog libcxx-serial-1.2.1/debian/changelog
> --- libcxx-serial-1.2.1_orig/debian/changelog	2020-09-22 13:46:47.366672711 +0200
> +++ libcxx-serial-1.2.1/debian/changelog	2020-09-22 13:50:03.325964836 +0200
> @@ -13,7 +13,6 @@
>    * Fix lingering templates in d/watch.
>    * New local patches:
>       - Drop v8stdint.h header (above)
> -     - Make build verbose.
>    * Cherry-picked upstream bugfix patches:
>       - Fix SerialImpl constructor resource leak.
>       - Handle 500kpbs serial ports.
> 
> 
> As always, thanks for your contributions!


And thanks for your thoughtful review, uploading and not least fixing my
last nitpicks!

Cheers!

--alec

[toc] | [prev] | [next] | [standalone]

#1026106

Hello,

just FYI, the upload fails on i386
https://buildd.debian.org/status/fetch.php?pkg=libcxx-serial&arch=i386&ver=1.2.1-2&stamp=1600846376&raw=0

Due to a difference between i686 and i386

The change in gst-omx might fix this problem

gst-omx (1.18.0-2) unstable; urgency=low
.
   * debian/gst-omx-listcomponents.install and debian/rules:
     Use ${DEB_HOST_GNU_TYPE} instead of ${DEB_HOST_MULTIARCH} to fix FTBFS
     on i386.


HTH

G.


Il martedì 22 settembre 2020, 21:09:38 CEST, Alec Leamas <leamas.alec@gmail.com> ha scritto: 





On 22/09/2020 13:52, Tobias Frost wrote:

> Uploading right after this mail with this cosmetic change:
> 
> l-1.2.1_orig/debian/changelog libcxx-serial-1.2.1/debian/changelog
> --- libcxx-serial-1.2.1_orig/debian/changelog    2020-09-22 13:46:47.366672711 +0200
> +++ libcxx-serial-1.2.1/debian/changelog    2020-09-22 13:50:03.325964836 +0200
> @@ -13,7 +13,6 @@
>    * Fix lingering templates in d/watch.
>    * New local patches:
>      - Drop v8stdint.h header (above)
> -    - Make build verbose.
>    * Cherry-picked upstream bugfix patches:
>      - Fix SerialImpl constructor resource leak.
>      - Handle 500kpbs serial ports.
> 
> 
> As always, thanks for your contributions!


And thanks for your thoughtful review, uploading and not least fixing my
last nitpicks!

Cheers!

--alec

[toc] | [prev] | [next] | [standalone]

#1026114

Hi Gianfranco,

On 23/09/2020 10:59, Gianfranco Costamagna wrote:
> Hello,
>
> just FYI, the upload fails on i386
> https://buildd.debian.org/status/fetch.php?pkg=libcxx-serial&arch=i386&ver=1.2.1-2&stamp=1600846376&raw=0
>
> Due to a difference between i686 and i386
>
> The change in gst-omx might fix this problem
>
> gst-omx (1.18.0-2) unstable; urgency=low
> .
>     * debian/gst-omx-listcomponents.install and debian/rules:
>       Use ${DEB_HOST_GNU_TYPE} instead of ${DEB_HOST_MULTIARCH} to fix FTBFS
>       on i386.
>
>
> HTH

libcxx-serial_1.2.1-3 is uploaded to mentors, available Real Soon (tm).


In haste,

--alec

[toc] | [prev] | [next] | [standalone]

#1026115

Hi again,

On 23/09/2020 11:27, Alec Leamas wrote

> libcxx-serial_1.2.1-3 is uploaded to mentors, available Real Soon (tm).
>
>
> In haste,
>
> --alec
>

Too much haste, new version uder way, need to wait for mentors to 
settle.  Correct fix is available in my gitlab repo.


In even more haste,

--alec

[toc] | [prev] | [next] | [standalone]

#1026254

[Multipart message — attachments visible in raw view] — view raw

Control: tags -1 moreinfo
Control: reopen -1 

On Thu, Sep 24, 2020 at 09:29:58AM +0200, Alec Leamas wrote:
> Hi again,
> 
> On 24/09/2020 09:07, Alec Leamas wrote:
> > 
> >> "/usr/lib/i386-linux-gnu/pkgconfig"
> 
> > I have made a new upload, only changing the last reference. Will make a
> > comment on mentors once it's ready.
> > 
> >> However it builds fine even after changing it, so I presume this DPKGCONFIGDIR is just not used...
> > 
> > 
> > It's  minor mess, basically about the first patch which is too
> > heavy-handed.
> > 
> > I have made a new patch series for the build files which I will try to
> > upstream. 

Yeah, had the same thoughts about the build system… (My bikeshed color'd be to
use ctest, as they are using cmake already, this feels like a good match)

> > The idea is to use it in next release, whether accepted or
> > not. However, this is a major change which we should probably avoid at
> > this point, just clearing the 1386 issue.

Agree.


> The new version is available on mentors (#3).

Confirmed, it is building. It builds now and the pkconfig file looks also ok.
(* on a freshly updated i386 pbuilder env)

(Looking at the -dev package: they use a quite common filename (serial.h)
without subdirectory in /usr/include. I wonder if there are collisions
in the archvie…)

> I have considered using 'make -C obj-*' instead of 'make -C
> obj-$(DEB_HOST_GNU_TYPE)'. It's simpler, but perhaps too simple (?)

Could work, as we're not building for multiple archs at the same time…

- Typo in d/changelog: s/FTBS/FTBFS/
- Please add the patch I sent in #970712#39…

-- tobi

[toc] | [prev] | [next] | [standalone]

#1026277

On 24/09/2020 10:34, Tobias Frost wrote:
> Control: tags -1 moreinfo
> Control: reopen -1 
> 
> On Thu, Sep 24, 2020 at 09:29:58AM +0200, Alec Leamas wrote:
>> Hi again,
>>
>> On 24/09/2020 09:07, Alec Leamas wrote:


> (Looking at the -dev package: they use a quite common filename (serial.h)
> without subdirectory in /usr/include. I wonder if there are collisions
> in the archvie…)


If not, it would be because other packages are sane. This one is
certainly not in this sense. Needs to be fixed (see below)


> - Typo in d/changelog: s/FTBS/FTBFS/

Fixed. That was actually no typo, for some reason I have always used
FTBS although it's obviously wrong.


> - Please add the patch I sent in #970712#39…

/me wants back to Fedora, where the only way to change a package is a
commit in the dist-git repo. NMUs and free-running patches, I miss them
 all. OTOH, now I have now  learnt and it will never happen again. "cough"

New package on mentors: #4, timestamp:2020-09-24 11:08

There is a need for a bigger rewrite:
  - Refactor the cmake patch(es)
  - Add a doc subpackage.
  - Don't install serial.h directly under /usr/include.

Please feel free to file a bug or two; I'm on it anyway (although
perhaps not exact now).

Cheers!
--alec

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web