Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1024180 > unrolled thread

Bug#969762: warn about invalid field names in debian/upstream/metadata

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#969762: warn about invalid field names in debian/upstream/metadata Jelmer Vernooij <jelmer@debian.org> - 2020-09-08 00:10 +0200
    Bug#969762: warn about invalid field names in debian/upstream/metadata Felix Lechner <felix.lechner@lease-up.com> - 2020-09-08 04:10 +0200
      Bug#969762: warn about invalid field names in debian/upstream/metadata Jelmer Vernooij <jelmer@debian.org> - 2020-09-09 00:00 +0200

#1024180 — Bug#969762: warn about invalid field names in debian/upstream/metadata

Package: lintian
Version: 2.93.0
Severity: wishlist
User: lintian-brush@packages.debian.org
Usertags: fixer-signal

lintian currently warns about invalid field names in DEP5 debian/copyright files
and e.g. debian/control; it would be great if it could do the same for
debian/upstream/metadata.

(lintian-brush can use this as a signal to fix typos in field names)

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-1-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                        2.35-2
ii  bzip2                           1.0.8-4
ii  diffstat                        1.63-1
ii  dpkg                            1.20.5
ii  dpkg-dev                        1.20.5
ii  file                            1:5.38-5
ii  gettext                         0.19.8.1-10
ii  gpg                             2.2.20-1
ii  intltool-debian                 0.35.0+20060710.5
ii  libapt-pkg-perl                 0.1.36+b3
ii  libarchive-zip-perl             1.68-1
ii  libcapture-tiny-perl            0.48-1
ii  libclass-xsaccessor-perl        1.19-3+b5
ii  libclone-perl                   0.45-1
ii  libconfig-tiny-perl             2.24-1
ii  libcpanel-json-xs-perl          4.23-1
ii  libdata-dpath-perl              0.58-1
ii  libdata-validate-domain-perl    0.10-1
ii  libdevel-size-perl              0.83-1+b1
ii  libdpkg-perl                    1.20.5
ii  libemail-address-xs-perl        1.04-1+b2
ii  libfile-basedir-perl            0.08-1
ii  libfile-find-rule-perl          0.34-1
ii  libfont-ttf-perl                1.06-1
ii  libhtml-html5-entities-perl     0.004-1
ii  libipc-run3-perl                0.048-2
ii  libjson-maybexs-perl            1.004002-1
ii  liblist-compare-perl            0.55-1
ii  liblist-moreutils-perl          0.416-1+b5
ii  liblist-utilsby-perl            0.11-1
ii  libmoo-perl                     2.004000-1
ii  libmoox-aliases-perl            0.001006-1
ii  libnamespace-clean-perl         0.27-1
ii  libpath-tiny-perl               0.114-1
ii  libperlio-gzip-perl             0.19-1+b6
ii  libproc-processtable-perl       0.59-2
ii  libsereal-decoder-perl          4.018+ds-1
ii  libsereal-encoder-perl          4.018+ds-1
ii  libtext-glob-perl               0.11-1
ii  libtext-levenshteinxs-perl      0.03-4+b7
ii  libtext-markdown-discount-perl  0.12-1
ii  libtext-xslate-perl             3.5.8-1
ii  libtime-duration-perl           1.21-1
ii  libtime-moment-perl             0.44-1+b2
ii  libtimedate-perl                2.3300-1
ii  libtry-tiny-perl                0.30-1
ii  libtype-tiny-perl               1.010005-1
ii  libunicode-utf8-perl            0.62-1+b1
ii  liburi-perl                     1.76-2
ii  libxml-libxml-perl              2.0134+dfsg-2
ii  libyaml-libyaml-perl            0.82+repack-1
ii  lzip                            1.21-8
ii  lzop                            1.04-1
ii  man-db                          2.9.3-2
ii  patchutils                      0.4.2-1
ii  perl [libdigest-sha-perl]       5.30.3-4
ii  t1utils                         1.41-4
ii  unzip                           6.0-25
ii  xz-utils                        5.2.4-1+b1

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libtext-template-perl  1.59-1

-- no debconf information

[toc] | [next] | [standalone]

#1024206

Hi Jelmer,

> lintian-brush can use this as a signal to fix typos in field names

I'll try to track down a list of valid names and will happily implement it.

In a pinch, you could even do it yourself. The tag
upstream-metadata-field-present [1], which as a classification tag is
not shown for packages on the website but is available in UDD, gives
you the verbatim field names found. Like me, you just need a list of
valid names to determine those that are bogus. They are already only
one SQL query away!

It is what happens when Lintian provides its scanning results to the
world, as discussed in your other Bug#969769.

Kind regards
Felix Lechner

[1] https://lintian.debian.org/tags/upstream-metadata-field-present.html

[toc] | [prev] | [next] | [standalone]

#1024324

On Mon, Sep 07, 2020 at 06:56:08PM -0700, Felix Lechner wrote:
> > lintian-brush can use this as a signal to fix typos in field names
> 
> I'll try to track down a list of valid names and will happily implement it.
There's a list in the specification at https://wiki.debian.org/UpstreamMetadata

> In a pinch, you could even do it yourself. The tag
> upstream-metadata-field-present [1], which as a classification tag is
> not shown for packages on the website but is available in UDD, gives
> you the verbatim field names found. Like me, you just need a list of
> valid names to determine those that are bogus. They are already only
> one SQL query away!
The classifications are super useful, and having them in UDD is
especially great for finding information about packages across the
archive, e.g. "which packages use a Vcs-Browse URL that's not on
HTTP/HTTPS?"

There is a lot of value in keeping the business logic for finding
problems (in this case, to determine invalid field names) in lintian
rather than just having it bubble up raw data, i.e. as the arbiter of
what is right or wrong:

 * the business logic for finding a problem is only in a single place
 * lintian-brush is opportunistic and only goes after issues
   that it can fix. it's valuable that humans get told about
   all problems so they can fix those things that need manual
   operation
 * it allows lintian to be used to verify that an issue has been fixed
   after lintian-brush has been run

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer@jelmer.uk>
PGP Key: https://www.jelmer.uk/D729A457.asc

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web