Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1007938 > unrolled thread

Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature Seunghun Han <kkamagui@gmail.com> - 2020-05-04 11:00 +0200
    Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature Boyuan Yang <byang@debian.org> - 2020-05-04 23:40 +0200
      Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature Seunghun Han <kkamagui@gmail.com> - 2020-05-05 03:10 +0200
        Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature Boyuan Yang <byang@debian.org> - 2020-05-05 04:40 +0200
          Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature Seunghun Han <kkamagui@gmail.com> - 2020-05-05 12:30 +0200

#1007938 — Bug#959702: RFS: cpufrequtils/008-2 [ITA] -- utilities to deal with the cpufreq Linux kernel feature

[Multipart message — attachments visible in raw view] — view raw

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "cpufrequtils"

 * Package name    : cpufrequtils
   Version         : 008-2
   Upstream Author : Dominik Brodowski <linux@dominikbrodowski.de>
 * URL             :
http://kernel.org/pub/linux/utils/kernel/cpufreq/cpufrequtils.html
 * License         : GPL-2
 * Vcs             : https://salsa.debian.org/kkamagui-guest/cpufrequtils
   Section         : admin

It builds those binary packages:

  cpufrequtils - utilities to deal with the cpufreq Linux kernel feature
  libcpufreq0 - shared library to deal with the cpufreq Linux kernel feature
  libcpufreq-dev - development files to deal with the cpufreq Linux
kernel feature

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/cpufrequtils

Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/c/cpufrequtils/cpufrequtils_008-2.dsc

Changes since the last upload:

   * New maintainer (Closes: #933159)
   * Add "for internal use" to debian/cpufrequtils.templates to fix
     lintian warning.
   * Bump Standards-Version to 4.5.0.
   * Remove -O2 of CFLAGS from debian/rules when noopt is defined.
   * Add hardening+=all to debian/rules and set-hardening.patch.
   * Add Vcs-* fields to debian/control.
   * Add Build-Depends-Package field to debian/libcpufreq0.symbols.
   * Change the format of debian/copyright to dep5.
   * Fix tyops in man files.
   * Remove debian/source.lintian-overrides to fix lintian warning.

Regards,

--
  Seunghun Han

[toc] | [next] | [standalone]

#1008059

[Multipart message — attachments visible in raw view] — view raw

Hi Seunghun,

(see comments inline below)

在 2020-05-04星期一的 17:51 +0900，Seunghun Han写道：
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "cpufrequtils"
> 
>  * Package name    : cpufrequtils
>    Version         : 008-2
>    Upstream Author : Dominik Brodowski <linux@dominikbrodowski.de>
>  * URL             : 
> http://kernel.org/pub/linux/utils/kernel/cpufreq/cpufrequtils.html
>  * License         : GPL-2
>  * Vcs             : https://salsa.debian.org/kkamagui-guest/cpufrequtils
>    Section         : admin
> 
> It builds those binary packages:
> 
>   cpufrequtils - utilities to deal with the cpufreq Linux kernel feature
>   libcpufreq0 - shared library to deal with the cpufreq Linux kernel feature
>   libcpufreq-dev - development files to deal with the cpufreq Linux kernel
> feature
> 
> To access further information about this package, please visit the following
> URL:
> 
>   https://mentors.debian.net/package/cpufrequtils
> 
> Alternatively, one can download the package with dget using this command:
> 
>   dget -x 
> https://mentors.debian.net/debian/pool/main/c/cpufrequtils/cpufrequtils_008-2.dsc
> 
> Changes since the last upload:
> 
>    * New maintainer (Closes: #933159)
>    * Add "for internal use" to debian/cpufrequtils.templates to fix
>      lintian warning.
>    * Bump Standards-Version to 4.5.0.
>    * Remove -O2 of CFLAGS from debian/rules when noopt is defined.
>    * Add hardening+=all to debian/rules and set-hardening.patch.
>    * Add Vcs-* fields to debian/control.

Are you interested putting the git packaging repo under
salsa.debian.org/debian/ instead of your personal namespace? In this case,
other Debian Developers (DD) will have write access to this repo. If you find
it okay, I can help to create such repo under Salsa Debian group.

>    * Add Build-Depends-Package field to debian/libcpufreq0.symbols.
>    * Change the format of debian/copyright to dep5.
>    * Fix tyops in man files.

^^^^ This line itself contains a typo :-(

>    * Remove debian/source.lintian-overrides to fix lintian warning.

* For the "Source" field in debian/copyright: please consider using https
instead of http.

* Ever considered using debhelper compat level v13?


Those are all just nitpicks; I can sponsor this upload after your reply (and
ideally a new upload onto mentors.d.n).

-- 
Best,
Boyuan Yang

[toc] | [prev] | [next] | [standalone]

#1008073

Hi Boyuan,

Thank you for your advice. Please see comments below.

On Tue, May 5, 2020 at 6:33 AM Boyuan Yang <byang@debian.org> wrote:
>
> [..snip..]
> Are you interested putting the git packaging repo under
> salsa.debian.org/debian/ instead of your personal namespace? In this case,
> other Debian Developers (DD) will have write access to this repo. If you find
> it okay, I can help to create such repo under Salsa Debian group.
>

Thank you for your suggestion. It's good for me. Is there any way to
have write access for it? In my case, I joined the Webml team as a
developer and had write access [1].

> >    * Add Build-Depends-Package field to debian/libcpufreq0.symbols.
> >    * Change the format of debian/copyright to dep5.
> >    * Fix tyops in man files.
>
> ^^^^ This line itself contains a typo :-(

Thank you. I fixed it on your advice. :-)

> >    * Remove debian/source.lintian-overrides to fix lintian warning.
>
> * For the "Source" field in debian/copyright: please consider using https
> instead of http.
>
> * Ever considered using debhelper compat level v13?
>
> Those are all just nitpicks; I can sponsor this upload after your reply (and
> ideally a new upload onto mentors.d.n).

I also fixed them and uploaded the package again. Please sponsor it.
I always appreciate your help.

Best regards,

Seunghun

[1] https://salsa.debian.org/webmaster-team/webwml/-/project_members?utf8=%E2%9C%93&search=seunghun

[toc] | [prev] | [next] | [standalone]

#1008079

[Multipart message — attachments visible in raw view] — view raw

Hi Seunghun,

在 2020-05-05星期二的 10:02 +0900，Seunghun Han写道：
> Hi Boyuan,
> 
> Thank you for your advice. Please see comments below.
> 
> On Tue, May 5, 2020 at 6:33 AM Boyuan Yang <byang@debian.org> wrote:
> > [..snip..]
> > Are you interested putting the git packaging repo under
> > salsa.debian.org/debian/ instead of your personal namespace? In this case,
> > other Debian Developers (DD) will have write access to this repo. If you
> > find
> > it okay, I can help to create such repo under Salsa Debian group.
> > 
> 
> Thank you for your suggestion. It's good for me. Is there any way to
> have write access for it? In my case, I joined the Webml team as a
> developer and had write access [1].

The members of salsa.debian.org/debian group are limited to DDs (Debian
Developers). However, it is possible to add you as the maintainer of
individual repos under Debian/ group. I have already added you as a maintainer
of https://salsa.debian.org/debian/cpufrequtils .

> hose are all just nitpicks; I can sponsor this upload after your reply (and
> > > > 
> 
> I also fixed them and uploaded the package again. Please sponsor it.
> I always appreciate your help.

As part of mentoring, I reviewed your files in the git repo and found some
other issues:

* You accidentally committed files under debian/cpufrequtils into the
repository. Those files are built binary files instead of source codes and
should not be included.
  - This also indicates that you are using a non-chroot environment to build
packages. Please consider using clean chroot each time doing a package build,
like pbuilder, cowbuilder, git-builder, sbuild, etc.

* In architecture field of package cpufrequtils, it lists "hurd", "kbsd64" and
"kbsd32", which does not exist in Debian. Please correct it. (I know it could
be a bug in older versions but we should be fixing it once we know it.)

* You may now use https://salsa.debian.org/debian/cpufrequtils in Vcs-*
fields.

* I'm not sure if debian/lintian.overrides will work. 
https://manpages.debian.org/unstable/lintian/lintian.1.en.html#FILES mentioned
correct naming about lintian override files.

After solving those problems, I will sponsor this package.


Some bonus points that can be done laster in future:

* Consider converting debian/rules to be using dh(1) sequencer later.

-- 
Regards,
Boyuan Yang

[toc] | [prev] | [next] | [standalone]

#1008121

Hi Boyuan,

Thank you for your advice. I have fixed all issues you said. Please
see the comments below.

On Tue, May 5, 2020 at 11:37 AM Boyuan Yang <byang@debian.org> wrote:
>
> The members of salsa.debian.org/debian group are limited to DDs (Debian
> Developers). However, it is possible to add you as the maintainer of
> individual repos under Debian/ group. I have already added you as a maintainer
> of https://salsa.debian.org/debian/cpufrequtils .
>

I really appreciate it. After your confirmation and sponsor, I will
move all contents to the repository. The debian/control was already
changed to the repo.

> As part of mentoring, I reviewed your files in the git repo and found some
> other issues:
>
> * You accidentally committed files under debian/cpufrequtils into the
> repository. Those files are built binary files instead of source codes and
> should not be included.
>   - This also indicates that you are using a non-chroot environment to build
> packages. Please consider using clean chroot each time doing a package build,
> like pbuilder, cowbuilder, git-builder, sbuild, etc.

Sorry for my mistake. It was my fault, and I didn't intend to add the
binary files. I will use the pbuilder for avoiding this kind of
mistake.

> * In architecture field of package cpufrequtils, it lists "hurd", "kbsd64" and
> "kbsd32", which does not exist in Debian. Please correct it. (I know it could
> be a bug in older versions but we should be fixing it once we know it.)
>
> * You may now use https://salsa.debian.org/debian/cpufrequtils in Vcs-*
> fields.

I fixed these issues with your advice.

> * I'm not sure if debian/lintian.overrides will work.
> https://manpages.debian.org/unstable/lintian/lintian.1.en.html#FILES mentioned
> correct naming about lintian override files.
>
> After solving those problems, I will sponsor this package.

According to my lintian report, debian/lintian.overrides seemed to
work. The brief report is below.
$> lintian -i -I --pedantic cpufrequtils_008-2_amd64.changes
[... snip ...]
N: 1 tag overridden (1 error)     <= Maybe this point shows it works

> Some bonus points that can be done laster in future:
>
> * Consider converting debian/rules to be using dh(1) sequencer later.

Thank you. I will keep this for the next item.

Best regards,

Seunghun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web