Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #743095

Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP]

Show all headers | View raw

On 02/06/16 05:33, lumin wrote:
> On Thu, 2016-05-26 at 14:32 +0100, Ghislain Vaillant wrote:
>
>> I don't agree. Regarding the testsuite, I believe most features should
>> be tested at package build time, including the Python stuff. We want to
>> fail early if something goes wrong. To me, the autopkgtest testsuite
>> serves a different purpose, i.e. to test that an update in the install
>> requirements does not break the currently uploaded package.
>
> Isn't that done by piuparts? confused.
> And yes I should also write a python tester script.

No [1].

The build time testsuite, autopkgtest and piuparts serve different
purposes. You might want to spend some time reading a bit more about
those, as the distinction is quite important from a maintainer's point-
of-view.

[1] https://wiki.debian.org/piuparts

>> So yes, the Python runtime dependencies should be part of Build-Depends
>> and the Python testsuite should be called during the build.
>
> I'll add them later.

Good.

>>  From my experience using caffe at the lab, the Python interface is what
>> people are mainly using. So IMO, it would be quite a let down if the
>> caffe were uploaded without Python support.
>>
>> IMO, it should be either Python 3 alone or Python 2 + 3. I made this
>> mistake when packaging OpenGM and regret it now. I'll repeat it here,
>> Python 2 has an expiration date and we should encourage people to use
>> Python 3.
>
> Let's make python3-caffe-* and let it be python3-only.

Good.

>> I did not follow all the recent action on the packaging, but why are we
>> still using templated install.in files instead of patching the build
>> system for the great of the rest of the Linux community?
>
> I indeed made all suggested changes including using `GNUInstallDirs`
> to avoid template generation. Currently the *.in files are mostly
> fake template (nothing to be replaced) but only
> libcaffe-cpu-dev.install.in is the real one. I need to match
> a library install directory in this file, which is the only
> remaining template.
>
> Oh yes I should rename those non-template files.
> :-)

Don't forget to forward the patch upstream please.

> BTW, I tested the python3 build and I found that, the python3
> version can be built without python3-protobuf, and the compilation
> will not crash. Python3 module will be generated but when trying
> to import caffe in python3 it will end up with something like:
>
> error import google.protobuf
>
> That is to say python3-protobuf is not a build-dep but a runtime-dep
> for the python3 interface.

It is explicitly listed in the requirements [2], so no surprise here.
Since you intend to run the Python testsuite at build time, you will
probably need all these dependencies translated to Build-Depends.

[2] https://github.com/BVLC/caffe/blob/master/python/requirements.txt

Ghis

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP] Gianfranco Costamagna <locutusofborg@debian.org> - 2016-05-23 10:30 +0200
  Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP] Ghislain Vaillant <ghisvail@gmail.com> - 2016-05-26 15:40 +0200
    Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP] lumin <cdluminate@gmail.com> - 2016-06-02 06:40 +0200
      Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP] Ghislain Vaillant <ghisvail@gmail.com> - 2016-06-02 09:10 +0200
        Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP] Mo Zhou <cdluminate@gmail.com> - 2016-06-03 13:50 +0200

csiph-web