Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1312078

Bug#1117986: wsdd: Warning about a truthiness test, line 649

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,  

  

I'm a new contributor who picked this bug as a starter task and verified the
fix against the current sid source (wsdd 2:0.8-5). I'm sharing what I learned
rather than another copy of the patch, including one correction that may save
whoever commits this some confusion. Verification (test-first):  

  

\- I wrote a small reproduction that calls WSDDiscoveredDevice.update() with
crafted WSD metadata under Python 3.13 using -W error::DeprecationWarning:
pristine 0.8 fails with exactly the warning quoted in this report
(src/wsdd.py:649) and passes after the one-line change `if (host_sec):` -> `if
(host_sec is not None):`. Host property extraction still works, both for a
Relationship section containing wsdp:Host and for one without it.  

\- Wrapped as a quilt patch with DEP-3 headers, the change applies to pristine
0.8 with no fuzz or offsets, and dpkg-source -b builds a 2:0.8-6 source
package that extracts cleanly and passes the same test.  

  

Correction to the upstream reference:  

  

The patch sent to this bug earlier this year cites:  

  

Origin: upstream,
<https://github.com/christgau/wsdd/commit/1a532e3ee12c92e4a8d3d6104a23bca0656a2f27>  

  

That hash does not exist in the upstream repository (the URL returns 404). The
actual upstream commit is:  

  

1a532e3ee12c92e4a83d6104a23bcad0656a2f27  

chore(src): Address xml deprecation working (#210)  

Alessandro Astone <[ales.astone@gmail.com](mailto:ales.astone@gmail.com)>,
2024-10-03  

<https://github.com/christgau/wsdd/commit/1a532e3ee12c92e4a83d6104a23bcad0656a2f27>  

  

(first released in v0.9, confirmed to be in the v0.8...v0.9 range). The diff
in the earlier patch itself matches the real upstream change byte for byte, so
only the hash in the provenance reference needs correcting.  

  

For completeness: salsa MRs !7 and !8 on grantma/wsdd also carry this fix.  

  

research conducted using AI.  

  

  

BR,  

Adrian Alan

  

StartMail makes private and encrypted email easy. [Try it here for
free](https://www.startmail.com/)!  

Back to linux.debian.bugs.dist | Previous | Next | Find similar | Unroll thread

Thread

Bug#1117986: wsdd: Warning about a truthiness test, line 649 adrianalan@use.startmail.com - 2026-10-05 17:40 +0200

csiph-web