Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1294534

Bug#1136896: Patch review

Show all headers | View raw

Control: tags -1 + upstream confirmed

Hi Daniel,

Thanks for the investigation and the patch.

I won't proclaim to be a C memory expert, and I'm not comfortable 
applying this patch as-is without being reviewed by a more experienced 
dev.

I agree with the uninitialised pollfd concern you identified.  However, 
based on my read of the docs, I am concerned that if realloc returns 
NULL, then the next memset statement is "undefined" (i.e. probably a 
segfault).

Could I ask that you raise this directly upstream?
https://savannah.gnu.org/bugs/?group=screen&func=additem

Thanks again for digging into this.

Cheers,
Peter Dey

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Bug#1136896: screen: uninitialized use of pollfd structs Daniel Serpell <daniel.serpell@gmail.com> - 2026-05-17 06:20 +0200
  Bug#1136896: Patch review Peter Dey <debian@realmtech.net> - 2026-05-20 22:00 +0200

csiph-web