Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1232011

Bug#1095263: cloop-src: module fails to build for Linux 6.1: error: ‘struct request’ has no member named ‘rq_disk’

Show all headers | View raw

tags 1095263 + help
thanks

Hallo,
* Andreas Beckmann [Thu, Feb 06 2025, 03:00:26AM]:
> Package: cloop-src
> Version: 3.14.1.3+nmu1
> Severity: serious
>
> cloop-src fails to build a module for Linux 6.1 in bookworm
> (and of course also for 6.12 in trixie).

Yes. I tried to add latest API adjustments but it is still failing.
Currently pushed to https://github.com/Code7R/cloop/tree/bugfix/linux_IO_API_adjustments
but it is still not working with kernel versions beyond 6.7 or so.

I am strugling with the queue limit setup API changes which happened
somewhere between 6.8 and 6.10, and it's not trivial.

If there is real interest in keeping this package alive, I would
probably ask for help later.

> The attached patch adds an autopkgtest that tries to compile the module
> s.t. such breakage can be detected more quickly in the future.

Okay.

> Shouldn't this package have a corresponding -dkms package?

Maybe, but IMHO there is not much public interest in that kernel module
except for very specialized Live Linux distros, i.e. I cannot remember
anyone reporting this wish.

@Klaus: do we actually need cloop nowadays? It is an isolated project,
and there is at least one alternative called squashfs, which is
apparently well maintained and supports modern compression (Zstandard).

> Building for Kernel Patchlevel 6
> /usr/bin/make modules -C /lib/modules/6.1.0-29-amd64/build M=/usr/src/modules/cloop
> make[3]: Entering directory '/usr/src/linux-headers-6.1.0-29-amd64'
>   CC [M]  /usr/src/modules/cloop/cloop.o
> /usr/src/modules/cloop/cloop.c: In function ‘cloop_queue_rq’:
> /usr/src/modules/cloop/cloop.c:471:32: error: ‘struct request’ has no member named ‘rq_disk’
>   471 |  struct cloop_device *clo = req->rq_disk->private_data;
>       |                                ^~
> /usr/src/modules/cloop/cloop.c: In function ‘cloop_alloc’:
> /usr/src/modules/cloop/cloop.c:1175:2: error: implicit declaration of function ‘blk_cleanup_disk’; did you mean ‘blk_alloc_disk’? [-Werror=implicit-function-declaration]
>  1175 |  blk_cleanup_disk(clo->clo_disk);
>       |  ^~~~~~~~~~~~~~~~
>       |  blk_alloc_disk
> cc1: some warnings being treated as errors

That was the easy part, the bitter pill is around
https://github.com/Code7R/cloop/blob/bugfix/linux_IO_API_adjustments/cloop.c#L1187
which probably needs more than a call there. Just judging by what ZFS
people had to change last year, i.e. https://github.com/openzfs/zfs/commit/b409892ae5028965a6fe98dde1346594807e6e45 .

Repro like: make module KERNEL_DIR=/usr/src/linux  KVERSION=6.13.0-rc4+

Best regards,
Eduard.

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Bug#1095263: cloop-src: module fails to build for Linux 6.1: error: ‘struct request’ has no member named ‘rq_disk’ Andreas Beckmann <anbe@debian.org> - 2025-02-06 03:10 +0100
  Bug#1095263: cloop-src: module fails to build for Linux 6.1: error: ‘struct request’ has no member named ‘rq_disk’ Eduard Bloch <edi@gmx.de> - 2025-02-06 17:30 +0100

csiph-web