Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1090318

Bug#1002532: pygments breaks ruby-pygments.rb autopkgtest: UTF-8 != ASCII-8BIT

Show all headers | View raw

On Thu, 20 Jan 2022 18:50:33 +0100 Mattia Rizzolo <mattia@debian.org> wrote:
> Hi Alex,
>
> On Thu, Jan 06, 2022 at 11:19:00AM +0100, Alexandre Ghiti wrote:
> > As the current version we have is from 2017, I bumped the version of
> > this package to the latest available version: I updated the patches,
> > removed the ones that do not apply anymore, updated the build system
> > and dependencies. The result is available in my PPA [2] and fixes the
> > issue we encounter here.
> >
> > Can you consider pulling this?
>
> Thank you for this!!
>
>
> I had a look at your work, however I couldn't help but notice that:
> * the .orig you used looks odd, much larger than what I get from uscan
> (despite yours is also using a different compression, so repacked).

I used 'git archive' directly, I did not know about uscan (thank you
and Graham).

> * You did a ton of patch wrangling, including deletion, renaming,
> rebasing, etc. which is all fine, except that the way you did it
> obscures quite a bit what you did. Why did you drop the numbers from
> the patches? Do you have --no-patch-numbers as you gbp-pq default or
> something?

I changed the patches names since they were different: I fixed that in
my coming MR. Thanks for gbp that I did not know neither.

> * why requiring gem2deb >=1 ? that's already in bullseye as well in
> focal, so why did you feel the need to add the version? (that's also
> not in the changelog)

I simply copied the debian/ directory from the previous version that I
got from pull-lp-source, I did not use git...I'll use git in the
future, thanks.

>
> As such, I went ahead and re-imported the repacked origin I got myself
> in git.
> Could I ask you to submit a MR on top of it, with at least commits
> separating the deletion, refresh and rebasing of patches (and eventual
> new ones, I can't tell at a glance if any new patch appeared…) also
> separated.
> https://salsa.debian.org/ruby-team/ruby-pygments.rb

It's on its way :)

>
> Thank you for your work!! :)

Thank you for your remarks (and thanks Graham for his help ;))

Alex

>
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
> More about me: https://mapreri.org : :' :
> Launchpad user: https://launchpad.net/~mapreri `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia `-

Back to linux.debian.bugs.dist | Previous | Next | Find similar | Unroll thread

Thread

Bug#1002532: pygments breaks ruby-pygments.rb autopkgtest: UTF-8 != ASCII-8BIT Alexandre Ghiti <alexandre.ghiti@canonical.com> - 2022-01-21 12:20 +0100

csiph-web