Groups > linux.debian.bugs.dist > #1069168

Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed.

From	dann frazier <dannf@dannf.org>
Newsgroups	linux.debian.bugs.dist
Subject	Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed.
Date	2021-08-31 17:10 +0200
Message-ID	<CSdyF-5mn-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <CRWob-1ZG-23@gated-at.bofh.it> <CRX0T-2HW-21@gated-at.bofh.it> <CRXNf-3h9-9@gated-at.bofh.it> <CQQEa-1Eu-17@gated-at.bofh.it> <CRXNf-3h9-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 31, 2021 at 01:13:40AM +0300, Michael Tokarev wrote:
> dann, can you please add a printf to util/qemu-sockets.c
> before the assert() which is failing, to see what's the
> value of salen? since you can reproduce this..
> I'm still not 100% sure what the actual problem is -
> or _which_ problem it is in particular.
> 
> It is either one byte too large (for the trailing \0)
> or one byte too small (with zero-length sun_path).
> 
> Like this:
> 
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index f2f3676d1f..89a405476a 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -1345,6 +1345,10 @@ socket_sockaddr_to_address_unix(struct sockaddr_storage *sa,
>      SocketAddress *addr;
>      struct sockaddr_un *su = (struct sockaddr_un *)sa;
> 
> +if(!(salen >= sizeof(su->sun_family) + 1 &&
> +           salen <= sizeof(struct sockaddr_un)))
> +  fprintf(stderr, "about to fire assert: salen=%d\n", salen);
> +
>      assert(salen >= sizeof(su->sun_family) + 1 &&
>             salen <= sizeof(struct sockaddr_un));

char device redirected to /dev/pts/14 (label charserial0)
about to fire assert: salen=2
qemu-system-x86_64: ../../util/qemu-sockets.c:1352: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed.
2021-08-31 15:01:18.082+0000: shutting down, reason=crashed

Thread

Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. dann frazier <dannf@dannf.org> - 2021-08-27 22:30 +0200
  Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. Michael Tokarev <mjt@tls.msk.ru> - 2021-08-28 14:00 +0200
    Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348:  socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) +  1 && salen <= sizeof(struct sockaddr_un)' failed. Günter Frenz <guefz@guefz.de> - 2021-08-30 20:50 +0200
      Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348:   socket_sockaddr_to_address_unix: Assertion `salen >=  sizeof(su->sun_family) +  1 && salen <= sizeof(struct sockaddr_un)' failed. Günter Frenz <guefz@guefz.de> - 2021-08-30 21:10 +0200
      Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. Michael Tokarev <mjt@tls.msk.ru> - 2021-08-30 21:30 +0200
        Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. Michael Tokarev <mjt@tls.msk.ru> - 2021-08-30 21:40 +0200
          Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. Michael Tokarev <mjt@tls.msk.ru> - 2021-08-30 22:10 +0200
    Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. dann frazier <dannf@dannf.org> - 2021-08-30 22:50 +0200
      Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. dann frazier <dannf@dannf.org> - 2021-08-30 23:30 +0200
        Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. Michael Tokarev <mjt@tls.msk.ru> - 2021-08-31 00:20 +0200
          Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. dann frazier <dannf@dannf.org> - 2021-08-31 01:30 +0200
          Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. dann frazier <dannf@dannf.org> - 2021-08-31 17:10 +0200
            Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. Michael Tokarev <mjt@tls.msk.ru> - 2021-08-31 21:10 +0200
              Bug#993145: qemu-system-x86_64: ../../util/qemu-sockets.c:1348: socket_sockaddr_to_address_unix: Assertion `salen >= sizeof(su->sun_family) + 1 && salen <= sizeof(struct sockaddr_un)' failed. dann frazier <dannf@dannf.org> - 2021-09-01 23:30 +0200
  Bug#993145: 1:6.1+dfsg-3 update dann frazier <dannf@dannf.org> - 2021-08-31 18:30 +0200
    Bug#993145: 1:6.1+dfsg-3 update Michael Tokarev <mjt@tls.msk.ru> - 2021-08-31 19:20 +0200

csiph-web