Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1020353

Bug#966923: meson: 0.55.0 considers TAP "ok # SKIP" to be a failure

From Simon McVittie <smcv@debian.org>
Newsgroups linux.debian.bugs.dist
Subject Bug#966923: meson: 0.55.0 considers TAP "ok # SKIP" to be a failure
Date 2020-08-03 13:20 +0200
Message-ID <AzGFz-2lw-3@gated-at.bofh.it> (permalink)
References <AzEDO-18f-47@gated-at.bofh.it> <AzEDO-18f-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Control: retitle -1 meson: 0.55.0 considers TAP "ok # SKIP" to be a failure
Control: reassign -1 meson 0.55.0-2
Control: affects -1 + gjs
Control: forwarded -1 https://github.com/mesonbuild/meson/issues/7515
Control: tags -1 + upstream

On Mon, 03 Aug 2020 at 10:51:25 +0200, Lucas Nussbaum wrote:
> Relevant part (hopefully):
...
> > meson test -C /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu --timeout-multiplier 4
...
> > 10/53 gjs:JS / GIMarshalling            FAIL           0.22s (exit status 0)
...
> > 27/53 gjs:JS / Regress                  FAIL           0.17s (exit status 0)
...
> > 33/53 gjs:JS / Gtk3                     FAIL           0.22s (exit status 0)

What is happening here was obscured by gjs not printing the output of
failing tests to the buildd log, but if you apply the attached gjs.diff,
you can see that the affected tests are those that have some steps that
are skipped.

Reproducer:

$ cat meson.build
project('debian-bug-966923')
foreach test_name : ['pass.sh', 'skip.sh']
  test(test_name, files(test_name), protocol : 'tap')
endforeach
$ cat pass.sh
#!/bin/sh
echo "ok 1"
echo "ok 2"
exit 0
$ cat skip.sh
#!/bin/sh
echo "ok 1 # SKIP cannot actually do this"
echo "ok 2"
exit 0
$ chmod +x pass.sh skip.sh
$ meson _build
$ meson test -C _build

Regards,
    smcv

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Bug#966923: gjs: FTBFS: tests failed Lucas Nussbaum <lucas@debian.org> - 2020-08-03 11:10 +0200
  Bug#966923: meson: 0.55.0 considers TAP "ok # SKIP" to be a failure Simon McVittie <smcv@debian.org> - 2020-08-03 13:20 +0200
  Bug#966923: meson: diff for NMU version 0.55.0-2.1 Iain Lane <iain@orangesquash.org.uk> - 2020-08-20 20:00 +0200

csiph-web