Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #78151 > unrolled thread

Re: Love to get some feedback on my first python app!!!

Started byJean-Michel Pichavant <jeanmichel@sequans.com>
First post2014-09-22 16:32 +0200
Last post2014-09-22 15:23 +0000
Articles 2 — 2 participants

Back to article view | Back to comp.lang.python


Contents

  Re: Love to get some feedback on my first python app!!! Jean-Michel Pichavant <jeanmichel@sequans.com> - 2014-09-22 16:32 +0200
    Re: Love to get some feedback on my first python app!!! alister <alister.nospam.ware@ntlworld.com> - 2014-09-22 15:23 +0000

#78151 — Re: Love to get some feedback on my first python app!!!

FromJean-Michel Pichavant <jeanmichel@sequans.com>
Date2014-09-22 16:32 +0200
SubjectRe: Love to get some feedback on my first python app!!!
Message-ID<mailman.14207.1411396348.18130.python-list@python.org>
----- Original Message -----
> From: "Chris Angelico" <rosuav@gmail.com>
> Cc: python-list@python.org
> Sent: Saturday, 20 September, 2014 4:58:44 PM
> Subject: Re: Love to get some feedback on my first python app!!!
[snip]
> 
>     #search API
>     rawData =
>     urllib.urlopen('http://ajax.googleapis.com/ajax/services/search/web?v=1.0&q='+encodedQuery).read()
>     #loads data from API into json
>     jsonData = json.loads(rawData)
>     #extracts the results from API
>     searchResults = jsonData['responseData']['results']
> 
> The more normal way to write these would be in present tense, in a
> more imperative style: "Fix some bugs", "Load data", "Extract
> results". (Although these comments are actually quite redundant - all
> they do is tell you what the single next line of code does.) 

I used to belong to the cult "don't repeat yourself" in the comments, being angry against people who thought I couldn't understand by myself the simplest line of code.

But I changed my mind. I've read some code comments over the years and best ones (imo) where those which where actually repeating themselves.
Golden rules of comments:

# state what you plan to do
doIt()

For instance:

cells = ['a', 'b' 'c']
# print the first cell
print cell[1]

A bug that is easily spotted thanks to the comment. It's all about implementation versus intentions. Also note that comment should be written for the future self,  and most importantly, for the current others.

JM



-- IMPORTANT NOTICE: 

The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[toc] | [next] | [standalone]


#78156

Fromalister <alister.nospam.ware@ntlworld.com>
Date2014-09-22 15:23 +0000
Message-ID<faXTv.319653$J62.216269@fx03.am4>
In reply to#78151
On Mon, 22 Sep 2014 16:32:27 +0200, Jean-Michel Pichavant wrote:

> ----- Original Message -----
>> From: "Chris Angelico" <rosuav@gmail.com>
>> Cc: python-list@python.org Sent: Saturday, 20 September, 2014 4:58:44
>> PM Subject: Re: Love to get some feedback on my first python app!!!
> [snip]
>> 
>>     #search API rawData =
>>     urllib.urlopen('http://ajax.googleapis.com/ajax/services/search/
web?v=1.0&q='+encodedQuery).read()
>>     #loads data from API into json jsonData = json.loads(rawData)
>>     #extracts the results from API searchResults =
>>     jsonData['responseData']['results']
>> 
>> The more normal way to write these would be in present tense, in a more
>> imperative style: "Fix some bugs", "Load data", "Extract results".
>> (Although these comments are actually quite redundant - all they do is
>> tell you what the single next line of code does.)
> 
> I used to belong to the cult "don't repeat yourself" in the comments,
> being angry against people who thought I couldn't understand by myself
> the simplest line of code.
> 
> But I changed my mind. I've read some code comments over the years and
> best ones (imo) where those which where actually repeating themselves.
> Golden rules of comments:
> 
> # state what you plan to do doIt()
> 
> For instance:
> 
> cells = ['a', 'b' 'c']
> # print the first cell print cell[1]

That is not too bad, "Print Customer name from cell 1" may be better as 
it would stick out if the data structure changed

what is meant by don't state the obvious in comments is stating something 
like "Increment x" without explaining why.

-- 
"It is hard to overstate the debt that we owe to men and women of genius."
-- Robert G. Ingersoll

[toc] | [prev] | [standalone]


Back to top | Article view | comp.lang.python


csiph-web