Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #78139

Re: Love to get some feedback on my first python app!!!

Path csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed4.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Return-Path <rosuav@gmail.com>
X-Original-To python-list@python.org
Delivered-To python-list@mail.python.org
X-Spam-Status OK 0.002
X-Spam-Evidence '*H*': 1.00; '*S*': 0.00; 'args': 0.07; 'context': 0.07; 'tries': 0.07; '22,': 0.09; 'advice.': 0.09; 'repeated': 0.09; 'try:': 0.09; 'wrapped': 0.09; 'cc:addr:python-list': 0.11; 'python': 0.11; 'def': 0.12; "'from": 0.16; '*why*': 0.16; '__future__': 0.16; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'func': 0.16; 'letting': 0.16; 'newsgroup.': 0.16; 'optional.': 0.16; 'sure.': 0.16; 'subject:python': 0.16; 'for?': 0.16; 'do,': 0.16; 'wrote:': 0.18; 'variable': 0.18; 'not,': 0.20; 'seems': 0.21; 'programming': 0.22; 'import': 0.22; 'saying': 0.22; 'cc:addr:python.org': 0.22; "aren't": 0.24; 'mathematical': 0.24; 'necessary.': 0.24; 'mon,': 0.24; "haven't": 0.24; 'cc:2**0': 0.24; 'nearly': 0.26; 'posts': 0.26; 'suggested': 0.26; 'pass': 0.26; 'least': 0.26; 'header:In-Reply-To:1': 0.27; 'idea': 0.28; 'point': 0.28; 'function': 0.29; "doesn't": 0.30; '(like': 0.30; 'message-id:@mail.gmail.com': 0.30; "i'm": 0.30; 'program,': 0.31; 'code': 0.31; 'comments': 0.31; 'posting': 0.31; '"do': 0.31; 'about.': 0.31; 'bad.': 0.31; 'changed.': 0.31; 'explained': 0.31; 'sep': 0.31; 'subject:some': 0.31; 'another': 0.32; 'text': 0.33; 'up.': 0.33; 'entirely': 0.33; 'style': 0.33; "i'd": 0.34; "can't": 0.35; 'display': 0.35; 'something': 0.35; 'but': 0.35; 'received:google.com': 0.35; 'add': 0.35; 'should': 0.36; 'list': 0.37; 'level': 0.37; 'feedback': 0.38; 'fact': 0.38; 'pm,': 0.38; 'rather': 0.38; 'explain': 0.39; 'does': 0.39; 'bad': 0.39; 'extremely': 0.39; 'sure': 0.39; 'mailing': 0.39; 'either': 0.39; 'called': 0.40; 'read': 0.60; 'hope': 0.61; "you're": 0.61; 'telling': 0.64; 'more': 0.64; 'talking': 0.65; 'teach': 0.65; 'frequently': 0.68; 'fact,': 0.69; 'evaluate': 0.72; 'funny': 0.74; 'subject:!!!': 0.74; 'subject:get': 0.81; 'excessive': 0.84; 'obvious.': 0.84; 'subject:Love': 0.91; 'to:none': 0.92
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=asECaub9B8gOQKZtmUHqMhveBPfErTF8z3VAb+/dWxw=; b=XCpeTMW3DtDNeaxsYXIIO7T7yZbgKvRxSfmArO6rawsl/QIukbSCnP9aWdI7o2gzOy mdblbmCehT+Se3DGfuRbNuSMt32vUvVAg+x+dDC2ITCW98HFl2mjJ1O8RUIJyIh3lSav hAmwhWZzAn0vllGMsfbXvIFjnHeZnO+EvXCIo4Gns2rEKCBOz6J+ulcPWplpf1DdIgxU YgBUKG1qjit3JApUEyW7uYbKXgOQ6uRseMglu6ZVpbq1wNNpScUTzUyAAVJ65atx/Dhr +6IFaHPIhexEWQxmia24VFMBXXXj9G3eZ2FnorfErDrSq57azrrllQPiX6g4Q67RQE9X RyNw==
MIME-Version 1.0
X-Received by 10.50.176.202 with SMTP id ck10mr14072961igc.2.1411387744922; Mon, 22 Sep 2014 05:09:04 -0700 (PDT)
In-Reply-To <da461783-6fbb-464c-be69-104a8d35c58e@googlegroups.com>
References <42e68de9-7528-46fc-8c74-c0baa1d6199e@googlegroups.com> <f6b164d3-9a86-4487-ad71-35773353b3e2@googlegroups.com> <9bed8e07-9e22-4131-92e8-f950cb5c0d18@googlegroups.com> <mailman.14187.1411377804.18130.python-list@python.org> <da461783-6fbb-464c-be69-104a8d35c58e@googlegroups.com>
Date Mon, 22 Sep 2014 22:09:04 +1000
Subject Re: Love to get some feedback on my first python app!!!
From Chris Angelico <rosuav@gmail.com>
Cc "python-list@python.org" <python-list@python.org>
Content-Type text/plain; charset=UTF-8
X-BeenThere python-list@python.org
X-Mailman-Version 2.1.15
Precedence list
List-Id General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive <http://mail.python.org/pipermail/python-list/>
List-Post <mailto:python-list@python.org>
List-Help <mailto:python-list-request@python.org?subject=help>
List-Subscribe <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups comp.lang.python
Message-ID <mailman.14195.1411387747.18130.python-list@python.org> (permalink)
Lines 52
NNTP-Posting-Host 2001:888:2000:d::a6
X-Trace 1411387747 news.xs4all.nl 2912 [2001:888:2000:d::a6]:48354
X-Complaints-To abuse@xs4all.nl
Xref csiph.com comp.lang.python:78139

Show key headers only | View raw


On Mon, Sep 22, 2014 at 9:47 PM,  <vek.m1234@gmail.com> wrote:
> 1. It's feedback not a mathematical proof.
> 2. I hope the OP tries what I suggested - it's all entirely optional.

Doesn't change the fact that you need to justify your recommendations,
at least when they're not obvious. You're suggesting a number of
things which are definitely not the same as I'd recommend, and I can't
evaluate them because you haven't explained *why* you give that
advice.

> @OP
> I have no idea what that program does because it's well commented. You aren't using variable and function names to good effect and are resorting to excessive comments.

Comments are not bad. His variable names aren't nearly as bad as you
imply. I can read the code *just fine*. Either you're exaggerating, or
you're trolling, or you're extremely dim. I'm not sure which.

> Additionally, I think you are mangling your display text but I'm not sure.
> textDisplay.insert should be a function that you pass args to.
>
> def spit_msg(text):
>     textDisplay.insert(text)
>
> spit_msg("go away doo doo bird")
>
> Any time you see repeated text in your program, wrap it in a single func and simplify.

Not every one-liner needs to be a function. Not all repeated text
needs to be wrapped up. You can always add another level of
indirection, and it's frequently not necessary.

> try:
> def create_root_window():
>  rather than letting all your funny parts dangle around naked.

This seems incomplete. What's this try block for? What's the function
for? Will it be called from more than one place? If not, why wrap it
up?

Again, you need to explain *why* something needs to be changed.
Telling someone "do this, this, this, and this" is almost completely
useless, because it doesn't teach any better programming practices -
in fact, it may teach a black-box programming style that's good only
for novices (like saying "always put 'from __future__ import
print_function' at the top of your Python files", which might be a
perfectly good thing to do, but at some point you need to explain
why).

Also, you're posting on a mailing list and newsgroup. Please include
context in your posts so we know what you're talking about.

ChrisA

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Love to get some feedback on my first python app!!! Nicholas Cannon <nicholascannon1@gmail.com> - 2014-09-20 06:16 -0700
  Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-21 00:58 +1000
  Re: Love to get some feedback on my first python app!!! Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-09-20 16:30 +0100
  Re: Love to get some feedback on my first python app!!! Nicholas Cannon <nicholascannon1@gmail.com> - 2014-09-20 18:33 -0700
    Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-21 11:48 +1000
  Re: Love to get some feedback on my first python app!!! Nicholas Cannon <nicholascannon1@gmail.com> - 2014-09-20 20:44 -0700
  Re: Love to get some feedback on my first python app!!! Nicholas Cannon <nicholascannon1@gmail.com> - 2014-09-21 01:53 -0700
    Re: Love to get some feedback on my first python app!!! vek.m1234@gmail.com - 2014-09-22 02:00 -0700
      Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-22 19:23 +1000
        Re: Love to get some feedback on my first python app!!! vek.m1234@gmail.com - 2014-09-22 04:47 -0700
          Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-22 22:09 +1000
            Re: Love to get some feedback on my first python app!!! vek.m1234@gmail.com - 2014-09-22 06:35 -0700
              Re: Love to get some feedback on my first python app!!! C Smith <illusiontechniques@gmail.com> - 2014-09-22 06:48 -0700
                Re: Love to get some feedback on my first python app!!! vek.m1234@gmail.com - 2014-09-22 08:12 -0700
              Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-22 23:57 +1000
              Re: Love to get some feedback on my first python app!!! Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-09-22 17:17 +0100
              Re: Love to get some feedback on my first python app!!! Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-09-22 17:17 +0100
              Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-23 02:58 +1000
          Re: Love to get some feedback on my first python app!!! Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-09-22 17:10 +0100
          Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-23 02:26 +1000
  Re: Love to get some feedback on my first python app!!! vek.m1234@gmail.com - 2014-09-22 05:00 -0700
    Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-22 22:23 +1000
    Re: Love to get some feedback on my first python app!!! Larry Martell <larry.martell@gmail.com> - 2014-09-22 09:02 -0400
    Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-22 23:21 +1000
    Re: Love to get some feedback on my first python app!!! Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-09-22 17:11 +0100
  Re: Love to get some feedback on my first python app!!! Nicholas Cannon <nicholascannon1@gmail.com> - 2014-09-22 06:17 -0700
    Re: Love to get some feedback on my first python app!!! Chris Angelico <rosuav@gmail.com> - 2014-09-22 23:28 +1000
    Re: Love to get some feedback on my first python app!!! Mark Lawrence <breamoreboy@yahoo.co.uk> - 2014-09-22 17:14 +0100
  Re: Love to get some feedback on my first python app!!! Nicholas Cannon <nicholascannon1@gmail.com> - 2014-09-22 06:19 -0700

csiph-web