Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.php > #18813

Shorter is not always better

Show all headers | View raw

An simplified example from a real project:

  if (!($this->action[$key] ?? false)) {

What it means:

1) $this->action[$key] ?? false

This return $this->action[$key] if $this->action[$key] exists and is not
null or "false".

2) !( .... )

Will negate the result - so the condition is true if $this->action[$key]
does not exist or is null.

However to understand this you must know what the ?? operator means and
note the negation using ! in the beginning.

When you did not create this code in the first place or try to find a
bug expressions like this are not really helpful.

I would prefer a longer but easier to understand solution like this:

  if (!isset($this->statusActions[$key])
      || null === $this->statusActions[$key]
  ) {

Any thoughts on this?


-- 
Arno Welzel
https://arnowelzel.de

Back to comp.lang.php | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Shorter is not always better Arno Welzel <usenet@arnowelzel.de> - 2021-11-23 11:52 +0100
  Re: Shorter is not always better "J.O. Aho" <user@example.net> - 2021-11-23 12:17 +0100
    Re: Shorter is not always better Stefan+Usenet@Froehlich.Priv.at (Stefan Froehlich) - 2021-11-24 09:57 +0000
      Re: Shorter is not always better "J.O. Aho" <user@example.net> - 2021-11-24 15:53 +0100
  Re: Shorter is not always better Jerry Stuckle <jstucklex@attglobal.net> - 2021-11-23 18:42 -0500
  Re: Shorter is not always better Ben Bacarisse <ben.usenet@bsb.me.uk> - 2021-11-23 23:48 +0000
  Re: Shorter is not always better See Kes Seda Hetkel Siia Kirjutab <he1983912@gmail.com> - 2022-06-30 19:21 -0700
    Re: Shorter is not always better Stan Weiss <srweiss@erols.com> - 2022-07-01 01:05 -0400
      Re: Shorter is not always better Allodoxaphobia <trepidation@example.net> - 2022-07-01 12:18 +0000
        Re: Shorter is not always better Stan Weiss <srweiss@erols.com> - 2022-07-01 09:08 -0400
          Re: Shorter is not always better Mateusz Viste <mateusz@xyz.invalid> - 2022-07-01 17:13 +0200

csiph-web