Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.php > #12027

Re: from mysql in associative array

Show all headers | View raw

Tony Mountifield wrote:

> I wrote:
>> In article <l7abvs$k7s$1@dont-email.me>,
>> Knut Krueger  <knut.krueger@usa.com> wrote:
>> > Hi to all, whats the best was to get to get one of two colums of an
>> > database query in an array as the names of the associative array
>> > 
>> > means
>> > mysql table
>> > id    value
>> > 1 green
>> > 2 red
>> > 3 blue
>> > ....
>> > 
>> > 
>> > should be
>> > 
>> > $array = array ( 'green ' => '1',
>> >                   'red ' => '2',
>> >                   'blue ' => '3' );
>> 
>> I would do something like:
>> 
>> $array = array();

Unnecessary, and – as-is – confusing.
 
>> $sh = mysql_query("SELECT id,value FROM mytable", $db);

Unwise, see below.

>> if ($sh) {

Insufficient, RTFM.

>> while ($ob = mysql_fetch_object($sh)) {
>> $array[$ob->value] = $ob->id;
>> }

It is unnecessary and inefficient to create a stdObject instance just to 
throw it away.  mysql(i)_fetch_assoc() suffices here; however 
mysqli_fetch_all() and friends in combination with array_map() is even more 
efficient.

>> $sh->finish();
> 
> Of course, that should be mysql_free_result($sh);

Of course, that should be *at least* mysqli_free_result($sh);
 
> That's what I get for flipping between PHP and Perl DBI !

That's what you get for not reading the newsgroup (sufficiently) before you 
post.  See also the warning in <http://php.net/mysql_free_result>.


PointedEars
-- 
Sometimes, what you learn is wrong. If those wrong ideas are close to the 
root of the knowledge tree you build on a particular subject, pruning the 
bad branches can sometimes cause the whole tree to collapse.
  -- Mike Duffy in cljs, <news:Xns9FB6521286DB8invalidcom@94.75.214.39>

Back to comp.lang.php | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

from mysql in associative array Knut Krueger <knut.krueger@usa.com> - 2013-11-29 16:31 +0100
  Re: from mysql in associative array tony@mountifield.org (Tony Mountifield) - 2013-11-29 15:36 +0000
    Re: from mysql in associative array tony@mountifield.org (Tony Mountifield) - 2013-11-29 15:40 +0000
      Re: from mysql in associative array The Natural Philosopher <tnp@invalid.invalid> - 2013-11-29 16:47 +0000
        Re: from mysql in associative array Jerry Stuckle <jstucklex@attglobal.net> - 2013-11-29 14:06 -0500
      Re: from mysql in associative array Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-11-29 21:29 +0100
        Re: from mysql in associative array Ben Bacarisse <ben.usenet@bsb.me.uk> - 2013-11-29 22:26 +0000
          Re: from mysql in associative array Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-11-29 23:36 +0100
          Re: from mysql in associative array Denis McMahon <denismfmcmahon@gmail.com> - 2013-11-29 23:56 +0000
            Re: from mysql in associative array Ben Bacarisse <ben.usenet@bsb.me.uk> - 2013-11-30 00:30 +0000
          Re: from mysql in associative array Jerry Stuckle <jstucklex@attglobal.net> - 2013-11-29 20:29 -0500
        Re: from mysql in associative array tony@mountifield.org (Tony Mountifield) - 2013-11-30 13:35 +0000
          Re: from mysql in associative array Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-11-30 15:28 +0100

csiph-web