Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.php > #10227

Re: Hopiing for some leads as to what may be wrong in this code

Show all headers | View raw

Norman Peelman wrote:

> On 07/25/2013 02:11 PM, Twayne wrote:
>> On 2013-07-25 1:51 PM, Christoph Michael Becker wrote:
>>> Twayne wrote:
>>>>   $code= $_POST["code"];
>>>>   if($_SESSION["d"] !== $code) {
>>>>       echo "<br />You did not enter the correct code: Script halted,
>>>>       ALL
>>>> data destroyed.<br /> you'll have to go back to the website and start
>>>> over.<br />";
>>>>      die("Script HALTED, data destroyed");
>>>> session_destroy();
>>>> exit();
>>>> }
>>>
>>> You may consider checking the actual values of $code and $_SESSION['d']
>>> immediately before the if statement (if you don't have a debugger at
>>> hand, just use a simple var_dump()).
>>
>> It's interesting, but I did.  A rev back I had an echo for "code" and
>> Session(... and it prints them just before it throws the error message.
>>>
>>> BTW: calling session_destroy() after die() was executed doesn't have any
>>> effect.  You'll want to swap both lines and remove the exit().
>>>
>>
>> THAT is wise advice!  Thanks I'll do just that; thanks for pointing it
>> out.
>>
> 
>     $code= $_POST["code"];
>     echo "<pre>";
>     var_dump($_SESSION["d"]);
>     var_dump($code);
>     echo "</pre>";
>     if($_SESSION["d"] !== $code) {

      if ($_SESSION["d"] !== $code) {

(it is not a call)

>       echo "<br />You did not enter the correct code: Script halted, ALL
>   data destroyed.<br /> you'll have to go back to the website and start
>   over.<br />";
>        die("Script HALTED, data destroyed");
>   session_destroy();
>   exit();
> 
> 
>    You need to make sure that both variables are of the same *value* and
> *type*. Another way to check would be to change !== to != (or <>). The
> only way your branch gets executed is if they do not match both *value*
> and *type*.

What are you getting at?  I do not see how a $_POST element could ever be 
*not* a string, and the result of “!==” can be false even when the two 
operands *are* of the same type.  And the code must be a string here (it 
contains “-”), so $_SESSION['d'] would be a string.

The difference is perhaps in the session not being started or recognized on 
one PHP host, but on the other.  If the session is not started, it could be 
that session information cannot be written to the filesystem; if the session 
is not recognized, it could be that the session cookie is not set on the 
client-side due to user settings.

ISTM there still is not enough information in the posting; for example, the 
part that *sets* $_SESSION['d'] is missing.

The OP should take heed of

<http://www.catb.org/~esr/faqs/smart-questions.html>

and stop wasting everybody's time with guessing games.


PointedEars
-- 
Sometimes, what you learn is wrong. If those wrong ideas are close to the 
root of the knowledge tree you build on a particular subject, pruning the 
bad branches can sometimes cause the whole tree to collapse.
  -- Mike Duffy in cljs, <news:Xns9FB6521286DB8invalidcom@94.75.214.39>

Back to comp.lang.php | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-24 19:27 -0400
  Re: Hopiing for some leads as to what may be wrong in this code Jerry Stuckle <jstucklex@attglobal.net> - 2013-07-24 23:04 -0400
    Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-25 13:39 -0400
    Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-08-04 16:24 -0400
      Re: Hopiing for some leads as to what may be wrong in this code Jerry Stuckle <jstucklex@attglobal.net> - 2013-08-04 22:08 -0400
  Re: Hopiing for some leads as to what may be wrong in this code Scott Johnson <noonehome@chalupasworld.com> - 2013-07-24 20:42 -0700
    Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-25 13:37 -0400
  Re: Hopiing for some leads as to what may be wrong in this code The Natural Philosopher <tnp@invalid.invalid> - 2013-07-25 09:28 +0100
    Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-25 13:24 -0400
      Re: Hopiing for some leads as to what may be wrong in this code The Natural Philosopher <tnp@invalid.invalid> - 2013-07-25 19:18 +0100
  Re: Hopiing for some leads as to what may be wrong in this code Christoph Michael Becker <cmbecker69@arcor.de> - 2013-07-25 19:51 +0200
    Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-25 14:11 -0400
      Re: Hopiing for some leads as to what may be wrong in this code Christoph Michael Becker <cmbecker69@arcor.de> - 2013-07-25 20:31 +0200
      Re: Hopiing for some leads as to what may be wrong in this code Norman Peelman <npeelman@cfl.rr.com> - 2013-07-25 20:37 -0400
        Re: Hopiing for some leads as to what may be wrong in this code Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-07-27 12:17 +0200
          Re: Hopiing for some leads as to what may be wrong in this code Fiver <numeralfive@gmail.com> - 2013-07-28 07:01 +0200
            Re: Hopiing for some leads as to what may be wrong in this code Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2013-07-28 17:48 +0200
              Re: Hopiing for some leads as to what may be wrong in this code The Natural Philosopher <tnp@invalid.invalid> - 2013-07-28 19:17 +0100
    Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-25 14:24 -0400
  RESOLVED Re: Hopiing for some leads as to what may be wrong in this code Twayne <nobody@spamcop.net> - 2013-07-27 11:05 -0400

csiph-web