Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #39822 > unrolled thread

Problem with string concatenation

Back to article view | Back to comp.lang.javascript

Contents

  Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-01 07:13 -0700
    Re: Problem with string concatenation The Natural Philosopher <tnp@invalid.invalid> - 2021-04-01 16:17 +0100
      Re: Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-01 08:39 -0700
      Re: Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-02 00:37 -0700
    Re: Problem with string concatenation JJ <jj4public@gmail.com> - 2021-04-01 22:19 +0700
      Re: Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-01 08:40 -0700
    Re: Problem with string concatenation Jon Ribbens <jon+usenet@unequivocal.eu> - 2021-04-01 15:50 +0000
      Re: Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-01 23:55 -0700
      Re: Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-02 00:25 -0700
        Re: Problem with string concatenation Jon Ribbens <jon+usenet@unequivocal.eu> - 2021-04-02 15:25 +0000
          Re: Problem with string concatenation Daniele Ferrarese <daniele.seversrl@gmail.com> - 2021-04-05 23:54 -0700

#39822 — Problem with string concatenation

Hello
I'm still here asking for your help as a beginner.

i'm trying to concatenate arguments of a function with the following string, 

onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)"

but i think there are concatenation errors maybe for double quotes or i don't know.
Could anyone help me? Thanks.

Rgds - Daniele Ferrarese

[toc] | [next] | [standalone]

#39825

On 01/04/2021 15:13, Daniele Ferrarese wrote:
> Hello
> I'm still here asking for your help as a beginner.
> 
> i'm trying to concatenate arguments of a function with the following string,
> 
> onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)"
> 
> but i think there are concatenation errors maybe for double quotes or i don't know.
> Could anyone help me? Thanks.
> 
> Rgds - Daniele Ferrarese
> 

You probably need - unless they are JavaScript declared variables - to 
turn your php $varaibili[]'s into strings...

i.e.
args="'$variabili[4]'.,.'$variabili[6]'.,.'$variabili[7]'.'$variabili[5]'"
// so args =  'arg1','arg2', etc...

onclick = "show_cart (<?php  echo $args ?>);"


remember JS only takes undeclared *numerical* args  without inverted commas.

So this is ok
var one, two;
show_cart(one,two);

and so is
show_cart(1,2);

But you have to do this if one and two are not numbers or declared

show_cart('one', 'two');

In all cases looking at 'show source' in the browser will help see what 
JavaScript is seeing and with luck your browser also supports a console, 
debugger and error log that can trap JavaScript errors


-- 
Religion is regarded by the common people as true, by the wise as 
foolish, and by the rulers as useful.

(Seneca the Younger, 65 AD)

[toc] | [prev] | [next] | [standalone]

#39827

Il giorno giovedì 1 aprile 2021 alle 17:17:23 UTC+2 The Natural Philosopher ha scritto:
> On 01/04/2021 15:13, Daniele Ferrarese wrote: 
> > Hello 
> > I'm still here asking for your help as a beginner. 
> > 
> > i'm trying to concatenate arguments of a function with the following string, 
> > 
> > onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)" 
> > 
> > but i think there are concatenation errors maybe for double quotes or i don't know. 
> > Could anyone help me? Thanks. 
> > 
> > Rgds - Daniele Ferrarese 
> >
> You probably need - unless they are JavaScript declared variables - to 
> turn your php $varaibili[]'s into strings... 
> 
> i.e. 
> args="'$variabili[4]'.,.'$variabili[6]'.,.'$variabili[7]'.'$variabili[5]'" 
> // so args = 'arg1','arg2', etc... 
> 
> onclick = "show_cart (<?php echo $args ?>);" 
> 
> 
> remember JS only takes undeclared *numerical* args without inverted commas. 
> 
> So this is ok 
> var one, two; 
> show_cart(one,two); 
> 
> and so is 
> show_cart(1,2); 
> 
> But you have to do this if one and two are not numbers or declared 
> 
> show_cart('one', 'two'); 
> 
> In all cases looking at 'show source' in the browser will help see what 
> JavaScript is seeing and with luck your browser also supports a console, 
> debugger and error log that can trap JavaScript errors 
> 
> 
> -- 
> Religion is regarded by the common people as true, by the wise as 
> foolish, and by the rulers as useful. 
> 
> (Seneca the Younger, 65 AD)

Thank you very much for your explanation. It's clear.
I'll check.

Bst rgds - Daniele Ferrarese
P.S. - Very interesting your footer sentences !!!

[toc] | [prev] | [next] | [standalone]

#39840

Il giorno giovedì 1 aprile 2021 alle 17:17:23 UTC+2 The Natural Philosopher ha scritto:
> On 01/04/2021 15:13, Daniele Ferrarese wrote: 
> > Hello 
> > I'm still here asking for your help as a beginner. 
> > 
> > i'm trying to concatenate arguments of a function with the following string, 
> > 
> > onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)" 
> > 
> > but i think there are concatenation errors maybe for double quotes or i don't know. 
> > Could anyone help me? Thanks. 
> > 
> > Rgds - Daniele Ferrarese 
> >
> You probably need - unless they are JavaScript declared variables - to 
> turn your php $varaibili[]'s into strings... 
> 
> i.e. 
> args="'$variabili[4]'.,.'$variabili[6]'.,.'$variabili[7]'.'$variabili[5]'" 
> // so args = 'arg1','arg2', etc... 
> 
> onclick = "show_cart (<?php echo $args ?>);" 
> 
> 
> remember JS only takes undeclared *numerical* args without inverted commas. 
> 
> So this is ok 
> var one, two; 
> show_cart(one,two); 
> 
> and so is 
> show_cart(1,2); 
> 
> But you have to do this if one and two are not numbers or declared 
> 
> show_cart('one', 'two'); 
> 
> In all cases looking at 'show source' in the browser will help see what 
> JavaScript is seeing and with luck your browser also supports a console, 
> debugger and error log that can trap JavaScript errors 
> 
> 
> -- 
> Religion is regarded by the common people as true, by the wise as 
> foolish, and by the rulers as useful. 
> 
> (Seneca the Younger, 65 AD)

Sorry but your solution is not running. Google Chrome debug is giving "Unexpected token ' , ' " error message.
Anyhow thank you for your help.

[toc] | [prev] | [next] | [standalone]

#39826

On Thu, 1 Apr 2021 07:13:21 -0700 (PDT), Daniele Ferrarese wrote:
> Hello
> I'm still here asking for your help as a beginner.
> 
> i'm trying to concatenate arguments of a function with the following string, 
> 
> onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)"
> 
> but i think there are concatenation errors maybe for double quotes or i don't know.
> Could anyone help me? Thanks.
> 
> Rgds - Daniele Ferrarese

You're PHP-echoing variable contents to be used as variable names in
JavaScript.

[toc] | [prev] | [next] | [standalone]

#39828

Il giorno giovedì 1 aprile 2021 alle 17:19:39 UTC+2 JJ ha scritto:
> On Thu, 1 Apr 2021 07:13:21 -0700 (PDT), Daniele Ferrarese wrote: 
> > Hello 
> > I'm still here asking for your help as a beginner. 
> > 
> > i'm trying to concatenate arguments of a function with the following string, 
> > 
> > onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)" 
> > 
> > but i think there are concatenation errors maybe for double quotes or i don't know. 
> > Could anyone help me? Thanks. 
> > 
> > Rgds - Daniele Ferrarese
> You're PHP-echoing variable contents to be used as variable names in 
> JavaScript.
Thanks for your explanation.

Bst rgds - Daniele Ferrarese

[toc] | [prev] | [next] | [standalone]

#39829

On 2021-04-01, Daniele Ferrarese <daniele.seversrl@gmail.com> wrote:
> Hello
> I'm still here asking for your help as a beginner.
>
> i'm trying to concatenate arguments of a function with the following
> string, 
>
> onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)"
>
> but i think there are concatenation errors maybe for double quotes or
> i don't know.
> Could anyone help me? Thanks.

You're not actually concatenating anything. Nor are you implementing the
necessary encodings. Assuming what you're trying to do is concatenate
those 'variabili' things, you'd want something like:

  onclick='show_cart(<?php
    echo json_encode(
      $variabili[4] . $variabili[6] . $variabili[7] . $variabili[5],
      JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS
    );
  ?>)'

Now go and say 500 Hail Marys for making me think about PHP.

[toc] | [prev] | [next] | [standalone]

#39838

Il giorno giovedì 1 aprile 2021 alle 17:51:05 UTC+2 Jon Ribbens ha scritto:
> On 2021-04-01, Daniele Ferrarese <daniele....@gmail.com> wrote: 
> > Hello 
> > I'm still here asking for your help as a beginner. 
> > 
> > i'm trying to concatenate arguments of a function with the following 
> > string, 
> > 
> > onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)" 
> > 
> > but i think there are concatenation errors maybe for double quotes or 
> > i don't know. 
> > Could anyone help me? Thanks.
> You're not actually concatenating anything. Nor are you implementing the 
> necessary encodings. Assuming what you're trying to do is concatenate 
> those 'variabili' things, you'd want something like: 
> 
> onclick='show_cart(<?php 
> echo json_encode( 
> $variabili[4] . $variabili[6] . $variabili[7] . $variabili[5], 
> JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS 
> ); 
> ?>)' 
> 
> Now go and say 500 Hail Marys for making me think about PHP.
Hi Jon
Thank you for your help.
I didn't sleep a wink all night to recite the Hail Marys. Now I can fall asleep peacefully.
Wish you a nice day.
Daniele

[toc] | [prev] | [next] | [standalone]

#39839

Il giorno giovedì 1 aprile 2021 alle 17:51:05 UTC+2 Jon Ribbens ha scritto:
> On 2021-04-01, Daniele Ferrarese <daniele....@gmail.com> wrote: 
> > Hello 
> > I'm still here asking for your help as a beginner. 
> > 
> > i'm trying to concatenate arguments of a function with the following 
> > string, 
> > 
> > onclick="show_cart(<?php echo $variabili[4];?>","<?php echo $variabili[6];?>","<?php echo $variabili[7];?>","<?php echo $variabili[5];?>)" 
> > 
> > but i think there are concatenation errors maybe for double quotes or 
> > i don't know. 
> > Could anyone help me? Thanks.
> You're not actually concatenating anything. Nor are you implementing the 
> necessary encodings. Assuming what you're trying to do is concatenate 
> those 'variabili' things, you'd want something like: 
> 
> onclick='show_cart(<?php 
> echo json_encode( 
> $variabili[4] . $variabili[6] . $variabili[7] . $variabili[5], 
> JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS 
> ); 
> ?>)' 
> 
> Now go and say 500 Hail Marys for making me think about PHP.

Sorry Jon but is not running. Google Chrome debug is giving "Unexpected end of input" error.

[toc] | [prev] | [next] | [standalone]

#39843

On 2021-04-02, Daniele Ferrarese <daniele.seversrl@gmail.com> wrote:
> Il giorno giovedì 1 aprile 2021 alle 17:51:05 UTC+2 Jon Ribbens ha scritto:
>> You're not actually concatenating anything. Nor are you implementing the 
>> necessary encodings. Assuming what you're trying to do is concatenate 
>> those 'variabili' things, you'd want something like: 
>> 
>> onclick='show_cart(<?php 
>> echo json_encode( 
>> $variabili[4] . $variabili[6] . $variabili[7] . $variabili[5], 
>> JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS 
>> ); 
>> ?>)' 
>> 
>> Now go and say 500 Hail Marys for making me think about PHP.
>
> Sorry Jon but is not running. Google Chrome debug is giving
> "Unexpected end of input" error.

The code I posted certainly works - I tested it. If it's not working
in the context of the rest of your code you'll need to provide more
information, e.g. the 'view source' of your output page.

[toc] | [prev] | [next] | [standalone]

#39852

Il giorno venerdì 2 aprile 2021 alle 17:25:48 UTC+2 Jon Ribbens ha scritto:
> On 2021-04-02, Daniele Ferrarese <daniele....@gmail.com> wrote: 
> > Il giorno giovedì 1 aprile 2021 alle 17:51:05 UTC+2 Jon Ribbens ha scritto: 
> >> You're not actually concatenating anything. Nor are you implementing the 
> >> necessary encodings. Assuming what you're trying to do is concatenate 
> >> those 'variabili' things, you'd want something like: 
> >> 
> >> onclick='show_cart(<?php 
> >> echo json_encode( 
> >> $variabili[4] . $variabili[6] . $variabili[7] . $variabili[5], 
> >> JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS 
> >> ); 
> >> ?>)' 
> >> 
> >> Now go and say 500 Hail Marys for making me think about PHP. 
> > 
> > Sorry Jon but is not running. Google Chrome debug is giving 
> > "Unexpected end of input" error.
> The code I posted certainly works - I tested it. If it's not working 
> in the context of the rest of your code you'll need to provide more 
> information, e.g. the 'view source' of your output page.
Hi Jon
I'm sure that your code is running and that mistake is in the rest of my code. For that reason I decided to modify the function by requiring just one "variabile". Now I solved my problem. Anyhow thank you very much for your suggestion.
Have a nice day.
Daniele

[toc] | [prev] | [standalone]

Back to top | Article view | comp.lang.javascript

csiph-web