Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #35455

Re: addEventListener question

Show key headers only | View raw

Luuk <luuk@invalid.lan> writes:
<snip>
>> Luuk <luuk@invalid.lan> wrote on 10 Aug 2018 in comp.lang.javascript:
>> 
>>>      <dl id="csschart">
>>>           
>>>           <dt>001</dt>
>>>           <dd class="p22"><span><b>22</b></span></dd>
>>>           <dd class="sub p10" ><span><b>10</b></span></dd>
>>>           
>>>           <dt>002</dt>
>>>           <dd class="p45"><span><b>45</b></span></dd>
>>>           <dd class="sub p35"><span><b>36</b></span></dd>     

(The thanks are to Evertjan.)

> Ok, thanks, but i made a small modification, i like 'abc'... ;)
>
>
>   var links = document.getElementById('csschart').children;
>   var index;
>   var abc = -1;
>   for (index = 0; index < links.length; ++index) {
> 	if (links[index].tagName=='DT') { abc++; }
> 	links[index].classList.add("__nr" + abc);
>     links[index].addEventListener('click',function(e) {
> 		alert(this.classList.toString().replace(/.*__nr/, ''));
>   });
>   }

You appear to be using the class simply to get the right numeric string
into the function at execution time.  There are other, less contrived
ways to do that, but you already have the string, don't you, in the
<dt>...</dt> element?

Also, with the code as it is, you don't need fresh a listener function
every time.  You just need two of them, each used three times.  Of
course, in your final version that might not be the case -- I can only
go by what you have written so far.

Here's one approach:

 var links = document.getElementById('csschart').children;
 var listener;
 for (var index = 0; index < links.length; ++index) {
      if (links[index].tagName == 'DT') {
           listener = (function (num) {
                return function (e) { alert(num); }
           })(links[index].innerText);
      }
      links[index].addEventListener('click', listener);
  }

<snip>
-- 
Ben.

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

addEventListener question Luuk <luuk@invalid.lan> - 2018-08-10 18:21 +0200
  Re: addEventListener question "Evertjan." <exxjxw.hannivoort@inter.nl.net> - 2018-08-11 00:04 +0200
    Re: addEventListener question Luuk <luuk@invalid.lan> - 2018-08-11 14:28 +0200
      Re: addEventListener question Ben Bacarisse <ben.usenet@bsb.me.uk> - 2018-08-11 14:53 +0100
        Re: addEventListener question "Christoph M. Becker" <cmbecker69@arcor.de> - 2018-08-11 16:27 +0200
          Re: addEventListener question Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2018-08-12 17:49 +0200
            Re: addEventListener question "Christoph M. Becker" <cmbecker69@arcor.de> - 2018-08-12 18:05 +0200
              Re: addEventListener question Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2018-08-12 18:42 +0200
                Re: addEventListener question "Christoph M. Becker" <cmbecker69@arcor.de> - 2018-08-12 19:38 +0200
                Re: addEventListener question Julio Di Egidio <julio@diegidio.name> - 2018-08-12 11:12 -0700
                Re: addEventListener question James Kirk <noneya.invalid@gmail.com> - 2018-08-12 22:36 -0400
                Re: addEventListener question Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2018-09-06 08:17 +0200
                Re: addEventListener question "Evertjan." <exxjxw.hannivoort@inter.nl.net> - 2018-08-13 11:50 +0200
                Re: addEventListener question Luuk <luuk@invalid.lan> - 2018-08-18 16:50 +0200
        Re: addEventListener question "Evertjan." <exxjxw.hannivoort@inter.nl.net> - 2018-08-11 16:58 +0200
          Re: addEventListener question Ben Bacarisse <ben.usenet@bsb.me.uk> - 2018-08-12 02:40 +0100
            Re: addEventListener question "Evertjan." <exxjxw.hannivoort@inter.nl.net> - 2018-08-12 09:07 +0200
        Re: addEventListener question Luuk <luuk@invalid.lan> - 2018-08-11 19:17 +0200
  Re: addEventListener question "Christoph M. Becker" <cmbecker69@arcor.de> - 2018-08-11 16:30 +0200
    Re: addEventListener question Luuk <luuk@invalid.lan> - 2018-08-11 19:12 +0200
    Re: addEventListener question Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2018-08-12 17:46 +0200
      Re: addEventListener question "Christoph M. Becker" <cmbecker69@arcor.de> - 2018-08-12 18:06 +0200
        Re: addEventListener question "Christoph M. Becker" <cmbecker69@arcor.de> - 2018-08-12 18:12 +0200
          Re: addEventListener question Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2018-08-12 18:33 +0200
  Re: addEventListener question Luuk <luuk@invalid.lan> - 2018-08-18 17:01 +0200

csiph-web