Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #23559

Re: class needs to initialize vars, set data structure

Show key headers only | View raw

Stefan Ram wrote:

> ram@zedat.fu-berlin.de (Stefan Ram) writes:
>> var Set = function()

Note that, according to the latest working draft, ECMAScript Edition 6 is 
going to define a Set object type, so it is wise to test whether “Set” 
already exists before redefining it.

<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set>

>> { var map = {};
>>  return
>>  { add     : function( element ){ map[ element ]= true; },

This breaks existing properties because the prototype chain of Object 
instances is _not_ empty; they inherit from the object referred from 
Object.prototype (the Object prototype [object]).

>>    remove  : function( element ){ delete map[ element ]; },

This could delete built-in non-inherited properties.

>>    contains: function( element ){ return map.hasOwnProperty( element );

This would consider built-in non-inherited properties.

>>    },
>>    count   : function( element ){ return Object.keys( map ).length; }

This would count only enumerable own properties, contradicting .contains().

>>    }};

This would return an Object instance from a constructor call where a Set 
instance would be expected.

Compare <http://PointedEars.de/wsvn/JSX/trunk/map.js>.
 
>   The style above, I sometimes call »module style«.
>   Usually I will prefer the style below, which I sometimes call »prototype
>   style«:
> 
> function Set(){ this.map = {}; }
> Set.prototype.add      = function( element ){ this.map[ element ]= true;
> };
> Set.prototype.remove   = function( element ){ delete this.map[ element ];
> }; Set.prototype.contains = function( element ){ return
> this.map.hasOwnProperty( element ); };
> Set.prototype.count    = function( element ){ return Object.keys( this.map
> ).length; };

The latter style that you prefer not only is tedious to write, both styles 
are also less efficient than others.  Granted, the latter style is more 
compatible than the above, but only if you consider implementations older 
than 16 years to be still relevant.  Other than that, it has no obvious 
advantages, but it has less obvious disadvantages.  BTDT.

<http://PointedEars.de/es-matrix/?filter=%7B>

Also, a set is _not_ a map, and vice-versa.  A set is a data structure that 
contains no duplicate *values*; a map is a data structure that contains no 
duplicate *keys*.

Your ongoing delusions of grandeur speaking from your postings are tiresome 
to say the least; it would be acceptable if you acquired a significant 
amount of humility.  Rest assured that your preferences and terminology are 
largely irrelevant to readers as you are evidently not experienced enough to 
serve as an authority on this topic.

-- 
PointedEars
FAQ: <http://PointedEars.de/faq> | SVN: <http://PointedEars.de/wsvn/>
Twitter: @PointedEars2 | ES Matrix: <http://PointedEars.de/es-matrix>
Please do not Cc: me. / Bitte keine Kopien per E-Mail.

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

class needs to initialize vars, set data structure JRough <janis.rough@gmail.com> - 2014-03-11 15:36 -0700
  Re: class needs to initialize vars, set data structure Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2014-03-12 03:34 +0100
    Re: class needs to initialize vars, set data structure Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2014-03-12 15:09 +0100
    Re: class needs to initialize vars, set data structure John Harris <niam@jghnorth.org.uk.invalid> - 2014-03-12 17:04 +0000
      Re: class needs to initialize vars, set data structure John Harris <niam@jghnorth.org.uk.invalid> - 2014-03-14 10:48 +0000
  Re: class needs to initialize vars, set data structure Ben Bacarisse <ben.usenet@bsb.me.uk> - 2014-03-12 03:17 +0000
    Re: class needs to initialize vars, set data structure Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2014-03-12 11:46 +0100
    Re: class needs to initialize vars, set data structure Christoph Michael Becker <cmbecker69@arcor.de> - 2014-06-25 22:51 +0200
      Re: class needs to initialize vars, set data structure Christoph Michael Becker <cmbecker69@arcor.de> - 2014-06-26 00:42 +0200
        Re: class needs to initialize vars, set data structure Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2014-06-26 11:16 +0200
        Re: class needs to initialize vars, set data structure Christoph Michael Becker <cmbecker69@arcor.de> - 2014-06-26 21:44 +0200
          Re: class needs to initialize vars, set data structure John Harris <niam@jghnorth.org.uk.invalid> - 2014-06-27 09:46 +0100
            Re: class needs to initialize vars, set data structure Scott Sauyet <scott.sauyet@gmail.com> - 2014-06-28 21:57 -0700
  Re: class needs to initialize vars, set data structure Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2014-03-12 15:34 +0100

csiph-web