Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #34223

Re: removeeventlistener

Show key headers only | View raw

Thomas 'PointedEars' Lahn wrote:

>   var elementOvers = [];
> 
>   function setOver (elements)
>   {
>     /*
>      * NOTE:
>      * You may want to use ES 5 [].forEach.apply(elements, …) or
>      * ES 6 “for … of” on [].slice.call(elements) instead.
>      *
>      * In loops, cache the value of the “length” property unless you
>      * expect its value to change and want to handle that.
>      */
>     for (var i = 0, len = elements.length; i < len; ++i)
>     {
>       /* NOTE:
>        * You can still return the function reference instead.
>        * Just keep in mind that in the way it is used here,
>        * there is a closure over “i”.
>        *
>        * Consider using CSS “:hover” selectors based on class selectors
>        * instead of setting style properties here.
>        */
>       var elementOver = elementOvers[i] = function () {
>         this.style...
>       };

Supplemental:

If all listeners for the same event implement the same algorithm, you only 
need to define *one* such function such that it can be shared across 
function execution contexts –

  var elementOver = function () {
    // …
  };

–, and re-use the reference to it:

  function (…)
  {
    for (…)
    {
      elements[i].addEventListener("mouseover", elementOver, false);
    }
  }

  …

  function (…)
  {
    for (…)
    {
      elements[i].removeEventListener("mouseover", elementOver);
    }
  }

That would be much more efficient then.
 
-- 
PointedEars
FAQ: <http://PointedEars.de/faq> | <http://PointedEars.de/es-matrix>
<https://github.com/PointedEars> | <http://PointedEars.de/wsvn/>
Twitter: @PointedEars2 | Please do not cc me./Bitte keine Kopien per E-Mail.

Back to comp.lang.javascript | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

removeeventlistener Andrew Poulos <ap_prog@hotmail.com> - 2017-10-16 14:29 +1100
  Re: removeeventlistener Julio Di Egidio <julio@diegidio.name> - 2017-10-15 21:08 -0700
  Re: removeeventlistener Richard Maher <maher_rjSPAMLESS@hotmail.com> - 2017-10-16 13:06 +0800
  Re: removeeventlistener Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2017-10-16 22:18 +0200
    Re: removeeventlistener Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2017-10-28 19:48 +0200
      Re: removeeventlistener Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2017-10-28 20:00 +0200

csiph-web