Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.java.programmer > #26543

Re: Fixing "typos" in enums...

From Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at>
Newsgroups comp.lang.java.programmer
Subject Re: Fixing "typos" in enums...
Date 2013-11-18 18:58 +0000
Organization A noiseless patient Spider
Message-ID <slrnl8kops.42s.avl@gamma.logic.tuwien.ac.at> (permalink)
References <slrnl8cing.mol.avl@gamma.logic.tuwien.ac.at> <l65k8a$t2d$1@dont-email.me> <slrnl8kj3g.42s.avl@gamma.logic.tuwien.ac.at> <l6dj1q$nin$1@dont-email.me>

Show all headers | View raw


markspace <markspace@nospam.nospam> wrote:
> On 11/18/2013 9:20 AM, Andreas Leitgeb wrote:
>> markspace <markspace@nospam.nospam> wrote:
>>> On 11/15/2013 8:25 AM, Andreas Leitgeb wrote:
>>>>    @Deprecated public enum Foo { FURST, SECOND }
>>>>    public enum Fooing { FIRST, SECOND }
>> This solution would require duplicating lots of other
>> code, like methods taking that enum as parameter...
> So you change the old method to a new method that takes the new type. 
> It's called refactoring.  You don't duplicate methods, that's dumb.

Not quite as simple. I'd need a *copy* of each method (even as an
overload) taking the new Fooing, while the original would be
changed to @Deprecated and left at taking the Foo argument.

  @Deprecated void applyRank(Foo rank) { ... blah ... }
  void applyRank(Fooing rank) { ... mostly the same blah ... }

>> Also, in my case at hand the enum itself already has the
>> one and only correct name for that task (and it's of course
> I dislike adding a "2" onto new interface names, so I showed that coming 
> up with a new name is better.  I'm sure if you really think about it, 
> you can come up with a new name.  So far in the Java API, we've had 
> Date, Calendar and now LocalDateTime to all mean essentially the same 
> thing.  A little creativity and thought is required.

We learn from history, that alternatives for canonical names 
always get an "Ex" appended... ;)  At least, it is then obvious,
which is the older and which the newer...  (otoh, consider a
fix for some Color class being called Colour ;-)

Back to comp.lang.java.programmer | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-15 16:25 +0000
  Re: Fixing "typos" in enums... markspace <markspace@nospam.nospam> - 2013-11-15 09:05 -0800
    Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 17:20 +0000
      Re: Fixing "typos" in enums... markspace <markspace@nospam.nospam> - 2013-11-18 09:33 -0800
        Re: Fixing "typos" in enums... Eric Sosman <esosman@comcast-dot-net.invalid> - 2013-11-18 13:37 -0500
        Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 18:58 +0000
          Re: Fixing "typos" in enums... markspace <markspace@nospam.nospam> - 2013-11-18 11:35 -0800
            Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 20:34 +0000
  Re: Fixing "typos" in enums... Robert Klemme <shortcutter@googlemail.com> - 2013-11-15 20:10 +0100
    Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 17:29 +0000
      Re: Fixing "typos" in enums... Robert Klemme <shortcutter@googlemail.com> - 2013-11-18 19:38 +0100
        Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 19:34 +0000
  Re: Fixing "typos" in enums... Jan Burse <janburse@fastmail.fm> - 2013-11-16 10:16 +0100
    Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 18:25 +0000
      Re: Fixing "typos" in enums... Eric Sosman <esosman@comcast-dot-net.invalid> - 2013-11-18 13:45 -0500
        Re: Fixing "typos" in enums... Robert Klemme <shortcutter@googlemail.com> - 2013-11-18 20:20 +0100
        Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-18 20:09 +0000
          Re: Fixing "typos" in enums... Eric Sosman <esosman@comcast-dot-net.invalid> - 2013-11-18 17:00 -0500
            Re: Fixing "typos" in enums... Andreas Leitgeb <avl@gamma.logic.tuwien.ac.at> - 2013-11-19 15:39 +0000
  Re: Fixing "typos" in enums... Arivald <NOSPAMarivald@interia.pl> - 2013-11-19 00:29 +0100
    Re: Fixing "typos" in enums... lipska the kat <"lipskathekat at yahoo dot co dot uk"> - 2013-11-19 11:14 +0000

csiph-web