Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.java.programmer > #32055

How to test my @NotEmpty with JUnit

Show key headers only | View raw

We have to remove almost every framework used in the code. I started
with the @NotEmpty from Hibernate. It was the only class used from
Hibernate, so low hanging fruit we thought.

I wrote the following implementation:

    import        java.lang.annotation.Documented;
    import static java.lang.annotation.ElementType.FIELD;
    import        java.lang.annotation.Retention;
    import static java.lang.annotation.RetentionPolicy.RUNTIME;
    import        java.lang.annotation.Target;

    import        javax.validation.Constraint;
    import        javax.validation.constraints.NotNull;
    import        javax.validation.constraints.Size;
    import        javax.validation.ReportAsSingleViolation;

    @Documented
    @Constraint(validatedBy = {})
    @Target({ FIELD })
    @Retention(RUNTIME)
    @ReportAsSingleViolation
    @NotNull
    @Size(min = 1)
    public @interface NotEmpty {
        public abstract String message() default "Field has to be filled";
    }


But it should be tested also of-course. So I wrote the following test:

    import org.junit.Test;

    class NotEmptyClass {
        @NotEmpty
        String notEmpty;

        NotEmptyClass(String value) {
            notEmpty = value;
        }
    }

    public class NotEmptyTest {
        @Test
        public void firstTest() {
            new NotEmptyClass(null);
        }
    }

I would expect this test not to pass, but it does. So clearly I am
doing something wrong, but I have no idea what. (This is the first
time I really work with annotations.) I did some Googling but until
now to no avail. So if someone could point me to the right direction …

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Back to comp.lang.java.programmer | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

How to test my @NotEmpty with JUnit Cecil Westerhof <Cecil@decebal.nl> - 2015-07-17 10:36 +0200
  Re: How to test my @NotEmpty with JUnit Joerg Meier <joergmmeier@arcor.de> - 2015-07-17 12:28 +0200
    Re: How to test my @NotEmpty with JUnit Cecil Westerhof <Cecil@decebal.nl> - 2015-07-17 13:22 +0200
      Re: How to test my @NotEmpty with JUnit Cecil Westerhof <Cecil@decebal.nl> - 2015-07-22 11:49 +0200
  Re: How to test my @NotEmpty with JUnit Jeff Higgins <jeff@invalid.invalid> - 2015-07-17 07:27 -0400
    Re: How to test my @NotEmpty with JUnit Jeff Higgins <jeff@invalid.invalid> - 2015-07-17 07:58 -0400
    Re: How to test my @NotEmpty with JUnit Jeff Higgins <jeff@invalid.invalid> - 2015-07-17 09:14 -0400
    Re: How to test my @NotEmpty with JUnit Jeff Higgins <jeff@invalid.invalid> - 2015-07-17 10:59 -0400
    Re: How to test my @NotEmpty with JUnit Jeff Higgins <jeff@invalid.invalid> - 2015-07-17 11:39 -0400
    Re: How to test my @NotEmpty with JUnit Cecil Westerhof <Cecil@decebal.nl> - 2015-07-22 12:09 +0200
      Re: How to test my @NotEmpty with JUnit Cecil Westerhof <Cecil@decebal.nl> - 2015-07-25 17:10 +0200

csiph-web