Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.c > #90466

Re: Feedback for a malloc implementation

Show all headers | View raw

On 17/07/2016 08:30, Malcolm McLean wrote:
> On Sunday, July 17, 2016 at 1:45:41 AM UTC+1, Aaditya Kalsi wrote:

>> I have written a new implementation of malloc() and free() and

>> I have written it with the goals:
>>
>> 1. Easy to read and maintain.
>> 2. Be more memory conserving.
>> 3. High efficiency and good performance.
>> 4. Portability.
>>
>> I have a (I believe) working version with some tests and documentation
>> and am hoping for some feedback on design and implementation as well
>> as any other constructive feedback.
>>
>> Link to source:
>> https://github.com/akalsi87/akmalloc
>>
>> Link to documentation:
>> https://rawgit.com/akalsi87/akmalloc/1.0.1/_layouts/index.html
>>
>> The library is modeled close to dlmalloc because of its customizability
>> but in doing so I have tried to not obfuscate too much with macros.
>>
> The code will be far more useful if you can package it as one source
> file and one associated header,

I agree. It took me a couple of minutes' browsing every directory to 
find the C source files. But there are also many, many more .js files, 
.html, .png, .cpp, cmake, .yml, even a .py file. What is someone 
supposed to do with all those? There also appears to be a dependency on 
Cmake, whatever that is.

So it seems to fail on point one:

 >> 1. Easy to read and maintain.

As you say, a simple library might comprise:

   akmalloc.h
   akmalloc.c

plus a couple of documentation files.

Looking at more files, there appear to be some bash scripts, which 
doesn't bode well. What is someone to do with /those/, if they are 
running Windows for example?

What does the build process do, what does it produce? Is it a .lib, .so, 
.dll, or .obj? The only .c test program I could find seemed to be for Unix.

I wonder if most of this stuff is auto-generated by the OP's development 
system?

-- 
Bartc

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-16 17:45 -0700
  Re: Feedback for a malloc implementation Udyant Wig <udyant.wig@gmail.com> - 2016-07-17 12:22 +0530
    Re: Feedback for a malloc implementation Udyant Wig <udyant.wig@gmail.com> - 2016-07-17 17:58 +0530
      Re: Feedback for a malloc implementation BartC <bc@freeuk.com> - 2016-07-17 13:40 +0100
        Re: Feedback for a malloc implementation Udyant Wig <udyant.wig@gmail.com> - 2016-07-17 23:06 +0530
          Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 13:40 -0700
  Re: Feedback for a malloc implementation Malcolm McLean <malcolm.mclean5@btinternet.com> - 2016-07-17 00:30 -0700
    Re: Feedback for a malloc implementation BartC <bc@freeuk.com> - 2016-07-17 10:54 +0100
      Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 04:36 -0700
    Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 04:31 -0700
      Re: Feedback for a malloc implementation Malcolm McLean <malcolm.mclean5@btinternet.com> - 2016-07-17 11:40 -0700
        Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 13:41 -0700
  Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 07:02 -0700
    Re: Feedback for a malloc implementation BartC <bc@freeuk.com> - 2016-07-17 20:38 +0100
      Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 13:44 -0700
        Re: Feedback for a malloc implementation BartC <bc@freeuk.com> - 2016-07-17 22:19 +0100
          Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-17 18:08 -0700
    Re: Feedback for a malloc implementation Tim Rentsch <txr@alumni.caltech.edu> - 2016-07-18 09:40 -0700
      Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-18 10:48 -0700
        Re: Feedback for a malloc implementation Tim Rentsch <txr@alumni.caltech.edu> - 2016-07-20 08:45 -0700
          Re: Feedback for a malloc implementation Keith Thompson <kst-u@mib.org> - 2016-07-20 09:28 -0700
            Re: Feedback for a malloc implementation Tim Rentsch <txr@alumni.caltech.edu> - 2016-07-21 18:25 -0700
              Re: Feedback for a malloc implementation Aaditya Kalsi <aadityakalsi@gmail.com> - 2016-07-22 16:52 -0700

csiph-web