Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.c > #76053

Re: how to do this?

Show all headers | View raw

bilsch01 wrote:
> On 11/14/2015 03:07 PM, bilsch01 wrote:
>> On 11/14/2015 02:26 PM, Ian Collins wrote:
>>> bilsch01 wrote:
>>>
>>> One I missed earlier:
>>>
>>>> char mk1[9] = "**  1  **", mk2[9] = "**  2  **", mk3[9] = "**  3  **";
>>>
>>> These aren't null terminated strings.
>>>
>>>>
>>>>              if (strcmp(vec2, vec1) == 0)
>>>>                      strcpy(vec2, mk1);
>>>
>>> So this copy could go horribly wrong.
>>>
>> why isn't "**  1  **" a null terminated string?  How should I declare it
>> to make it null terminated?
>>
>> char "**  1  **",0
>>
>> I thought when you declare an array of type char it gets null terminated
>> if "" are used.

It does, but you were losing the terminator by copying into a 9 
character array.

>    Oh.  The vec1 , vec2 . . . aren't null terminated.  I don't see any
> way to fix that.

Your code as written implied that they were null terminated by using 
strxxx functions to compare and copy them.  I wasn't sure (because you 
didn't specify the file format) so in my re-write I used this function 
for the compare and copy:

const size_t itemSize = 9;

void
subsituteIfEqual( char* token, const char* key, const char* value )
{
   if( memcmp( token, key, itemSize ) == 0 )
   {
     memcpy( token, value, itemSize );
   }
}

To get meaningful rather than speculative replies, you must specify the 
format of the data files.

-- 
Ian Collins

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

how to do this? bilsch01 <king621@comcast.net> - 2015-11-14 12:09 -0800
  Re: how to do this? Rosario19 <Ros@invalid.invalid> - 2015-11-14 21:49 +0100
  Re: how to do this? Ian Collins <ian-news@hotmail.com> - 2015-11-15 10:02 +1300
    Re: how to do this? Ian Collins <ian-news@hotmail.com> - 2015-11-15 10:17 +1300
    Re: how to do this? bilsch01 <king621@comcast.net> - 2015-11-14 15:16 -0800
      Re: how to do this? James Kuyper <jameskuyper@verizon.net> - 2015-11-14 18:24 -0500
        Re: how to do this? bilsch01 <king621@comcast.net> - 2015-11-14 15:30 -0800
          Re: how to do this? Lew Pitcher <lew.pitcher@digitalfreehold.ca> - 2015-11-14 19:01 -0500
          Re: how to do this? James Kuyper <jameskuyper@verizon.net> - 2015-11-14 19:07 -0500
  Re: how to do this? Ian Collins <ian-news@hotmail.com> - 2015-11-15 11:26 +1300
    Re: how to do this? bilsch01 <king621@comcast.net> - 2015-11-14 15:07 -0800
      Re: how to do this? James Kuyper <jameskuyper@verizon.net> - 2015-11-14 18:17 -0500
      Re: how to do this? bilsch01 <king621@comcast.net> - 2015-11-14 15:25 -0800
        Re: how to do this? Ian Collins <ian-news@hotmail.com> - 2015-11-15 13:10 +1300
          Re: how to do this? James Kuyper <jameskuyper@verizon.net> - 2015-11-14 19:21 -0500
            Re: how to do this? Ian Collins <ian-news@hotmail.com> - 2015-11-15 13:24 +1300
        Re: how to do this? James Kuyper <jameskuyper@verizon.net> - 2015-11-14 19:12 -0500
          Re: how to do this? Ian Collins <ian-news@hotmail.com> - 2015-11-15 13:18 +1300
            Re: how to do this? James Kuyper <jameskuyper@verizon.net> - 2015-11-14 19:23 -0500
  Re: how to do this? bilsch01 <king621@comcast.net> - 2015-11-14 15:18 -0800

csiph-web