Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.c > #21392

Re: Open letter to Ian Collins

Show key headers only | View raw

Malcolm McLean wrote:
> 
> בתאריך יום שבת, 26 במאי 2012 23:36:29 UTC+1, מאת Ike Naar:
> >
> > This seems dangerous. iList.Add expects a pointer to an
> > int for the second argument, and it receives a pointer to
> > a size_t. What if int and size_t have different sizes?
> >
> Yes, size_t is a menace. I've been saying that for a while.
> The problem is that programmers are unwilling to use it consistently.
> If you want an integer, you type int.

In this case, I don't think that (size_t)
was the best choice for either (i) or (d).

(i) was counting nodes in a list
and the standard definition of what (size_t) is supposed to be,
isn't related to how many nodes can be in a list.
I think I would have used the largest unsigned integer type for (i).

(d) was assigned the return value of rand(),
so (int) is the type that would first occur to me to use for (d).

Unsigned integer types would have been the first thing
to occur to me to use for the checksums.

And even though nobody wants to see it,
this is how I would have written a program like that in C:

http://www.mindspring.com/~pfilandr/C/lists_and_files/list_lib.h 
http://www.mindspring.com/~pfilandr/C/lists_and_files/list_lib.c 
http://www.mindspring.com/~pfilandr/C/lists_and_files/list_type.h 



/* BEGIN new.c */

#include "list_lib.h"

#include <stdio.h>
#include <stdlib.h>

#define N 1000000

#define str(s)          # s
#define xstr(s)         str(s)

int int_comp(const void *a, const void *b);

int 
main(void)
{
    int d, *d_ptr;
    long unsigned i;
    unsigned old_checksum = 0;
    unsigned new_checksum = 0;
    list_type *head = NULL;
    list_type *tail = NULL;
    

    puts("/* BEGIN output new.c */\n\nN is " xstr(N) "\n");
    for (i = 0; i != N; ++i) {
        d = rand();
        old_checksum += d;
        tail = list_append(&head, tail, &d, sizeof d);
        if (tail == NULL) {
            puts("tail == NULL");
            printf("list only contains %lu nodes,\n\n", i);
            break;
        }
    }
    tail = head = list_sort(head, int_comp);    
    while (tail != NULL) {
        d_ptr = tail -> data;
        d = *d_ptr;
        new_checksum += d;
        tail = tail -> next;
        if (tail != NULL && int_comp(d_ptr, tail -> data) > 0) {
            puts("list is out of order\n");
            break;            
        }
    }
    list_free(head, free);
    head = tail = NULL;
    printf("old_checksum is %lu.\n", old_checksum);
    printf("new_checksum is %lu.\n", new_checksum);
    puts("\n/* END output new.c */");
    return 0;
}

int 
int_comp(const void *a, const void *b)
{
    const int *const aa = a;
    const int *const bb = b;

    return *bb > *aa ? -1 : *bb != *aa;
}

/* END new.c */


-- 
pete

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 00:22 +0200
  Re: Open letter to Ian Collins Ike Naar <ike@sverige.freeshell.org> - 2012-05-26 22:36 +0000
    Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 01:13 +0200
      Re: Open letter to Ian Collins Barry Schwarz <schwarzb@dqel.com> - 2012-05-26 16:53 -0700
    Re: Open letter to Ian Collins Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-05-26 16:41 -0700
      Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-26 22:43 -0400
  Re: Open letter to Ian Collins Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-05-26 15:41 -0700
    Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 01:14 +0200
  Re: Open letter to Ian Collins MelissA <melis@a.com> - 2012-05-27 00:52 +0200
  Re: Open letter to Ian Collins Stephen Sprunk <stephen@sprunk.org> - 2012-05-26 20:40 -0500
    Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 09:32 +0200
      Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-27 07:18 -0400
  Re: Open letter to Ian Collins Ian Collins <ian-news@hotmail.com> - 2012-05-27 14:24 +1200
    Re: Open letter to Ian Collins "BartC" <bc@freeuk.com> - 2012-05-27 10:36 +0100
      Re: Open letter to Ian Collins Ian Collins <ian-news@hotmail.com> - 2012-05-27 22:33 +1200
        Re: Open letter to Ian Collins "BartC" <bc@freeuk.com> - 2012-05-27 12:25 +0100
          Re: Open letter to Ian Collins Ian Collins <ian-news@hotmail.com> - 2012-05-28 07:17 +1200
      Re: Open letter to Ian Collins Ike Naar <ike@sverige.freeshell.org> - 2012-05-27 13:03 +0000
  Re: Open letter to Ian Collins Ian Collins <ian-news@hotmail.com> - 2012-05-27 15:16 +1200
    Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 09:30 +0200
      Re: Open letter to Ian Collins Ian Collins <ian-news@hotmail.com> - 2012-05-27 20:56 +1200
        Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 11:12 +0200
          Re: Open letter to Ian Collins Ian Collins <ian-news@hotmail.com> - 2012-05-27 21:22 +1200
            Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-27 07:15 -0400
            Re: Open letter to Ian Collins Keith Thompson <kst-u@mib.org> - 2012-05-27 07:49 -0700
              Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-27 13:55 -0400
                Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 22:24 +0200
                Re: Open letter to Ian Collins "BartC" <bc@freeuk.com> - 2012-05-27 22:09 +0100
                Re: Open letter to Ian Collins Keith Thompson <kst-u@mib.org> - 2012-05-27 14:33 -0700
                Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-27 17:49 -0400
                Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-27 17:31 -0400
                Re: Open letter to Ian Collins Philip Lantz <prl@canterey.us> - 2012-05-28 01:38 -0700
                Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-05-28 08:18 -0400
        Re: Open letter to Ian Collins "BartC" <bc@freeuk.com> - 2012-05-27 15:46 +0100
        Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-06-13 21:25 -0400
          Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-06-13 21:52 -0400
          Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-06-14 04:00 +0200
            Re: Open letter to Ian Collins pete <pfiland@mindspring.com> - 2012-06-14 00:04 -0400
  Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-27 09:42 +0200
  Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-28 12:39 +0200
    Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-28 21:44 +0200
      Re: Open letter to Ian Collins jacob navia <jacob@spamsink.net> - 2012-05-29 09:46 +0200
        Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-29 10:06 +0200
          Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-29 10:37 +0200
            Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-29 10:58 +0200
              Re: Open letter to Ian Collins "Joachim Schmitz" <nospam.jojo@schmitz-digital.de> - 2012-05-29 11:34 +0200
              Re: Open letter to Ian Collins Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-05-29 03:02 -0700
      Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-29 09:59 +0200
      Re: Open letter to Ian Collins "io_x" <a@b.c.invalid> - 2012-05-29 20:09 +0200
  Re: Open letter to Ian Collins "Sarah Wren" <swreb@ameritech.net> - 2012-05-29 01:40 -0600

csiph-web