Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.c++ > #82762

Re: Can anyone improve this ?

Path csiph.com!eternal-september.org!reader02.eternal-september.org!.POSTED!not-for-mail
From Ben Bacarisse <ben.usenet@bsb.me.uk>
Newsgroups comp.lang.c++
Subject Re: Can anyone improve this ?
Date Wed, 12 Jan 2022 16:55:04 +0000
Organization A noiseless patient Spider
Lines 38
Message-ID <8735ls7v2v.fsf@bsb.me.uk> (permalink)
References <srjdtm$d9c$1@dont-email.me> <srkqk6$mtr$1@dont-email.me> <srmkil$pjh$2@dont-email.me> <87ee5d6ny8.fsf@bsb.me.uk> <srmv4n$8av$1@dont-email.me>
Mime-Version 1.0
Content-Type text/plain
Injection-Info reader02.eternal-september.org; posting-host="5ba9621590a2da72bfffdfe0eaabd98b"; logging-data="22936"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX19w/voqF/iKvC7H8mznBvxdgxlmHdt2VFU="
Cancel-Lock sha1:GXfuUAvP3AV69A1CzZ8UyxXcGl4= sha1:WBlMB6+xuBi6dHhLJdcdy+m4a6k=
X-BSB-Auth 1.6c5d99101df7a7ffdc44.20220112165504GMT.8735ls7v2v.fsf@bsb.me.uk
Xref csiph.com comp.lang.c++:82762

Show key headers only | View raw


Bonita Montero <Bonita.Montero@gmail.com> writes:

> Am 12.01.2022 um 15:14 schrieb Ben Bacarisse:
>> Bonita Montero <Bonita.Montero@gmail.com> writes:
>> 
>>> sizes instead of size; corrected:
>>>
>>> size_t utf8Strlen( char const *str )
>>> {
>>> 	static size_t const sizes[8] = { 1, 0, 2, 3, 4, 0, 0, 0 };
>>> 	size_t len = 0;
>>> 	for( unsigned char c; (c = *str); )
>>> 	{
>>> 		size_t size = sizes[countl_zero<unsigned char>( ~c )];
>>> 		if( !size ) [[unlikely]]
>>> 			return -1;
>>> 		++len;
>>> 		for( char const *cpEnd = str + size; ++str != cpEnd; )
>>> 			if( ((unsigned char)*str & 0x0C0) != 0x080 ) [[unlikely]]
>>> 				return -1;
>>> 	}
>>> 	return len;
>>> }
>> You reject simpler solutions because they don't detect the one error you
>> have decided to look for. ...
>
> I think that's ok

Obviously.

>> There are other encoding errors that this code won't catch.
>
> Not at the UTF-8 level.

Not so.

-- 
Ben.

Back to comp.lang.c++ | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-11 09:08 +0100
  Re: Can anyone improve this ? Juha Nieminen <nospam@thanks.invalid> - 2022-01-11 09:50 +0000
    Re: Can anyone improve this ? Juha Nieminen <nospam@thanks.invalid> - 2022-01-11 11:07 +0000
    Re: Can anyone improve this ? Ben Bacarisse <ben.usenet@bsb.me.uk> - 2022-01-11 11:08 +0000
    Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-11 18:28 +0100
      Re: Can anyone improve this ? Christian Gollwitzer <auriocus@gmx.de> - 2022-01-11 18:41 +0100
        Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-11 19:36 +0100
      Re: Can anyone improve this ? Öö Tiib <ootiib@hot.ee> - 2022-01-11 21:54 -0800
  Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-11 21:51 +0100
    Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-12 14:19 +0100
    Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-12 14:20 +0100
      Re: Can anyone improve this ? Ben Bacarisse <ben.usenet@bsb.me.uk> - 2022-01-12 14:14 +0000
        Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-12 17:20 +0100
          Re: Can anyone improve this ? "james...@alumni.caltech.edu" <jameskuyper@alumni.caltech.edu> - 2022-01-12 08:38 -0800
          Re: Can anyone improve this ? Ben Bacarisse <ben.usenet@bsb.me.uk> - 2022-01-12 16:55 +0000
        Re: Can anyone improve this ? Tim Rentsch <tr.17687@z991.linuxsc.com> - 2022-01-16 12:09 -0800
        Re: Can anyone improve this ? Tim Rentsch <tr.17687@z991.linuxsc.com> - 2022-01-16 12:12 -0800
          Re: Can anyone improve this ? Öö Tiib <ootiib@hot.ee> - 2022-01-16 13:00 -0800
            Re: Can anyone improve this ? Tim Rentsch <tr.17687@z991.linuxsc.com> - 2022-01-17 10:13 -0800
  Re: Can anyone improve this ? Tim Rentsch <tr.17687@z991.linuxsc.com> - 2022-01-17 10:28 -0800
    Re: Can anyone improve this ? "Alf P. Steinbach" <alf.p.steinbach@gmail.com> - 2022-01-17 21:51 +0100
      Re: Can anyone improve this ? Tim Rentsch <tr.17687@z991.linuxsc.com> - 2022-01-17 16:16 -0800
      Re: Can anyone improve this ? Tim Rentsch <tr.17687@z991.linuxsc.com> - 2022-01-17 22:43 -0800
        Re: Can anyone improve this ? "Alf P. Steinbach" <alf.p.steinbach@gmail.com> - 2022-01-18 12:09 +0100
    Re: Can anyone improve this ? Bonita Montero <Bonita.Montero@gmail.com> - 2022-01-18 09:18 +0100

csiph-web