Re: Code review?

References	<13BCC15D-B1E0-4AB2-9641-673D5B1B6FDD@gmail.com>
Date	2014-01-14 03:40 +1100
Subject	Re: Code review?
From	Chris Angelico <rosuav@gmail.com>
Newsgroups	comp.lang.python
Message-ID	<mailman.5412.1389631229.18130.python-list@python.org> (permalink)

Show all headers | View raw

On Tue, Jan 14, 2014 at 3:29 AM, Adam <sk82712@gmail.com> wrote:
> Hey all.  New to the list.  I’m working on a web app with 2.6 and Flask.  I’m still relatively new to python.  Is there a chance to get a code review from anyone?  I really want someone to just tear up my code and tell me how to increase my efficiency and what I’m doing wrong (and how to upload images via a form in Flask, but that’s another story).
>

Definitely! Preferably, post your code in-line; if it's too long for
that, post it someplace else and link to it. Be sure not to damage
indentation, of course, but no matter how new you are to Python you'll
know that!

Incidentally, is there a reason you're using Python 2.6? You should be
able to upgrade at least to 2.7, and Flask ought to work fine on 3.3
(the current stable Python). If it's the beginning of your project,
and you have nothing binding you to Python 2, go with Python 3.
Converting a small project now will save you the job of converting a
big project in ten years' time :)

ChrisA

Back to comp.lang.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Code review? Chris Angelico <rosuav@gmail.com> - 2014-01-14 03:40 +1100
  Re: Code review? Steven D'Aprano <steve@pearwood.info> - 2014-01-13 20:43 +0000
    Re: Code review? Chris Angelico <rosuav@gmail.com> - 2014-01-14 10:34 +1100
      Re: Code review? Bob Martin <bob.martin@excite.com> - 2014-01-14 07:22 +0000
        Re: Code review? Bayram Güçlü <byrmgcl@yandex.com.tr> - 2014-01-14 11:29 +0400
        Re: Code review? Chris Angelico <rosuav@gmail.com> - 2014-01-14 18:36 +1100

csiph-web