Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.c > #26626

Re: Code review requested

Show all headers | View raw

Ian Collins <ian-news@hotmail.com> writes:
> On 09/24/12 10:39, Keith Thompson wrote:
>> Öö Tiib<ootiib@hot.ee>  writes:
>>> On Sunday, 23 September 2012 13:50:03 UTC+3, David Brown  wrote:
>> [...]
>>>> The only time I would write "struct table;" would be to define a forward
>>>> declaration for lists, trees, etc.  And then I would later write
>>>>
>>>> "typedef struct table table;"
>>>
>>> The additinal bonus when you do that is that C++ does exactly the
>>> same typedef implicitly. C++ compiler has to compile if it is said
>>> out explicitly as well. As result you can use the definition in both
>>> languages:
>>>
>>>    typedef struct table { ... } table;
>>>
>>> No additional preprocessor magic is needed.
>>
>> Personally, I wouldn't bother with the typedef either in C or in C++.
>> In C I'd refer to the type as "struct table"; in C++, I'd refer to
>> it as "table".
>
> Why?  It looks like you are making extra work for your self for no
> good reason.

Typing "struct" every now and then isn't that much extra work
-- and it avoids the extra work of defining a typedef.  And I
don't consider it to be for no reason; it makes the code clearer.
It's not a huge deal; I don't *object* to typedefs for structs.
I just consider them unnecessary.

Note that FILE is an example of a typedef that I do consider to be
appropriate; client code shouldn't depend on the fact that it's a struct
(assuming that it even is one).

-- 
Keith Thompson (The_Other_Keith) kst-u@mib.org  <http://www.ghoti.net/~kst>
    Will write code for food.
"We must do something.  This is something.  Therefore, we must do this."
    -- Antony Jay and Jonathan Lynn, "Yes Minister"

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Code review requested bart.vandewoestyne@gmail.com - 2012-09-20 02:27 -0700
  Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-20 11:44 +0100
    Re: Code review requested Bart Vandewoestyne <bart.vandewoestyne@gmail.com> - 2012-09-20 08:30 -0700
      Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-20 16:48 +0100
        Re: Code review requested Bart Vandewoestyne <bart.vandewoestyne@gmail.com> - 2012-09-20 13:38 -0700
        Re: Code review requested Bart Vandewoestyne <MyFirstName.MyLastName@telenet.be> - 2012-09-20 23:00 +0200
      Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-20 09:02 -0700
        Re: Code review requested Bart Vandewoestyne <MyFirstName.MyLastName@telenet.be> - 2012-09-20 23:13 +0200
          Re: Code review requested Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-09-22 22:16 +0000
        Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-20 16:54 -0700
          Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-21 12:10 -0700
          Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-23 12:47 +0200
            Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-23 03:54 -0700
            Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-23 14:07 +0100
            Re: Code review requested Öö Tiib <ootiib@hot.ee> - 2012-09-23 15:13 -0700
              Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-23 15:39 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-24 10:46 +1200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-23 17:30 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-24 14:05 +1200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 00:26 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 11:03 +0200
                Re: Code review requested Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-09-24 09:16 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 18:25 +0200
                Re: Code review requested Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-09-25 04:49 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-25 07:41 +1200
                Re: Code review requested James Kuyper <jameskuyper@verizon.net> - 2012-09-24 15:50 -0400
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-25 09:30 +1200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 12:45 -0700
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 16:10 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-25 09:02 +0200
                Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-24 10:47 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 13:41 +0200
                Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-24 13:40 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 15:31 +0200
                Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-24 15:14 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 17:40 +0200
                Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-24 18:11 +0100
                Re: Code review requested Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-09-24 11:13 -0700
                Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-24 20:52 +0100
                Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-24 16:22 +0100
                Re: Code review requested Rui Maciel <rui.maciel@gmail.com> - 2012-09-24 16:46 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 18:22 +0200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 12:52 -0700
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 13:59 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 08:43 +0200
                Re: Code review requested Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-09-23 16:03 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-24 11:10 +1200
        Re: Code review requested Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-09-24 00:49 -0700
      Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-21 07:19 +1200
        Re: Code review requested Bart Vandewoestyne <bart.vandewoestyne@gmail.com> - 2012-09-20 13:29 -0700
          Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-20 13:48 -0700
            Re: Code review requested James Kuyper <jameskuyper@verizon.net> - 2012-09-20 17:09 -0400
              Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-20 14:52 -0700
                Re: Code review requested James Kuyper <jameskuyper@verizon.net> - 2012-09-20 18:48 -0400
                Re: Code review requested Francois Grieu <fgrieu@gmail.com> - 2012-09-21 09:53 +0200
                Re: Code review requested Walter Banks <walter@bytecraft.com> - 2012-10-01 07:43 -0400
                Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-21 08:55 -0700
          Re: Code review requested Eric Sosman <esosman@ieee-dot-org.invalid> - 2012-09-20 16:59 -0400
            Re: Code review requested hormelfree@gmail.com - 2012-09-20 17:39 -0700
          Re: Code review requested Rui Maciel <rui.maciel@gmail.com> - 2012-09-20 23:23 +0100
            Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-20 16:48 -0700

csiph-web