Re: Code review requested

From	Ian Collins <ian-news@hotmail.com>
Newsgroups	comp.lang.c
Subject	Re: Code review requested
Date	2012-09-21 07:19 +1200
Message-ID	<ac18hdFivfbU2@mid.individual.net> (permalink)
References	<5eb6a1dd-71f6-45d0-8ac9-9d4a2f3c6724@googlegroups.com> <0.fe11e41ad28c722214fc.20120920114453BST.87392d6kii.fsf@bsb.me.uk> <92123780-8ef0-48b3-b237-58f4e706f5da@googlegroups.com>

Show all headers | View raw

On 09/21/12 03:30 AM, Bart Vandewoestyne wrote:

[wrapping yours lines on Usenet is good practice]

> Using assert(0) at 'unreachable' places indeed seemed like the best and cleanest solution to me.  It makes the warnings go away and on top of that, i get extra debugging facilities.

Rather than assert(0), I prefer assert(!"Some useful diagnostic").  This 
helps you when it fires and documents why the assert is there in the code.

-- 
Ian Collins

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Code review requested bart.vandewoestyne@gmail.com - 2012-09-20 02:27 -0700
  Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-20 11:44 +0100
    Re: Code review requested Bart Vandewoestyne <bart.vandewoestyne@gmail.com> - 2012-09-20 08:30 -0700
      Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-20 16:48 +0100
        Re: Code review requested Bart Vandewoestyne <bart.vandewoestyne@gmail.com> - 2012-09-20 13:38 -0700
        Re: Code review requested Bart Vandewoestyne <MyFirstName.MyLastName@telenet.be> - 2012-09-20 23:00 +0200
      Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-20 09:02 -0700
        Re: Code review requested Bart Vandewoestyne <MyFirstName.MyLastName@telenet.be> - 2012-09-20 23:13 +0200
          Re: Code review requested Jorgen Grahn <grahn+nntp@snipabacken.se> - 2012-09-22 22:16 +0000
        Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-20 16:54 -0700
          Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-21 12:10 -0700
          Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-23 12:47 +0200
            Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-23 03:54 -0700
            Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-23 14:07 +0100
            Re: Code review requested Öö Tiib <ootiib@hot.ee> - 2012-09-23 15:13 -0700
              Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-23 15:39 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-24 10:46 +1200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-23 17:30 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-24 14:05 +1200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 00:26 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 11:03 +0200
                Re: Code review requested Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-09-24 09:16 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 18:25 +0200
                Re: Code review requested Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-09-25 04:49 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-25 07:41 +1200
                Re: Code review requested James Kuyper <jameskuyper@verizon.net> - 2012-09-24 15:50 -0400
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-25 09:30 +1200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 12:45 -0700
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 16:10 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-25 09:02 +0200
                Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-24 10:47 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 13:41 +0200
                Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-24 13:40 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 15:31 +0200
                Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-24 15:14 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 17:40 +0200
                Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-24 18:11 +0100
                Re: Code review requested Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-09-24 11:13 -0700
                Re: Code review requested Ben Bacarisse <ben.usenet@bsb.me.uk> - 2012-09-24 20:52 +0100
                Re: Code review requested "BartC" <bc@freeuk.com> - 2012-09-24 16:22 +0100
                Re: Code review requested Rui Maciel <rui.maciel@gmail.com> - 2012-09-24 16:46 +0100
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 18:22 +0200
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 12:52 -0700
                Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-24 13:59 -0700
                Re: Code review requested David Brown <david@westcontrol.removethisbit.com> - 2012-09-24 08:43 +0200
                Re: Code review requested Malcolm McLean <malcolm.mclean5@btinternet.com> - 2012-09-23 16:03 -0700
                Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-24 11:10 +1200
        Re: Code review requested Nick Keighley <nick_keighley_nospam@hotmail.com> - 2012-09-24 00:49 -0700
      Re: Code review requested Ian Collins <ian-news@hotmail.com> - 2012-09-21 07:19 +1200
        Re: Code review requested Bart Vandewoestyne <bart.vandewoestyne@gmail.com> - 2012-09-20 13:29 -0700
          Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-20 13:48 -0700
            Re: Code review requested James Kuyper <jameskuyper@verizon.net> - 2012-09-20 17:09 -0400
              Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-20 14:52 -0700
                Re: Code review requested James Kuyper <jameskuyper@verizon.net> - 2012-09-20 18:48 -0400
                Re: Code review requested Francois Grieu <fgrieu@gmail.com> - 2012-09-21 09:53 +0200
                Re: Code review requested Walter Banks <walter@bytecraft.com> - 2012-10-01 07:43 -0400
                Re: Code review requested ImpalerCore <jadill33@gmail.com> - 2012-09-21 08:55 -0700
          Re: Code review requested Eric Sosman <esosman@ieee-dot-org.invalid> - 2012-09-20 16:59 -0400
            Re: Code review requested hormelfree@gmail.com - 2012-09-20 17:39 -0700
          Re: Code review requested Rui Maciel <rui.maciel@gmail.com> - 2012-09-20 23:23 +0100
            Re: Code review requested Keith Thompson <kst-u@mib.org> - 2012-09-20 16:48 -0700

csiph-web