Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #17184 > unrolled thread

Re: python-lsp-server new upstream version

Back to article view | Back to linux.debian.maint.python

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: python-lsp-server new upstream version Jochen Sprickerhof <jspricke@debian.org> - 2025-11-21 11:30 +0100
    Re: python-lsp-server new upstream version Andrey Rakhmatullin <wrar@debian.org> - 2025-11-22 10:10 +0100
      Re: python-lsp-server new upstream version Andrey Rakhmatullin <wrar@debian.org> - 2025-11-22 16:40 +0100
        Re: python-lsp-server new upstream version Andrey Rakhmatullin <wrar@debian.org> - 2025-11-22 17:50 +0100
    Re: python-lsp-server new upstream version Julian Gilbey <jdg@debian.org> - 2025-11-23 09:50 +0100
      Re: Spyder with loosen versions of python-lsp-server Julian Gilbey <jdg@debian.org> - 2025-11-25 08:00 +0100

#17184 — Re: python-lsp-server new upstream version

[Multipart message — attachments visible in raw view] — view raw

Hi Aeliton,

thanks for working on this. python-lsp-server is version locked by 
python3-spyder and needs coordination with Julian (Cc).

@Julian: can we get a new version in?

* Aeliton G. Silva <aeliton@aeliton.com> [2025-11-21 06:06]:
>I managed to create a working package for python-lsp-server using the
>upstream version 1.13.2 and I'd like to check if everything looks good.
>
>According to [1] the next steps would be:
>
>$ git push origin : --tags
>
>but I'm not sure I should do that before any of the maintainers have a
>look at what I did.

quoting form the wiki:

| Once you've built and uploaded your package,

Note the "uploaded" (to the Debian archive). So you should not tag.

>From 9dabd3961d8e2383cfdbb58620fa41e2dc0ea0d4 Mon Sep 17 00:00:00 2001
>From: Aeliton Silva <aeliton@aeliton.com>
>Date: Fri, 21 Nov 2025 05:14:56 -0300
>Subject: [PATCH 6/7] Add python3-websockets as build dependency
>
>---
> debian/control | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/debian/control b/debian/control
>index 9d9d026..e18920f 100644
>--- a/debian/control
>+++ b/debian/control
>@@ -28,6 +28,7 @@ Build-Depends: black,
>                python3-setuptools,
>                python3-setuptools-scm,
>                python3-ujson,
>+               python3-websockets,

Can you test if this is a test only dependency and can be annotated 
with <!nocheck>?

>From acbc33166e43dae829175d1ddd54bc6cc831be67 Mon Sep 17 00:00:00 2001
>From: Aeliton Silva <aeliton@aeliton.com>
>Date: Fri, 21 Nov 2025 05:14:11 -0300
>Subject: [PATCH 4/7] Add black as a build dependency
>
>---
> debian/control | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/debian/control b/debian/control
>index b052494..e012904 100644
>--- a/debian/control
>+++ b/debian/control
>@@ -5,7 +5,8 @@ Maintainer: Debian Python Team <team+python@tracker.debian.org>
> Uploaders: Pablo Mestre Drake <pmdcuba@gmail.com>,
>            Julian Gilbey <jdg@debian.org>,
>            Jochen Sprickerhof <jspricke@debian.org>
>-Build-Depends: debhelper-compat (= 13),
>+Build-Depends: black,

Dito here.

>From bdc87285ab9a12b6e06d858de93e287aadc09cde Mon Sep 17 00:00:00 2001
>From: Aeliton Silva <aeliton@aeliton.com>
>Date: Fri, 21 Nov 2025 05:12:09 -0300
>Subject: [PATCH 3/7] Skip test that hangs
>
>---
> .../0004-Disable-test-that-hangs.patch        | 21 +++++++++++++++++++
> debian/patches/series                         |  1 +
> 2 files changed, 22 insertions(+)
> create mode 100644 debian/patches/0004-Disable-test-that-hangs.patch
>
>diff --git a/debian/patches/0004-Disable-test-that-hangs.patch b/debian/patches/0004-Disable-test-that-hangs.patch
>new file mode 100644
>index 0000000..d2b417d
>--- /dev/null
>+++ b/debian/patches/0004-Disable-test-that-hangs.patch
>@@ -0,0 +1,21 @@
>+From: Aeliton Silva <aeliton@aeliton.com>
>+Date: Fri, 21 Nov 2025 03:32:11 -0300
>+Subject: Disable test that hangs
>+
>+---
>+ test/test_language_server.py | 2 +-
>+ 1 file changed, 1 insertion(+), 1 deletion(-)
>+
>+diff --git a/test/test_language_server.py b/test/test_language_server.py
>+index 9b36211..2b41ba9 100644
>+--- a/test/test_language_server.py
>++++ b/test/test_language_server.py
>+@@ -77,7 +77,7 @@ def test_not_exit_without_check_parent_process_flag(
>+ 
>+ 
>+ @flaky(max_runs=10, min_passes=1)
>+-@pytest.mark.skipif(RUNNING_IN_CI, reason="This test is hanging on CI")
>++@pytest.mark.skip(reason="This test is hanging on CI")
>+ def test_missing_message(client_server_pair) -> None:

Please add the test in d/rules instead.

Cheers Jochen

[toc] | [next] | [standalone]

#17185

[Multipart message — attachments visible in raw view] — view raw

On Fri, Nov 21, 2025 at 07:01:51PM -0300, Aeliton G. Silva wrote:
>> quoting form the wiki:
>>
>> > Once you've built and uploaded your package,
>>
>> Note the "uploaded" (to the Debian archive). So you should not tag.
>
>I want to be extra careful to not disturb anyone, so I'd like to
>clarify: is the upload to Debian archive done with 'git push origin : -
>-tags'?

No, the upload to Debian archive is only done by your sponsor.

>This is what the wiki says about the upload, which seems to be
>equivalent:
>
>"""
>
>Uploading
>
>Push your repo to salsa.debian.org:

This is not about uploading to the archive.

>And is the tagging that I should not do what the wiki says in the
>tagging section?
>
>
>$ gbp buildpackage --git-tag-only
>$ git push --tags

Yes.

>>
>> Can you test if this is a test only dependency and can be annotated
>> with <!nocheck>?
>>
>
>Good shout, thanks. websockets are in the [project.optional-
>dependencies] in the pyproject.toml of the upstream, so I assume it
>should be annotated with <!nocheck>.

What matters is whether it's used for building or just for testing and 
whether the package builds fine with the nocheck build profile after your 
changes. You shouldn't just guess.

-- 
WBR, wRAR

[toc] | [prev] | [next] | [standalone]

#17190

[Multipart message — attachments visible in raw view] — view raw

On Sat, Nov 22, 2025 at 12:30:29PM -0300, Aeliton G. Silva wrote:
>> No, the upload to Debian archive is only done by your sponsor.
>>
>> >
>> > Push your repo to salsa.debian.org:
>>
>> This is not about uploading to the archive.
>>
>
>Thanks for the clarifications Andrey.
>
>About pushing it to salsa, can I do it or this should also be done by a
>sponsor?

You should push but not tag.

>> > > Can you test if this is a test only dependency and can be
>> > > annotated
>> > > with <!nocheck>?
>> > >
>> >
>> > Good shout, thanks. websockets are in the [project.optional-
>> > dependencies] in the pyproject.toml of the upstream, so I assume it
>> > should be annotated with <!nocheck>.
>>
>> What matters is whether it's used for building or just for testing
>> and
>> whether the package builds fine with the nocheck build profile after
>> your
>> changes. You shouldn't just guess.
>
>If I remove either black or python3-websockets from debian/control, gbp
>buildpackage will succeed creating python_lsp_server-1.13.2-py3-none-
>any.whl, but the test session will fail when any of the packages is not
>installed.
>
>The debian package builds normally after annotating both dependencies
>with <!nocheck>.

Still, it's a bad idea to annotate deps with a build profile without 
actually testing it.


-- 
WBR, wRAR

[toc] | [prev] | [next] | [standalone]

#17191

[Multipart message — attachments visible in raw view] — view raw

On Sat, Nov 22, 2025 at 01:39:05PM -0300, Aeliton G. Silva wrote:
>$ export DEB_BUILD_OPTIONS=nocheck
>$ export DEB_BUILD_OPTIONS="nocheck"
>$ gbp buildpackage

Unless the build runs in a minimal chroot, this test doesn't make sure that 
the optional deps aren't installed.
I also can't say if this actually uses the build profile or not.

-- 
WBR, wRAR

[toc] | [prev] | [next] | [standalone]

#17192

Dear all,

I'm completely overwhelmed with work at present.  I should be able to
get some time to work on Spyder over the winter holidays, though.  So
feel free to upload python-lsp-server (and you could always upload
spyder with a loosened dependency in the meantime).

Best wishes,

   Julian

On Fri, Nov 21, 2025 at 11:20:13AM +0100, Jochen Sprickerhof wrote:
> Hi Aeliton,
> 
> thanks for working on this. python-lsp-server is version locked by
> python3-spyder and needs coordination with Julian (Cc).
> 
> @Julian: can we get a new version in?
> 
> * Aeliton G. Silva <aeliton@aeliton.com> [2025-11-21 06:06]:
> > I managed to create a working package for python-lsp-server using the
> > upstream version 1.13.2 and I'd like to check if everything looks good.
> > 
> > According to [1] the next steps would be:
> > 
> > $ git push origin : --tags
> > 
> > but I'm not sure I should do that before any of the maintainers have a
> > look at what I did.
> 
> quoting form the wiki:
> 
> | Once you've built and uploaded your package,
> 
> Note the "uploaded" (to the Debian archive). So you should not tag.
> 
> > > From 9dabd3961d8e2383cfdbb58620fa41e2dc0ea0d4 Mon Sep 17 00:00:00 2001
> > From: Aeliton Silva <aeliton@aeliton.com>
> > Date: Fri, 21 Nov 2025 05:14:56 -0300
> > Subject: [PATCH 6/7] Add python3-websockets as build dependency
> > 
> > ---
> > debian/control | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/debian/control b/debian/control
> > index 9d9d026..e18920f 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -28,6 +28,7 @@ Build-Depends: black,
> >                python3-setuptools,
> >                python3-setuptools-scm,
> >                python3-ujson,
> > +               python3-websockets,
> 
> Can you test if this is a test only dependency and can be annotated with
> <!nocheck>?
> 
> > > From acbc33166e43dae829175d1ddd54bc6cc831be67 Mon Sep 17 00:00:00 2001
> > From: Aeliton Silva <aeliton@aeliton.com>
> > Date: Fri, 21 Nov 2025 05:14:11 -0300
> > Subject: [PATCH 4/7] Add black as a build dependency
> > 
> > ---
> > debian/control | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/debian/control b/debian/control
> > index b052494..e012904 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -5,7 +5,8 @@ Maintainer: Debian Python Team <team+python@tracker.debian.org>
> > Uploaders: Pablo Mestre Drake <pmdcuba@gmail.com>,
> >            Julian Gilbey <jdg@debian.org>,
> >            Jochen Sprickerhof <jspricke@debian.org>
> > -Build-Depends: debhelper-compat (= 13),
> > +Build-Depends: black,
> 
> Dito here.
> 
> > > From bdc87285ab9a12b6e06d858de93e287aadc09cde Mon Sep 17 00:00:00 2001
> > From: Aeliton Silva <aeliton@aeliton.com>
> > Date: Fri, 21 Nov 2025 05:12:09 -0300
> > Subject: [PATCH 3/7] Skip test that hangs
> > 
> > ---
> > .../0004-Disable-test-that-hangs.patch        | 21 +++++++++++++++++++
> > debian/patches/series                         |  1 +
> > 2 files changed, 22 insertions(+)
> > create mode 100644 debian/patches/0004-Disable-test-that-hangs.patch
> > 
> > diff --git a/debian/patches/0004-Disable-test-that-hangs.patch b/debian/patches/0004-Disable-test-that-hangs.patch
> > new file mode 100644
> > index 0000000..d2b417d
> > --- /dev/null
> > +++ b/debian/patches/0004-Disable-test-that-hangs.patch
> > @@ -0,0 +1,21 @@
> > +From: Aeliton Silva <aeliton@aeliton.com>
> > +Date: Fri, 21 Nov 2025 03:32:11 -0300
> > +Subject: Disable test that hangs
> > +
> > +---
> > + test/test_language_server.py | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/test/test_language_server.py b/test/test_language_server.py
> > +index 9b36211..2b41ba9 100644
> > +--- a/test/test_language_server.py
> > ++++ b/test/test_language_server.py
> > +@@ -77,7 +77,7 @@ def test_not_exit_without_check_parent_process_flag(
> > + + + @flaky(max_runs=10, min_passes=1)
> > +-@pytest.mark.skipif(RUNNING_IN_CI, reason="This test is hanging on CI")
> > ++@pytest.mark.skip(reason="This test is hanging on CI")
> > + def test_missing_message(client_server_pair) -> None:
> 
> Please add the test in d/rules instead.
> 
> Cheers Jochen

[toc] | [prev] | [next] | [standalone]

#17197 — Re: Spyder with loosen versions of python-lsp-server

Hi Aeliton,

On Tue, Nov 25, 2025 at 12:55:31AM -0300, Aeliton G. Silva wrote:
> Hi Jochen and all,
> 
> I appreciate that Julian is quite busy. I'll leave him in CC just in
> case he wants to follow up on this and share his thoughts.
> [...]
> 
> Conclusion
> 
> Based on the information above I believe it is viable to ship the patch
> to spyder loosening the versions for python-lsp-server.
> 
> Please let me know your thoughts about this.

Oh, wow, thanks so much for this hard work, Aeliton!  I'm happy with
this proposed patch.  All being well, I'll get some time to work on
spyder et al over the winter holidays.

Best wishes,

   Julian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web