Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #17468

Re: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize, execute, and analyze notebooks

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Control: tags -1 moreinfo

hi Pieter,

did a review of python-papermill, up for sponsorship in the Python
Team:

* repo: for team packages, please follow team policy: i.e. leave the
  distribution at UNRELEASED and don't tag the debian revision
  (unless a package has already been uploaded and the sponsor forgot).

* changelog: there's a separate entry that 'Closes: #1129899'; if
  possible, please attach that to the specific entry that actually
  fixes the bug.

* changelog: mentions addition of a build-dep on python3-arrow (which
  does actually exist and thus had me confused for some time), but
  python3-*py*arrow is what actually appears in d/control. Please
  correct the changelog entry, and add a short explanation for the
  architecture restriction.

* control: unused build-dep on python3-colors? Also see upstream
  changelog.

* control: missing (build-)deps on python3-traitlets, -yaml;
  unconditional imports at:
  papermill/clientwrap.py:6:from traitlets import Bool, Instance
  papermill/iorw.py:11:import yaml
  papermill/cli.py:13:import yaml 

  Both of these appear to be covered by indirect dependencies at the
  time, but that shouldn't be relied on.

* control: the restriction on pyarrow only deals with i386,
  presumably because the salsa CI doesn't try any archs other than
  amd64 and i386. The Debian CI on the other hand runs on more archs;
  does the current setup survive that, or is this package going to
  run into trouble elsewhere as well? If so, you might want to switch
  the current [!i386] to a list of all archs where pyarrow is
  available.

  A similar question applies to the patch that skips the pyarrow
  tests on i386. That could be generalised to check for the
  availability of pyarrow, rather than looking for any specific
  architecture(s).

* patches: the indentation issue that
  fix_indent_error_in_test_iorw.py.patch deals with isn't present in
  the upstream code, but introduced via
  remove-relative-paths-and-entrypoints.diff. Please drop the former
  and instead fix the latter.

* patches: what's the reasoning behind the location change in
  fix_test_s3_locationconstraint.patch?


Please remove the moreinfo tag (and CC me) once you have an updated
package ready.

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Bug#1134172: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize, execute, and analyze notebooks "Pieter Lenaerts" <plenae@disroot.org> - 2026-04-17 13:00 +0200
  Re: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize,  execute, and analyze notebooks Jeroen Ploemen <jcfp@debian.org> - 2026-04-20 14:40 +0200
    Re: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize,  execute, and analyze notebooks "Pieter Lenaerts" <plenae@disroot.org> - 2026-04-21 09:10 +0200
      Re: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize,  execute, and analyze notebooks Jeroen Ploemen <jcfp@debian.org> - 2026-04-21 17:40 +0200

csiph-web