Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #17089

Re: review for python-atom/0.11.0-1

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Jeroen,

thanks for the quick and detailed review.

On 9/29/25 18:17, Jeroen Ploemen wrote:
> * diff between orig tarball from uscan and pristine-tar branch
>    (output from tardiff -m -s):
>    + PKG-INFO
>    + atom.egg-info
>    + atom.egg-info/PKG-INFO
>    + atom.egg-info/SOURCES.txt
>    + atom.egg-info/dependency_links.txt
>    + atom.egg-info/requires.txt
>    + atom.egg-info/top_level.txt
>    + atom/version.py
>    + setup.cfg

I do not know how that could happen. Maybe I started the package with 
the pypi distribution tar. I recreated the repo (and the pristine-tar) 
branch from the uscan information.

> * control: possible missing build-dep on python3-psutil, (optional)
>    import at tests/test_mem.py:21

Thanks for catching this, dependency added.

I added (and forwarded to upstream) a patch to fix a type hint error 
while building the documentation and added the examples to 
pybuild.testfiles. Now all tests are run and only one tests is skipped 
intentionally.

> * control: version requirements for the build-deps on
>    python3-setuptools, python3-setuptools-scm, python3-cppy are
>    ancient (already met in oldstable), please remove.

Removed.

> * d/.docs, d/.examples: files could be moved to the documentation pkg?

Done. As the examples are already referenced in the generated sphinx 
documentation, I added jdupes to link the same files. Keeping the 
examples under /usr/share/doc/python-atom-doc/examples/ might improve 
the discoverability.

> * rules: override of dh_sphinxdoc might ignore nodoc build profile.

Fixed.


> I assume the initial upload was rejected over missing copyright info?

Yes. Once the new upload is sponsored I would reply to the ftpmasters, 
that the issues in the copyright file are fixed.


Thanks,
Alex

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar

Thread

review for python-atom/0.11.0-1 Jeroen Ploemen <jcfp@debian.org> - 2025-09-29 18:20 +0200
  Re: review for python-atom/0.11.0-1 Alexander Sulfrian <alexander@sulfrian.net> - 2025-09-30 10:20 +0200

csiph-web