Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.maint.python > #16555
| From | Peter Wienemann <wiene@debian.org> |
|---|---|
| Newsgroups | linux.debian.maint.python |
| Subject | Re: Upload request: psrecord (NEW) |
| Date | 2024-12-07 22:10 +0100 |
| Message-ID | <JRadP-evkz-3@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <JOruy-cIUu-9@gated-at.bofh.it> <JOViV-d1FM-9@gated-at.bofh.it> <JOViV-d1FM-7@gated-at.bofh.it> <JRadP-evkz-5@gated-at.bofh.it> <JRadP-evkz-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Alexandru,
On 2024-12-06 17:13:18, Alexandru Mihail wrote:
> Pinging about (upload) my last mail, I cleaned up upstream mess on
> psrecord now and I think it's ready for upload. Would really appreciate
> your scrutiny one last time.
I am mostly happy now. There are two issues left:
1. The generated man page is not cleaned up. As a result the package
clean-up validation (see [0]) fails:
----------------------------------------------------------------------
diff /tmp/file-list.pre-build /tmp/file-list.post-build
-------------------------------------------------------
17c17
< /<<PKGBUILDDIR>>/debian directory 220
---
> /<<PKGBUILDDIR>>/debian directory 240
21a22
> /<<PKGBUILDDIR>>/debian/psrecord.1 regular file 1427
fbcd91b4cb61d6616892a323e65daee05a54131e6177ae5b81da9ee4276722a6
----------------------------------------------------------------------
Adding a line
rm -f debian/psrecord.1
to the override_dh_auto_clean target in debian/rules should fix this.
2. The timestamp of the changelog entry is older than the most recent
commit (excluding commits that modify the changelog file).
Bonus item (optional):
In my opinion the legibility of debian/rules files is increased by
adding empty lines between the various targets.
The same also applies to the license text in debian/copyright (cf. lines
3 and 6 of the upstream LICENSE file [1]). Please note that "empty"
lines in the "License" fields of debian/copyright files are denoted by a
dot (".") in the second column.
Best regards
Peter
[0] https://wiki.debian.org/sbuild#Validate_package_cleanup
[1]
https://github.com/astrofrog/psrecord/blob/cda423ed3fa00fadad66cd7a28ed342748d9f88e/LICENSE
Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-11-24 18:00 +0100
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-11-27 20:50 +0100
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-11-30 10:00 +0100
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-12-01 17:50 +0100
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-12-07 22:10 +0100
Re: Upload request: psrecord (NEW) weepingclown <weepingclown@disroot.org> - 2024-12-08 18:00 +0100
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-12-08 18:40 +0100
Re: Upload request: psrecord (NEW) weepingclown <weepingclown@disroot.org> - 2024-12-08 19:50 +0100
Re: Upload request: psrecord (NEW) Peter Wienemann <wiene@debian.org> - 2024-12-08 18:20 +0100
csiph-web