Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod
From: Peter Wienemann <wiene@debian.org>
Newsgroups: linux.debian.maint.python
Subject: Re: Upload request: psrecord (NEW)
Date: Sat, 07 Dec 2024 22:10:01 +0100
Message-ID: <JRadP-evkz-3@gated-at.bofh.it>
References: <JBbQB-3XYB-7@gated-at.bofh.it> <JMo7L-bhbj-9@gated-at.bofh.it> <JMo7L-bhbj-7@gated-at.bofh.it> <JMCDL-bqol-15@gated-at.bofh.it> <JNwcW-c3lM-9@gated-at.bofh.it> <JOruy-cIUu-9@gated-at.bofh.it> <JOViV-d1FM-9@gated-at.bofh.it> <JOViV-d1FM-7@gated-at.bofh.it> <JRadP-evkz-5@gated-at.bofh.it> <JRadP-evkz-7@gated-at.bofh.it>
X-Mailbox-Line: From debian-python-request@lists.debian.org  Sat Dec  7 21:01:46 2024
Old-Return-Path: <wiene@debian.org>
X-Amavis-Spam-Status: No, score=-110.849 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MD5_SHA1_SUM=-1, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Debian-User: wiene
X-Mailing-List: <debian-python@lists.debian.org> archive/latest/22643
List-ID: <debian-python.lists.debian.org>
List-URL: <https://lists.debian.org/debian-python/>
List-Archive: https://lists.debian.org/msgid-search/735d8e62-33ed-47c1-a64a-c5a7800f09fc@debian.org
Approved: robomod@news.nic.it
Lines: 50
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
X-Original-Cc: debian-python@lists.debian.org
X-Original-Date: Sat, 7 Dec 2024 22:01:28 +0100
X-Original-Message-ID: <735d8e62-33ed-47c1-a64a-c5a7800f09fc@debian.org>
X-Original-References: <f3b17ed93c6c77aefec29e6b0d5cde405f6dd01a.camel@gmail.com> <a6b20a60e9e02d8d8b3113fe3b3f44a5d3795b13.camel@gmail.com> <80fe104d-453c-4555-b656-c3123a3bbe35@debian.org> <2f0bf5b0ed4df279b81295343eacf66f9d5ddf35.camel@gmail.com> <b8aec14e-ce50-4b4b-a87a-bd796c6ad0ac@debian.org> <3145534b-cf5e-4cd9-b0f6-23133f24914a@debian.org> <b8ce9f2d7f0a2ade742f3804109543a1bde39382.camel@gmail.com> <e9da7171-880a-47e7-abf3-7954675596e1@debian.org> <c2b8dbda97826df20c71237735b153edb12a6983.camel@gmail.com> <606c0e77e2ef7a267919957015dccc7d2bb51e7f.camel@gmail.com>
Xref: csiph.com linux.debian.maint.python:16555

Hi Alexandru,

On 2024-12-06 17:13:18, Alexandru Mihail wrote:
> Pinging about (upload) my last mail, I cleaned up upstream mess on
> psrecord now and I think it's ready for upload. Would really appreciate
> your scrutiny one last time.

I am mostly happy now. There are two issues left:

1. The generated man page is not cleaned up. As a result the package 
clean-up validation (see [0]) fails:

----------------------------------------------------------------------
diff /tmp/file-list.pre-build /tmp/file-list.post-build
-------------------------------------------------------

17c17
< /<<PKGBUILDDIR>>/debian directory 220
---
 > /<<PKGBUILDDIR>>/debian directory 240
21a22
 > /<<PKGBUILDDIR>>/debian/psrecord.1 regular file 1427 
fbcd91b4cb61d6616892a323e65daee05a54131e6177ae5b81da9ee4276722a6
----------------------------------------------------------------------

Adding a line

     rm -f debian/psrecord.1

to the override_dh_auto_clean target in debian/rules should fix this.

2. The timestamp of the changelog entry is older than the most recent 
commit (excluding commits that modify the changelog file).

Bonus item (optional):
In my opinion the legibility of debian/rules files is increased by 
adding empty lines between the various targets.

The same also applies to the license text in debian/copyright (cf. lines 
3 and 6 of the upstream LICENSE file [1]). Please note that "empty" 
lines in the "License" fields of debian/copyright files are denoted by a 
dot (".") in the second column.

Best regards

Peter

[0] https://wiki.debian.org/sbuild#Validate_package_cleanup
[1] 
https://github.com/astrofrog/psrecord/blob/cda423ed3fa00fadad66cd7a28ed342748d9f88e/LICENSE