Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #15305

review for riscemu/2.2.5-1

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

hi Bo,

I took a look at the riscemu package, put up for sponsorship in the
Python team. Some (mostly minor) issues came up:

* copyright:
  + upstream years are incorrect (license file, sources have 2021-2022
    resp. 2023).
  + leftover boilerplate comments.
  + empty line (dot) at the start of the license paragraph.

* control:
  + no need to mention -doc/-examples pkgs in the long description,
    that's what a suggested dependency is for.
  + tiny (< 10kB) examples package is probably best merged into the
    documentation package.

* rules:
  + weird comment at the top of the file (leftover TODO?).
  + variables for doc and example dirs defined but not used?
  + documentation dir /usr/share/doc/riscemu-doc/; did you mean
    /usr/share/doc/riscemu/?

* d/riscemu-examples.install used for examples; these should be
  handled by dh_installexamples instead.

* lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu].

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

review for riscemu/2.2.5-1 Jeroen Ploemen <jcfp@debian.org> - 2023-11-09 11:40 +0100
  Re: review for riscemu/2.2.5-1 Bo YU <tsu.yubo@gmail.com> - 2023-11-13 10:30 +0100

csiph-web