Path: csiph.com!weretis.net!feeder8.news.weretis.net!fu-berlin.de!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for riscemu/2.2.5-1 Date: Thu, 09 Nov 2023 11:40:01 +0100 Message-ID: X-Original-To: tsu.yubo@gmail.com X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Nov 9 10:32:07 2023 Old-Return-Path: X-Amavis-Spam-Status: No, score=-115 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.581, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Lzcw6tndXfpa53meK9EWRf="; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/21244 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20231109113129.5cdfea90@debian.org Approved: robomod@news.nic.it Lines: 54 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Thu, 9 Nov 2023 11:31:29 +0100 X-Original-Message-ID: <20231109113129.5cdfea90@debian.org> Xref: csiph.com linux.debian.maint.python:15305 --Sig_/Lzcw6tndXfpa53meK9EWRf= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Bo, I took a look at the riscemu package, put up for sponsorship in the Python team. Some (mostly minor) issues came up: * copyright: + upstream years are incorrect (license file, sources have 2021-2022 resp. 2023). + leftover boilerplate comments. + empty line (dot) at the start of the license paragraph. * control: + no need to mention -doc/-examples pkgs in the long description, that's what a suggested dependency is for. + tiny (< 10kB) examples package is probably best merged into the documentation package. * rules: + weird comment at the top of the file (leftover TODO?). + variables for doc and example dirs defined but not used? + documentation dir /usr/share/doc/riscemu-doc/; did you mean /usr/share/doc/riscemu/? * d/riscemu-examples.install used for examples; these should be handled by dh_installexamples instead. * lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu]. --Sig_/Lzcw6tndXfpa53meK9EWRf= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmVMtQEACgkQQoMEoXSN zHq+GA//Wj0ZQa8IOwz8tgvB5AW6t/6ZzhnttiJRea4toYxOS1anOwK6QrQwAuo0 z/gNIfxfepYC5/aG2OqK3rM8wgEXlvSTAdj6RTcTxfwFpHcTcMkYjLDnsD9CMJvV D3F1xcIz0KqDO+fyFr8DDkU1KuQcF+nM1nzxwPgONW6v9KGGChggUlRZqNjFnvQf 9V+PihhHI1LKeERR3v3IvLxalZ0B/jQnu1vUmGRGcFwx5xhEiLZZmmYrXo0OlUW/ ni4/u+dje/Z52yWnqjxHo8yv16n2B9oUKLstax81dIhkE8sT8fmQSP2+XIcIm3cX MB1bqaeyH5XuA/1PruymgEJ99OB0JhR7EhsLmvna8NiGF4DK+IECcj+nLZZZw84x jGwDT7Qbwt5YeQ0vv8+plD/2t9A/3zM1FjLmxke+VUrSvDWmuLMAnIyVtgnt19+x OJlfa3JlIVe7ZV6ivP2wHVvtmT7ZyX62C/KFBvqDZQjZxYaYkxEXm8LUqPWG1+ix 2YGT3iyyjpWs96psmPC9V2QJbdJFFf+RFLi9KC6UH/9Lmp/l4XeVMNZytAtbWHa/ GWLHdtzsgFXHdflJhqf9cr+xTT4cCArv4q+uZr5n0wzogM2o0CuaHVHEAfKaOeN3 sARwquiTkrNBv97P1KJIfQPtlHwFePCkNi0IzqcBxcJVszcNQNs= =e6eL -----END PGP SIGNATURE----- --Sig_/Lzcw6tndXfpa53meK9EWRf=--