Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.java > #9150 > unrolled thread

RFS: stegosuite/0.7.2-1 [ITP]

Back to article view | Back to linux.debian.maint.java

Contents

  RFS: stegosuite/0.7.2-1 [ITP] Tobias <tobias@stegosuite.org> - 2016-06-02 20:10 +0200
    Re: RFS: stegosuite/0.7.2-1 [ITP] Markus Koschany <apo@debian.org> - 2016-06-03 13:20 +0200
      Re: RFS: stegosuite/0.7.2-1 [ITP] Tobias <tobias@stegosuite.org> - 2016-06-03 19:30 +0200
        Re: RFS: stegosuite/0.7.2-1 [ITP] Markus Koschany <apo@debian.org> - 2016-06-04 12:30 +0200

#9150 — RFS: stegosuite/0.7.2-1 [ITP]

Dear Java packagers,

I am looking for a sponsor for my package "stegosuite".

* Package name    : stegosuite
  Version         : 0.7.2
  Upstream Author : Stegosuite Developers <devs@stegosuite.org>
* URL             : https://dev.stegosuite.org/Stegosuite/Stegosuite
* License         : GPL3
  Programming Lang: Java
  Description     : Steganography tool to hide information in image files
  
It builds this binary package:

 * stegosuite
  
Package source is available here:

 https://dev.stegosuite.org/Stegosuite/Stegosuite-Debian.git
  
The ITP bug URL is:

 https://bugs.debian.org/825238
 
It would be great if someone could upload this.

Regards,
Tobias

[toc] | [next] | [standalone]

#9151

[Multipart message — attachments visible in raw view] — view raw

Hello Tobias,

I intend to sponsor your package if we can resolve the remaining issues.

Please upload future versions of stegosuite to mentors.debian.net until
the package is officially accepted into Debian. We can later work from
the pkg-java Git repository directly.

Please change the Git VCS fields to the ones we use for the Java team, e.g.

Vcs-Git: git://anonscm.debian.org/pkg-java/stegosuite.git
Vcs-Browser: https://anonscm.debian.org/cgit/pkg-java/stegosuite.git

We usually use three different branches, an upstream branch, a master
branch and a pristine-tar branch. The upstream branch only contains
upstream code whereas master provides the debian directory too.
git-buildpackage is a useful tool to simplify importing of new upstream
releases.

Debian requires that "Every package must be accompanied by a verbatim
copy of its copyright information and distribution license" [1]

debian/copyright is currently incomplete.

main/java/org/stegosuite/image/jpgtemp/james/*

These files appear to be licensed under BSD-3-clause

main/java/org/stegosuite/image/jpgtemp/net/f5/ortega/*

F5 Steganography Software by Andreas Westfeld 1999, without any license
information except a disclaimer. What is the license for those files?

Stegosuite fails to start on my system with the following error message:


Exception in thread "main" java.lang.UnsatisfiedLinkError: Could not
load SWT library. Reasons:
	no swt-pi-gtk-4527 in java.library.path
	no swt-pi-gtk in java.library.path
	Can't load library: /usr/lib/jni/libswt-pi-gtk-4527.so
	Can't load library: /usr/lib/jni/libswt-pi-gtk.so
	Can't load library: /home/apo/.swt/lib/linux/x86_64/libswt-pi-gtk-4527.so
	Can't load library: /home/apo/.swt/lib/linux/x86_64/libswt-pi-gtk.so

	at org.eclipse.swt.internal.Library.loadLibrary(Library.java:331)
	at org.eclipse.swt.internal.Library.loadLibrary(Library.java:236)
	at org.eclipse.swt.internal.gtk.OS.<clinit>(OS.java:38)
	at org.eclipse.swt.internal.Converter.wcsToMbcs(Converter.java:63)
	at org.eclipse.swt.internal.Converter.wcsToMbcs(Converter.java:54)
	at org.eclipse.swt.widgets.Display.<clinit>(Display.java:134)
	at org.stegosuite.ui.gui.Gui.<init>(Gui.java:46)
	at org.stegosuite.Stegosuite.main(Stegosuite.java:15)


I believe this is either due to a wrong or missing dependency or a buggy
start script or both.

Stegosuite depends on libswt-gtk-4-java which in turn depends on
libswt-gtk-4-jni. This package contains a library called
/usr/lib/jni/libswt-pi3-gtk-4527.so. Note the difference here to the
error message above.

You are probably build-depending on the wrong library,
libswt-gtk2-4-jni, too.

Please incorporate the desktop file and the man page in your upstream
project because they are useful for other distributions/people too.

Please add keywords to stegosuite.desktop.

What do you think about adding another subcategory to the desktop file
like: Categories=Graphics;ImageProcessing; ?

https://specifications.freedesktop.org/menu-spec/latest/apas02.html

Regards,

Markus


[1] https://www.debian.org/doc/debian-policy/ch-docs.html

[toc] | [prev] | [next] | [standalone]

#9152

Hi Markus,

thanks a lot for your effort.

On 03.06.2016 13:10, Markus Koschany wrote:
> Please upload future versions of stegosuite to mentors.debian.net
Done

> Please change the Git VCS fields to the ones we use for the Java team
Done

> F5 Steganography Software by Andreas Westfeld 1999, without any license
> information except a disclaimer. What is the license for those files?
It's also BSD. I updated the copyright file accordingly.

> Stegosuite fails to start on my system with the following error message:
I added libswt-cairo-gtk-4-jni as dependency. Now it should work.

> Please add keywords to stegosuite.desktop.
Done

> What do you think about adding another subcategory to the desktop file
> like: Categories=Graphics;ImageProcessing; ?
ImageProcessing seems to belong to Science/Education.
I used Graphics;2DGraphics;RasterGraphics; instead.

Regards,
Tobias

[toc] | [prev] | [next] | [standalone]

#9153

[Multipart message — attachments visible in raw view] — view raw

On 03.06.2016 19:24, Tobias wrote:
> Hi Markus,
> 
> thanks a lot for your effort.

Hi Tobias,

Thanks for your contribution. I have uploaded stegosuite to unstable and
it is now awaiting approval from Debian's ftp team.

I've made some small changes and you can view them here:

https://anonscm.debian.org/cgit/pkg-java/stegosuite.git

Please remember to remove the debian directory from your original
tarball next time because both should be separated from each other. I'd
suggest to follow the git-buildpackage pattern with three branches
master, upstream and pristine-tar. There are several guides about gbp
available on the internet, e.g.

https://wiki.debian.org/PackagingWithGit

Please request to join the Java team on Alioth.

https://alioth.debian.org/projects/pkg-java/

(bottom right, request to join)

Next time you can prepare your updates in Debian's Git repository. A
typical workflow would be to import your next upstream release for
instance with

gbp import-orig stegosuite_0.7.3.orig.tar.gz

Then do your Debian specific changes on master, build the package and
ask for sponsorship on debian-java again.

Regards,

Markus

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.java

csiph-web