Path: csiph.com!news.freedyn.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Markus Koschany Newsgroups: linux.debian.maint.java Subject: Re: RFS: stegosuite/0.7.2-1 [ITP] Date: Fri, 03 Jun 2016 13:20:02 +0200 Message-ID: References: X-Original-To: Tobias , debian-java@lists.debian.org X-Mailbox-Line: From debian-java-request@lists.debian.org Fri Jun 3 11:10:34 2016 Old-Return-Path: X-Amavis-Spam-Status: No, score=-12 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g3RQcUNl3QHmT5hWvhMwQtl4wCAwKOekr" X-Sa-Exim-Scanned: No (on richard.fcube.de); SAEximRunCond expanded to false X-Mailing-List: archive/latest/19479 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/c1f6d708-aef3-e7d7-a162-ca008bac29ce@debian.org Approved: robomod@news.nic.it Lines: 130 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Fri, 3 Jun 2016 13:10:04 +0200 X-Original-Message-ID: X-Original-References: <575075BA.5050305@stegosuite.org> Xref: csiph.com linux.debian.maint.java:9151 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g3RQcUNl3QHmT5hWvhMwQtl4wCAwKOekr Content-Type: multipart/mixed; boundary="J3kK22UkjaW5aQSNhEHSG5bxhjI672HAq" From: Markus Koschany To: Tobias , debian-java@lists.debian.org Message-ID: Subject: Re: RFS: stegosuite/0.7.2-1 [ITP] References: <575075BA.5050305@stegosuite.org> In-Reply-To: <575075BA.5050305@stegosuite.org> --J3kK22UkjaW5aQSNhEHSG5bxhjI672HAq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Tobias, I intend to sponsor your package if we can resolve the remaining issues. Please upload future versions of stegosuite to mentors.debian.net until the package is officially accepted into Debian. We can later work from the pkg-java Git repository directly. Please change the Git VCS fields to the ones we use for the Java team, e.= g. Vcs-Git: git://anonscm.debian.org/pkg-java/stegosuite.git Vcs-Browser: https://anonscm.debian.org/cgit/pkg-java/stegosuite.git We usually use three different branches, an upstream branch, a master branch and a pristine-tar branch. The upstream branch only contains upstream code whereas master provides the debian directory too. git-buildpackage is a useful tool to simplify importing of new upstream releases. Debian requires that "Every package must be accompanied by a verbatim copy of its copyright information and distribution license" [1] debian/copyright is currently incomplete. main/java/org/stegosuite/image/jpgtemp/james/* These files appear to be licensed under BSD-3-clause main/java/org/stegosuite/image/jpgtemp/net/f5/ortega/* F5 Steganography Software by Andreas Westfeld 1999, without any license information except a disclaimer. What is the license for those files? Stegosuite fails to start on my system with the following error message: Exception in thread "main" java.lang.UnsatisfiedLinkError: Could not load SWT library. Reasons: no swt-pi-gtk-4527 in java.library.path no swt-pi-gtk in java.library.path Can't load library: /usr/lib/jni/libswt-pi-gtk-4527.so Can't load library: /usr/lib/jni/libswt-pi-gtk.so Can't load library: /home/apo/.swt/lib/linux/x86_64/libswt-pi-gtk-4527.s= o Can't load library: /home/apo/.swt/lib/linux/x86_64/libswt-pi-gtk.so at org.eclipse.swt.internal.Library.loadLibrary(Library.java:331) at org.eclipse.swt.internal.Library.loadLibrary(Library.java:236) at org.eclipse.swt.internal.gtk.OS.(OS.java:38) at org.eclipse.swt.internal.Converter.wcsToMbcs(Converter.java:63) at org.eclipse.swt.internal.Converter.wcsToMbcs(Converter.java:54) at org.eclipse.swt.widgets.Display.(Display.java:134) at org.stegosuite.ui.gui.Gui.(Gui.java:46) at org.stegosuite.Stegosuite.main(Stegosuite.java:15) I believe this is either due to a wrong or missing dependency or a buggy start script or both. Stegosuite depends on libswt-gtk-4-java which in turn depends on libswt-gtk-4-jni. This package contains a library called /usr/lib/jni/libswt-pi3-gtk-4527.so. Note the difference here to the error message above. You are probably build-depending on the wrong library, libswt-gtk2-4-jni, too. Please incorporate the desktop file and the man page in your upstream project because they are useful for other distributions/people too. Please add keywords to stegosuite.desktop. What do you think about adding another subcategory to the desktop file like: Categories=3DGraphics;ImageProcessing; ? https://specifications.freedesktop.org/menu-spec/latest/apas02.html Regards, Markus [1] https://www.debian.org/doc/debian-policy/ch-docs.html --J3kK22UkjaW5aQSNhEHSG5bxhjI672HAq-- --g3RQcUNl3QHmT5hWvhMwQtl4wCAwKOekr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJXUWWNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE OUFEMTRCOTUxM0I1MUU0AAoJENmtFLlRO1Hk9zwP/A/xvbPv33XKY9WxH5r5MxcT 0HMqzI9T5uDwYSEPY0DCYJd6MWUFn+4Oy8uDi3t2GAWUjuJl4NQRWc7nBvjD//07 wJErKujQfYGEFSqPK7lEo9QO4O9tm36TI6fANpjMBTcBP4wrA+1pQ1vJZr6XFOFU 4bIvYusGtFge0X8pS60meNEhDd5/D/tsqnSMZYKgXyR1pd0ndAse+LYpMpQ0I008 f6IlL6+NKY0ZKu6UCsioyYI5wMuteVL8a+3/a23CmmsKjyp5rkSooznQFcv7hy5J 75Ez9vHJGD8Vm+s3rJkUYT2HKxly71oaVRlIgI0/IHDkqu95bIYIFsH5yETCDdYx 0GiOnGoe5bvNkV2N1RPlfJpQ+uoHlJkPX2ADn8cfcSBnqUhduQmhg1dOh0U6yGzp nspKqesDrUkBy0VQ1oFH9fLvsS8CvQU5wGIAaA0k53npANvoSli7jxWzRgALrCNF zB3/aH0X/iy69vExpmBTFzAdoprSFqLuFeAcDvxMsoJ7qMHuGaHf5p9tHkhoTVBP TYThvxnwGGp2edAru9YsFw2Wbo7Y2LImvsaXcdYAEuCCFAKTAJa2ztNOdJaOnct+ c/HFzI4pMSwADgQD/AULCEtDuFTb+R8xSPb2idz52w4c33iGtKsncrpwPf8v0GKv VJj8KFiVAS170fuZe35D =kf/5 -----END PGP SIGNATURE----- --g3RQcUNl3QHmT5hWvhMwQtl4wCAwKOekr--