Groups > linux.debian.maint.java > #10049

Review of fairsim, libjtransforms-java and libjlargearray-java

From	Markus Koschany <apo@debian.org>
Newsgroups	linux.debian.maint.java
Subject	Review of fairsim, libjtransforms-java and libjlargearray-java
Date	2017-10-02 01:30 +0200
Message-ID	<uvVQm-8jo-3@gated-at.bofh.it> (permalink)
References	(9 earlier) <u7TmG-7Yc-23@gated-at.bofh.it> <u8BnH-3H3-5@gated-at.bofh.it> <u8Bxp-40f-3@gated-at.bofh.it> <uuFui-8sU-13@gated-at.bofh.it> <uuJoe-2om-9@gated-at.bofh.it>
Organization	debian.org

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

I think all three packages are in a good shape but there are some issues.

Standards-Version is 4.1.1 now.

I suggest to remove the -doc packages because I don't believe those
libraries are significant enough to warrant the maintenance of
additional documentation packages but I leave the decision to you. That
would also simplify the packaging a little.

You don't have to add the classpath to the library. The Lintian check
that warned about this issue has recently been removed. If you do it and
use jh_classpath or the *.classpath file then you must specify the
absolute path to the libraries otherwise they won't be found. In general
you rarely need both javahelper and maven-debian-helper in one package.
I believe maven-debian-helper would suffice here and you can remove the
build-dependency on javahelper and the related substvars.

I also suggest to remove the --has-package-version flag from the *.poms
files. There was a recent change in maven-debian-helper that
automatically adds a versioned dependency to reverse-dependencies if one
of their build-dependencies uses this flag. In my opinion in most cases
this is too strict and not what you probably wanted.

Regarding your failing patch I'm not sure. It doesn't sound like it is
Java specific. You can send me your patch and I can take a look though.

Regards,

Markus

Thread

wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-07-10 16:50 +0200
  Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-07-10 17:50 +0200
    Re: wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-07-11 19:00 +0200
      Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-07-13 22:00 +0200
        Re: wanting to join the java team Thorsten Glaser <t.glaser@tarent.de> - 2017-07-14 10:00 +0200
        Re: wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-07-14 18:00 +0200
          Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-07-14 20:20 +0200
            Re: wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-07-14 22:30 +0200
              Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-07-16 23:50 +0200
                Re: wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-07-27 18:00 +0200
                Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-07-27 18:00 +0200
                Re: wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-07-29 17:00 +0200
                Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-07-29 17:10 +0200
                Re: wanting to join the java team Carnë Draug <carandraug+dev@gmail.com> - 2017-09-28 13:50 +0200
                Re: wanting to join the java team Markus Koschany <apo@debian.org> - 2017-09-28 18:00 +0200
                Review of fairsim, libjtransforms-java and libjlargearray-java Markus Koschany <apo@debian.org> - 2017-10-02 01:30 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Emmanuel Bourg <ebourg@apache.org> - 2017-10-02 23:00 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Markus Koschany <apo@debian.org> - 2017-10-03 19:40 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Emmanuel Bourg <ebourg@apache.org> - 2017-10-02 23:20 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Markus Koschany <apo@debian.org> - 2017-10-02 23:50 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Carnë Draug <carandraug+dev@gmail.com> - 2017-10-03 17:40 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Markus Koschany <apo@debian.org> - 2017-10-03 19:20 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Carnë Draug <carandraug+dev@gmail.com> - 2017-10-04 17:50 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Markus Koschany <apo@debian.org> - 2017-10-04 19:20 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Carnë Draug <carandraug+dev@gmail.com> - 2017-10-05 13:10 +0200
                Re: Review of fairsim, libjtransforms-java and libjlargearray-java Markus Koschany <apo@debian.org> - 2017-10-05 14:40 +0200

csiph-web